Re: [PATCH v9 5/7] arm64: kvm: Introduce KVM_ARM_SET_SERROR_ESR ioctl

2018-02-04 Thread gengdongjiu
James, Thank you for your time to reply me. On 2018/1/31 3:21, James Morse wrote: > Hi gengdongjiu, > > On 24/01/18 20:06, gengdongjiu wrote: >>> On 06/01/18 16:02, Dongjiu Geng wrote: The ARM64 RAS SError Interrupt(SEI) syndrome value is specific to the guest and user space needs a

Re: [PATCH 1/2] ARM: kvm: fix building with gcc-8

2018-02-04 Thread Arnd Bergmann
On Sun, Feb 4, 2018 at 7:45 PM, Christoffer Dall wrote: > Hi Arnd, > > On Fri, Feb 02, 2018 at 04:07:34PM +0100, Arnd Bergmann wrote: >> In banked-sr.c, we use a top-level '__asm__(".arch_extension virt")' >> statement to allow compilation of a multi-CPU kernel for

Re: [PATCH 1/2] ARM: kvm: fix building with gcc-8

2018-02-04 Thread Christoffer Dall
Hi Arnd, On Fri, Feb 02, 2018 at 04:07:34PM +0100, Arnd Bergmann wrote: > In banked-sr.c, we use a top-level '__asm__(".arch_extension virt")' > statement to allow compilation of a multi-CPU kernel for ARMv6 > and older ARMv7-A that don't normally support access to the banked > registers. > >

Re: [PATCH v3 12/18] arm64: KVM: Add SMCCC_ARCH_WORKAROUND_1 fast handling

2018-02-04 Thread Christoffer Dall
On Thu, Feb 01, 2018 at 11:46:51AM +, Marc Zyngier wrote: > We want SMCCC_ARCH_WORKAROUND_1 to be fast. As fast as possible. > So let's intercept it as early as we can by testing for the > function call number as soon as we've identified a HVC call > coming from the guest. Hmmm. How often is

Re: [PATCH v3 11/18] arm64: KVM: Report SMCCC_ARCH_WORKAROUND_1 BP hardening support

2018-02-04 Thread Christoffer Dall
On Thu, Feb 01, 2018 at 11:46:50AM +, Marc Zyngier wrote: > A new feature of SMCCC 1.1 is that it offers firmware-based CPU > workarounds. In particular, SMCCC_ARCH_WORKAROUND_1 provides > BP hardening for CVE-2017-5715. > > If the host has some mitigation for this issue, report that > we

Re: [PATCH v3 09/18] arm/arm64: KVM: Advertise SMCCC v1.1

2018-02-04 Thread Christoffer Dall
On Thu, Feb 01, 2018 at 11:46:48AM +, Marc Zyngier wrote: > The new SMC Calling Convention (v1.1) allows for a reduced overhead > when calling into the firmware, and provides a new feature discovery > mechanism. > > Make it visible to KVM guests. > Reviewed-by: Christoffer Dall

Re: [PATCH v3 10/18] arm/arm64: KVM: Turn kvm_psci_version into a static inline

2018-02-04 Thread Christoffer Dall
On Thu, Feb 01, 2018 at 11:46:49AM +, Marc Zyngier wrote: > We're about to need kvm_psci_version in HYP too. So let's turn it > into a static inline, and pass the kvm structure as a second > parameter (so that HYP can do a kern_hyp_va on it). > Reviewed-by: Christoffer Dall

Re: [PATCH v3 08/18] arm/arm64: KVM: Add PSCI version selection API

2018-02-04 Thread Christoffer Dall
Hi Marc, [ I know we're discussing the overall approach in parallel, but here are some comments on the specifics of this patch, should it end up being used in some capacity ] On Thu, Feb 01, 2018 at 11:46:47AM +, Marc Zyngier wrote: > Although we've implemented PSCI 1.0 and 1.1, nothing

Re: [PATCH v3 08/18] arm/arm64: KVM: Add PSCI version selection API

2018-02-04 Thread Christoffer Dall
On Sat, Feb 03, 2018 at 11:59:32AM +, Marc Zyngier wrote: > On Fri, 2 Feb 2018 21:17:06 +0100 > Andrew Jones wrote: > > > On Thu, Feb 01, 2018 at 11:46:47AM +, Marc Zyngier wrote: > > > Although we've implemented PSCI 1.0 and 1.1, nothing can select them > > > Since