Re: [PATCH] arm64: vgic-v2: Fix proxying of cpuif access

2018-04-29 Thread Christoffer Dall
On Fri, Apr 27, 2018 at 03:51:02PM +0100, Marc Zyngier wrote: > Proxying the cpuif accesses at EL2 makes use of vcpu_data_guest_to_host > and co, which check the endianness, which call into vcpu_read_sys_reg... > which isn't mapped at EL2 (it was inlined before, and got moved OoL > with the VHE opt

Re: [PATCH v4 06/12] KVM: arm/arm64: Adapt vgic_v3_check_base to multiple rdist regions

2018-04-29 Thread Christoffer Dall
On Fri, Apr 27, 2018 at 04:14:59PM +0200, Eric Auger wrote: > vgic_v3_check_base() currently only handles the case of a unique > legacy redistributor region whose size is not explicitly set but > infered, instead, from the number of online vcpus. nit: inferred > > We adapt it to handle the case

Re: [PATCH v4 08/12] KVM: arm/arm64: Check vcpu redist base before registering an iodev

2018-04-29 Thread Christoffer Dall
On Fri, Apr 27, 2018 at 04:15:01PM +0200, Eric Auger wrote: > As we are going to register several redist regions, > vgic_register_all_redist_iodevs() may be called several times. We need > to register a redist_iodev for a given vcpu only once. So let's > check if the base address has already been s

Re: [PATCH v4 09/12] KVM: arm/arm64: Check all vcpu redistributors are set on map_resources

2018-04-29 Thread Christoffer Dall
On Fri, Apr 27, 2018 at 04:15:02PM +0200, Eric Auger wrote: > On vcpu first run, we eventually know the actual number of vcpus. > This is a synchronization point to check all redistributors > were assigned. On kvm_vgic_map_resources() we check both dist and > redist were set, eventually check poten

Re: [PATCH v4 12/12] KVM: arm/arm64: Bump VGIC_V3_MAX_CPUS to 512

2018-04-29 Thread Christoffer Dall
On Fri, Apr 27, 2018 at 04:15:05PM +0200, Eric Auger wrote: > Let's raise the number of supported vcpus along with > vgic v3 now that HW is looming with more physical CPUs. > > Signed-off-by: Eric Auger Acked-by: Christoffer Dall > --- > include/kvm/arm_vgic.h | 2 +- > 1 file changed, 1 inse

Re: [PATCH] arm64: vgic-v2: Fix proxying of cpuif access

2018-04-29 Thread Marc Zyngier
On Sun, 29 Apr 2018 14:34:32 +0200 Christoffer Dall wrote: > On Fri, Apr 27, 2018 at 03:51:02PM +0100, Marc Zyngier wrote: > > Proxying the cpuif accesses at EL2 makes use of vcpu_data_guest_to_host > > and co, which check the endianness, which call into vcpu_read_sys_reg... > > which isn't mappe

Re: [PATCH] arm64: vgic-v2: Fix proxying of cpuif access

2018-04-29 Thread Christoffer Dall
On Sun, Apr 29, 2018 at 02:05:07PM +0100, Marc Zyngier wrote: > On Sun, 29 Apr 2018 14:34:32 +0200 > Christoffer Dall wrote: > > > On Fri, Apr 27, 2018 at 03:51:02PM +0100, Marc Zyngier wrote: > > > Proxying the cpuif accesses at EL2 makes use of vcpu_data_guest_to_host > > > and co, which check