Re: [PATCH v5 13/26] KVM: arm64/sve: System register context switch and access support

2019-02-27 Thread Julien Grall
Hi Dave, On 2/26/19 5:01 PM, Dave Martin wrote: On Tue, Feb 26, 2019 at 04:32:30PM +, Julien Grall wrote: On 18/02/2019 19:52, Dave Martin wrote: We seem to already have code for handling invariant registers as well as reading ID register. I guess the only reason you can't use them is becau

Re: [PATCH 1/5] KVM: arm/arm64: Reset the VCPU without preemption and vcpu state loaded

2019-02-27 Thread Dave Martin
On Tue, Feb 26, 2019 at 01:53:52PM +, Dave Martin wrote: > On Wed, Feb 20, 2019 at 07:41:43PM +, Marc Zyngier wrote: > > On Wed, 20 Feb 2019 19:14:53 + > > Dave Martin wrote: [...] > > > Perhaps an alternative approach would be to nobble the preempt notifier > > > and stick an explic

Re: [PATCH v5 14/26] KVM: arm64/sve: Context switch the SVE registers

2019-02-27 Thread Dave Martin
On Tue, Feb 26, 2019 at 04:56:36PM +, Julien Grall wrote: > Hi Dave, > > On 26/02/2019 12:13, Dave Martin wrote: > >On Wed, Feb 20, 2019 at 04:46:57PM +, Julien Thierry wrote: > >> > >> > >>On 18/02/2019 19:52, Dave Martin wrote: > >>>In order to give each vcpu its own view of the SVE regi

Re: [PATCH v5 13/26] KVM: arm64/sve: System register context switch and access support

2019-02-27 Thread Dave Martin
On Wed, Feb 27, 2019 at 12:02:46PM +, Julien Grall wrote: > Hi Dave, > > On 2/26/19 5:01 PM, Dave Martin wrote: > >On Tue, Feb 26, 2019 at 04:32:30PM +, Julien Grall wrote: > >>On 18/02/2019 19:52, Dave Martin wrote: > >>We seem to already have code for handling invariant registers as well

Re: [PATCH v5 13/26] KVM: arm64/sve: System register context switch and access support

2019-02-27 Thread Julien Grall
Hi Dave, On 2/27/19 1:50 PM, Dave Martin wrote: On Wed, Feb 27, 2019 at 12:02:46PM +, Julien Grall wrote: Hi Dave, On 2/26/19 5:01 PM, Dave Martin wrote: On Tue, Feb 26, 2019 at 04:32:30PM +, Julien Grall wrote: On 18/02/2019 19:52, Dave Martin wrote: We seem to already have code for

Re: [PATCH v5 13/26] KVM: arm64/sve: System register context switch and access support

2019-02-27 Thread Dave Martin
On Wed, Feb 27, 2019 at 02:17:06PM +, Julien Grall wrote: > Hi Dave, > > On 2/27/19 1:50 PM, Dave Martin wrote: > >On Wed, Feb 27, 2019 at 12:02:46PM +, Julien Grall wrote: > >>Hi Dave, > >> > >>On 2/26/19 5:01 PM, Dave Martin wrote: [...] > >>>The access_id_aa64zfr0_el1() should still b

Re: [PATCH v6 1/6] arm64/kvm: preserve host HCR_EL2 value

2019-02-27 Thread Amit Daniel Kachhap
Hi, On 2/21/19 5:20 PM, Mark Rutland wrote: Hi, On Tue, Feb 19, 2019 at 02:54:26PM +0530, Amit Daniel Kachhap wrote: From: Mark Rutland When restoring HCR_EL2 for the host, KVM uses HCR_HOST_VHE_FLAGS, which is a constant value. This works today, as the host HCR_EL2 value is always the same,