Re: [PATCH v7 12/27] KVM: arm64/sve: System register context switch and access support

2019-04-24 Thread Alex Bennée
Dave Martin writes: > This patch adds the necessary support for context switching ZCR_EL1 > for each vcpu. > > ZCR_EL1 is trapped alongside the FPSIMD/SVE registers, so it makes > sense for it to be handled as part of the guest FPSIMD/SVE context > for context switch purposes instead of

Re: [PATCH v7 13/27] KVM: arm64/sve: Context switch the SVE registers

2019-04-24 Thread Alex Bennée
Dave Martin writes: > On Thu, Apr 04, 2019 at 10:35:02AM +0200, Andrew Jones wrote: >> On Thu, Apr 04, 2019 at 09:10:08AM +0100, Dave Martin wrote: >> > On Wed, Apr 03, 2019 at 10:01:45PM +0200, Andrew Jones wrote: >> > > On Fri, Mar 29, 2019 at 01:00:38PM +, Dave Martin wrote: >> > > > In

Re: [PATCH v10 2/5] KVM: arm/arm64: context-switch ptrauth registers

2019-04-24 Thread Dave P Martin
On Wed, Apr 24, 2019 at 03:29:26PM +0100, Marc Zyngier wrote: > On 24/04/2019 14:39, Dave Martin wrote: > > On Tue, Apr 23, 2019 at 10:12:35AM +0530, Amit Daniel Kachhap wrote: > >> From: Mark Rutland > >> > >> When pointer authentication is supported, a guest may wish to use it. > >> This patch

Re: [PATCH v10 2/5] KVM: arm/arm64: context-switch ptrauth registers

2019-04-24 Thread Marc Zyngier
On 24/04/2019 14:39, Dave Martin wrote: > On Tue, Apr 23, 2019 at 10:12:35AM +0530, Amit Daniel Kachhap wrote: >> From: Mark Rutland >> >> When pointer authentication is supported, a guest may wish to use it. >> This patch adds the necessary KVM infrastructure for this to work, with >> a

Re: [PATCH v4 0/3] vfio-pci: Support INTx mode re-enabling

2019-04-24 Thread Leo Yan
Hi Will, On Mon, Apr 08, 2019 at 09:27:16AM +0800, Leo Yan wrote: > When enable vfio-pci mode for NIC driver on Juno board, the IRQ is > failed to forward properly from host to guest, finally root caused this > issue is related with kvmtool cannot re-enable INTx mode properly. > > So the basic

Re: [PATCH v7 11/27] KVM: arm64: Support runtime sysreg visibility filtering

2019-04-24 Thread Dave Martin
On Wed, Apr 24, 2019 at 09:39:31AM +, Alex Bennée wrote: > > Dave Martin writes: > > > Some optional features of the Arm architecture add new system > > registers that are not present in the base architecture. > > > > Where these features are optional for the guest, the visibility of > >

Re: [PATCH v7 17/27] KVM: arm64: Reject ioctl access to FPSIMD V-regs on SVE vcpus

2019-04-24 Thread Alex Bennée
Dave Martin writes: > In order to avoid the pointless complexity of maintaining two ioctl > register access views of the same data, this patch blocks ioctl > access to the FPSIMD V-registers on vcpus that support SVE. > > This will make it more straightforward to add SVE register access >

Re: [PATCH v10 1/5] KVM: arm64: Add a vcpu flag to control ptrauth for guest

2019-04-24 Thread Dave Martin
On Wed, Apr 24, 2019 at 11:27:50AM +0530, Amit Daniel Kachhap wrote: > Hi, > > On 4/23/19 9:14 PM, Dave Martin wrote: > >On Tue, Apr 23, 2019 at 10:12:34AM +0530, Amit Daniel Kachhap wrote: > >>A per vcpu flag is added to check if pointer authentication is > >>enabled for the vcpu or not. This

Re: [kvmtool PATCH v10 5/5] KVM: arm/arm64: Add a vcpu feature for pointer authentication

2019-04-24 Thread Dave Martin
On Wed, Apr 24, 2019 at 12:32:22PM +0530, Amit Daniel Kachhap wrote: > Hi, > > On 4/23/19 9:16 PM, Dave Martin wrote: > >On Tue, Apr 23, 2019 at 10:12:38AM +0530, Amit Daniel Kachhap wrote: > >>This patch adds a runtime capabality for KVM tool to enable Arm64 8.3 > >>Pointer Authentication in

Re: [PATCH v10 2/5] KVM: arm/arm64: context-switch ptrauth registers

2019-04-24 Thread Dave Martin
On Wed, Apr 24, 2019 at 11:29:37AM +0100, Marc Zyngier wrote: > On 23/04/2019 16:44, Dave Martin wrote: > > On Tue, Apr 23, 2019 at 03:54:32PM +0530, Amit Daniel Kachhap wrote: > >> Hi Mark, > >> > >> On 4/23/19 3:09 PM, Marc Zyngier wrote: > >>> On Tue, 23 Apr 2019 05:42:35 +0100, > >>> Amit

Re: [PATCH v10 2/5] KVM: arm/arm64: context-switch ptrauth registers

2019-04-24 Thread Dave Martin
On Tue, Apr 23, 2019 at 10:12:35AM +0530, Amit Daniel Kachhap wrote: > From: Mark Rutland > > When pointer authentication is supported, a guest may wish to use it. > This patch adds the necessary KVM infrastructure for this to work, with > a semi-lazy context switch of the pointer auth state. >

Re: [PATCH v10 2/5] KVM: arm/arm64: context-switch ptrauth registers

2019-04-24 Thread Marc Zyngier
On 23/04/2019 16:44, Dave Martin wrote: > On Tue, Apr 23, 2019 at 03:54:32PM +0530, Amit Daniel Kachhap wrote: >> Hi Mark, >> >> On 4/23/19 3:09 PM, Marc Zyngier wrote: >>> On Tue, 23 Apr 2019 05:42:35 +0100, >>> Amit Daniel Kachhap wrote: From: Mark Rutland When pointer

Re: [PATCH v7 11/27] KVM: arm64: Support runtime sysreg visibility filtering

2019-04-24 Thread Alex Bennée
Dave Martin writes: > Some optional features of the Arm architecture add new system > registers that are not present in the base architecture. > > Where these features are optional for the guest, the visibility of > these registers may need to depend on some runtime configuration, > such as a

Re: [PATCH v2 00/14] KVM: arm64: SVE cleanups

2019-04-24 Thread Marc Zyngier
On 24/04/2019 10:21, Alex Bennée wrote: > > Dave Martin writes: > >> This series contains some cleanups applicable to the SVE KVM support >> patches merged into kvmarm/next. These arose from Andrew Jones' >> review. > > Does this mean these won't get merged into the original series before >

Re: [PATCH v7 01/27] KVM: Documentation: Document arm64 core registers in detail

2019-04-24 Thread Alex Bennée
Dave Martin writes: > Since the the sizes of individual members of the core arm64 > registers vary, the list of register encodings that make sense is > not a simple linear sequence. > > To clarify which encodings to use, this patch adds a brief list > to the documentation. > > Signed-off-by:

Re: [PATCH v2 00/14] KVM: arm64: SVE cleanups

2019-04-24 Thread Alex Bennée
Dave Martin writes: > This series contains some cleanups applicable to the SVE KVM support > patches merged into kvmarm/next. These arose from Andrew Jones' > review. Does this mean these won't get merged into the original series before the final merging upstream? -- Alex Bennée

Re: [PATCH] KVM: arm/arm64: inject an async abort to host if SEA handling failed

2019-04-24 Thread Marc Zyngier
On 24/04/2019 05:41, Dongjiu Geng wrote: > If host failed to handle the SEA, KVM should inject an async abort > to guest for both SEA data and instruction abort, but it currently > only handles the data abort, so correct it. > > Cc: James Morse > Cc: Xiang Zheng > Signed-off-by: Dongjiu Geng >

Re: [kvmtool PATCH v10 5/5] KVM: arm/arm64: Add a vcpu feature for pointer authentication

2019-04-24 Thread Amit Daniel Kachhap
Hi, On 4/23/19 9:16 PM, Dave Martin wrote: On Tue, Apr 23, 2019 at 10:12:38AM +0530, Amit Daniel Kachhap wrote: This patch adds a runtime capabality for KVM tool to enable Arm64 8.3 Pointer Authentication in guest kernel. Two vcpu features KVM_ARM_VCPU_PTRAUTH_[ADDRESS/GENERIC] are supplied

Re: [PATCH v10 3/5] KVM: arm64: Add userspace flag to enable pointer authentication

2019-04-24 Thread Amit Daniel Kachhap
Hi, On 4/23/19 9:15 PM, Dave Martin wrote: On Tue, Apr 23, 2019 at 10:12:36AM +0530, Amit Daniel Kachhap wrote: Now that the building blocks of pointer authentication are present, lets add userspace flags KVM_ARM_VCPU_PTRAUTH_ADDRESS and KVM_ARM_VCPU_PTRAUTH_GENERIC. These flags will enable

Re: [PATCH v10 1/5] KVM: arm64: Add a vcpu flag to control ptrauth for guest

2019-04-24 Thread Amit Daniel Kachhap
Hi, On 4/23/19 9:14 PM, Dave Martin wrote: On Tue, Apr 23, 2019 at 10:12:34AM +0530, Amit Daniel Kachhap wrote: A per vcpu flag is added to check if pointer authentication is enabled for the vcpu or not. This flag may be enabled according to the necessary user policies and host capabilities.