Re: [kvm-unit-tests PATCH 05/10] arm: pmu: Basic event counter Tests

2020-01-09 Thread Auger Eric
Hi Andre, On 1/7/20 1:19 PM, Andre Przywara wrote: > On Mon, 16 Dec 2019 21:47:52 +0100 > Eric Auger wrote: > > Hi Eric, > > thanks a lot for your work on these elaborate tests! I have some PMU test > extensions as well, but they are nowhere as sophisticated as yours! > > Just ran this on my

Re: [PATCH 05/14] x86/mm: Introduce lookup_address_in_mm()

2020-01-09 Thread Thomas Gleixner
Sean Christopherson writes: > diff --git a/arch/x86/include/asm/pgtable_types.h > b/arch/x86/include/asm/pgtable_types.h > index b5e49e6bac63..400ac8da75e8 100644 > --- a/arch/x86/include/asm/pgtable_types.h > +++ b/arch/x86/include/asm/pgtable_types.h > @@ -561,6 +561,10 @@ static inline void u

Re: [PATCH v2 11/18] KVM: arm64: don't trap Statistical Profiling controls to EL2

2020-01-09 Thread Andrew Murray
On Thu, Jan 09, 2020 at 05:42:51PM +, Mark Rutland wrote: > Hi Andrew, > > On Thu, Jan 09, 2020 at 05:25:12PM +, Andrew Murray wrote: > > On Mon, Dec 23, 2019 at 12:10:42PM +, Andrew Murray wrote: > > > On Mon, Dec 23, 2019 at 12:05:12PM +, Marc Zyngier wrote: > > > > On 2019-12-23

Re: [PATCH v2 11/18] KVM: arm64: don't trap Statistical Profiling controls to EL2

2020-01-09 Thread Mark Rutland
Hi Andrew, On Thu, Jan 09, 2020 at 05:25:12PM +, Andrew Murray wrote: > On Mon, Dec 23, 2019 at 12:10:42PM +, Andrew Murray wrote: > > On Mon, Dec 23, 2019 at 12:05:12PM +, Marc Zyngier wrote: > > > On 2019-12-23 11:56, Andrew Murray wrote: > > > > My original concern in the cover lett

Re: [kvm-unit-tests PATCH 04/10] arm: pmu: Check Required Event Support

2020-01-09 Thread Auger Eric
Hi Andre, On 1/9/20 6:30 PM, André Przywara wrote: > On 09/01/2020 16:54, Auger Eric wrote: > > Hi Eric, > >> On 1/3/20 7:12 PM, Andre Przywara wrote: >>> On Mon, 16 Dec 2019 21:47:51 +0100 >>> Eric Auger wrote: >>> >>> Hi Eric, >>> If event counters are implemented check the common events

Re: [kvm-unit-tests PATCH 04/10] arm: pmu: Check Required Event Support

2020-01-09 Thread André Przywara
On 09/01/2020 16:54, Auger Eric wrote: Hi Eric, > On 1/3/20 7:12 PM, Andre Przywara wrote: >> On Mon, 16 Dec 2019 21:47:51 +0100 >> Eric Auger wrote: >> >> Hi Eric, >> >>> If event counters are implemented check the common events >>> required by the PMUv3 are implemented. >>> >>> Some are uncond

Re: [PATCH v2 11/18] KVM: arm64: don't trap Statistical Profiling controls to EL2

2020-01-09 Thread Andrew Murray
On Mon, Dec 23, 2019 at 12:10:42PM +, Andrew Murray wrote: > On Mon, Dec 23, 2019 at 12:05:12PM +, Marc Zyngier wrote: > > On 2019-12-23 11:56, Andrew Murray wrote: > > > On Sun, Dec 22, 2019 at 10:42:05AM +, Marc Zyngier wrote: > > > > On Fri, 20 Dec 2019 14:30:18 +, > > > > Andrew

Re: [kvm-unit-tests PATCH 04/10] arm: pmu: Check Required Event Support

2020-01-09 Thread Auger Eric
Hi Andre, On 1/3/20 7:12 PM, Andre Przywara wrote: > On Mon, 16 Dec 2019 21:47:51 +0100 > Eric Auger wrote: > > Hi Eric, > >> If event counters are implemented check the common events >> required by the PMUv3 are implemented. >> >> Some are unconditionally required (SW_INCR, CPU_CYCLES, >> eith

[RFC v5 49/57] arm64: kvm: Annotate non-standard stack frame functions

2020-01-09 Thread Julien Thierry
From: Raphael Gault Both __guest_entry and __guest_exit functions do not setup a correct stack frame. Because they can be considered as callable functions, even if they are particular cases, we chose to silence the warnings given by objtool by annotating them as non-standard. Signed-off-by: Raph

[RFC v5 52/57] arm64: kernel: Annotate non-standard stack frame functions

2020-01-09 Thread Julien Thierry
From: Raphael Gault Annotate assembler functions which are callable but do not setup a correct stack frame. Signed-off-by: Raphael Gault Signed-off-by: Julien Thierry Cc: Marc Zyngier Cc: James Morse Cc: Suzuki K Poulose Cc: kvmarm@lists.cs.columbia.edu --- arch/arm64/kernel/hyp-stub.S | 3

Re: [PATCH 0/1] arm/arm64: add support for folded p4d page tables

2020-01-09 Thread Mike Rapoport
On Thu, Jan 09, 2020 at 08:38:54AM +0530, Anshuman Khandual wrote: > > > On 12/30/2019 01:57 PM, Mike Rapoport wrote: > > From: Mike Rapoport > > > > Hi, > > Hello Mike, > > > > > This is a part of clean up of the page table manipulation code that aims to > > remove asm-generic/5level-fixup.

Re: [PATCH v2 6/6] KVM: arm64: Support the VCPU preemption check

2020-01-09 Thread Steven Price
On 26/12/2019 13:58, Zengruan Ye wrote: Support the vcpu_is_preempted() functionality under KVM/arm64. This will enhance lock performance on overcommitted hosts (more runnable VCPUs than physical CPUs in the system) as doing busy waits for preempted VCPUs will hurt system performance far worse th

Re: [PATCH v2 3/6] KVM: arm64: Support pvlock preempted via shared structure

2020-01-09 Thread Steven Price
On 26/12/2019 13:58, Zengruan Ye wrote: Implement the service call for configuring a shared structure between a VCPU and the hypervisor in which the hypervisor can tell the VCPU is running or not. The preempted field is zero if 1) some old KVM deos not support this filed. NIT: s/deos/does/ Ho

Re: [PATCH v2 1/6] KVM: arm64: Document PV-lock interface

2020-01-09 Thread Steven Price
On 26/12/2019 13:58, Zengruan Ye wrote: Introduce a paravirtualization interface for KVM/arm64 to obtain the VCPU is currently running or not. The PV lock structure of the guest is allocated by user space. A hypercall interface is provided for the guest to interrogate the hypervisor's support f

Re: [PATCH v2 09/18] arm64: KVM: enable conditional save/restore full SPE profiling buffer controls

2020-01-09 Thread Will Deacon
On Thu, Jan 09, 2020 at 11:25:04AM +, Andrew Murray wrote: > On Thu, Jan 09, 2020 at 11:23:37AM +, Andrew Murray wrote: > > On Wed, Jan 08, 2020 at 01:10:21PM +, Will Deacon wrote: > > > On Wed, Jan 08, 2020 at 12:36:11PM +, Marc Zyngier wrote: > > > > On 2020-01-08 11:58, Will Deac

Re: [PATCH v2 09/18] arm64: KVM: enable conditional save/restore full SPE profiling buffer controls

2020-01-09 Thread Andrew Murray
On Thu, Jan 09, 2020 at 11:23:37AM +, Andrew Murray wrote: > On Wed, Jan 08, 2020 at 01:10:21PM +, Will Deacon wrote: > > On Wed, Jan 08, 2020 at 12:36:11PM +, Marc Zyngier wrote: > > > On 2020-01-08 11:58, Will Deacon wrote: > > > > On Wed, Jan 08, 2020 at 11:17:16AM +, Marc Zyngie

Re: [PATCH v2 09/18] arm64: KVM: enable conditional save/restore full SPE profiling buffer controls

2020-01-09 Thread Andrew Murray
On Wed, Jan 08, 2020 at 01:10:21PM +, Will Deacon wrote: > On Wed, Jan 08, 2020 at 12:36:11PM +, Marc Zyngier wrote: > > On 2020-01-08 11:58, Will Deacon wrote: > > > On Wed, Jan 08, 2020 at 11:17:16AM +, Marc Zyngier wrote: > > > > On 2020-01-07 15:13, Andrew Murray wrote: > > > > > Lo

Re: [RFC PATCH v9 7/8] ptp: arm64: Enable ptp_kvm for arm64

2020-01-09 Thread Marc Zyngier
On 2020-01-09 09:24, Marc Zyngier wrote: On 2020-01-09 05:59, Jianyong Wu wrote: [...] So we focus it on arm64. Also I have never tested it on arm32 machine ( we lack of arm32 machine) I'm sure your employer can provide you with such a box. I can probably even tell you which cupboard they a

Re: [RFC PATCH v9 7/8] ptp: arm64: Enable ptp_kvm for arm64

2020-01-09 Thread Marc Zyngier
On 2020-01-09 05:59, Jianyong Wu wrote: Hi Marc, -Original Message- From: Marc Zyngier Sent: Tuesday, January 7, 2020 5:29 PM To: Jianyong Wu Cc: net...@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org; t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.co

Re: [RFC PATCH v9 6/8] psci: Add hvc call service for ptp_kvm.

2020-01-09 Thread Marc Zyngier
On 2020-01-09 05:45, Jianyong Wu wrote: Hi Marc, -Original Message- From: Marc Zyngier Sent: Tuesday, January 7, 2020 5:16 PM To: Jianyong Wu Cc: net...@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org; t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.co