Re: [kvm-unit-tests PATCH v3 09/14] arm/arm64: ITS: Device and collection Initialization

2020-03-05 Thread Auger Eric
Hi Zenghui, On 2/7/20 6:41 AM, Zenghui Yu wrote: > Hi Eric, > > On 2020/1/28 18:34, Eric Auger wrote: >> Introduce an helper functions to register >> - a new device, characterized by its device id and the >>    max number of event IDs that dimension its ITT (Interrupt >>    Translation Table).  T

Re: [kvm-unit-tests PATCH v3 06/14] arm/arm64: gicv3: Set the LPI config and pending tables

2020-03-05 Thread Auger Eric
Hi Zenghui, On 2/7/20 3:12 AM, Zenghui Yu wrote: > Hi Eric, > > On 2020/1/28 18:34, Eric Auger wrote: >> Allocate the LPI configuration and per re-distributor pending table. >> Set redistributor's PROPBASER and PENDBASER. The LPIs are enabled >> by default in the config table. >> >> Also introduc

Re: [kvm-unit-tests PATCH v3 08/14] arm/arm64: ITS: its_enable_defaults

2020-03-05 Thread Auger Eric
Hi Drew, On 2/7/20 1:41 PM, Andrew Jones wrote: > On Tue, Jan 28, 2020 at 11:34:53AM +0100, Eric Auger wrote: >> its_enable_defaults() is the top init function that allocates the >> command queue and all the requested tables (device, collection, >> lpi config and pending tables), enable LPIs at di

Re: [PATCH v6 0/6] KASan for arm

2020-03-05 Thread Marco Felsch
On 20-03-05 09:43, Linus Walleij wrote: > Hi Florian, > > On Fri, Jan 17, 2020 at 8:55 PM Florian Fainelli wrote: > > > Let me submit and rebase v7 get the auto builders some days to see if it > > exposes a new build issue and then we toss it to RMK's patch tracker and > > fix bugs from there? >

Re: [kvm-unit-tests PATCH v2 8/9] arm: gic: Provide per-IRQ helper functions

2020-03-05 Thread Alexandru Elisei
Hi, I'm going to reiterate the comments I posted on this exact same patch sent by Andre [1], and add a few new ones. [1] https://www.spinics.net/lists/arm-kernel/msg767690.html On 3/5/20 9:55 AM, Andrew Jones wrote: > On Thu, Jan 30, 2020 at 12:25:09PM +0100, Eric Auger wrote: >> From: Andre Prz

Re: [kvm-unit-tests PATCH v2 9/9] arm: pmu: Test overflow interrupts

2020-03-05 Thread Andrew Jones
On Thu, Jan 30, 2020 at 12:25:10PM +0100, Eric Auger wrote: > Test overflows for MEM_ACCESS and SW_INCR events. Also tests > overflows with 64-bit events. > > Signed-off-by: Eric Auger > > --- > > v1 -> v2: > - inline setup_irq() code > --- > arm/pmu.c | 137 +++

Re: [kvm-unit-tests PATCH v2 8/9] arm: gic: Provide per-IRQ helper functions

2020-03-05 Thread Andrew Jones
On Thu, Jan 30, 2020 at 12:25:09PM +0100, Eric Auger wrote: > From: Andre Przywara > > A common theme when accessing per-IRQ parameters in the GIC distributor > is to set fields of a certain bit width in a range of MMIO registers. > Examples are the enabled status (one bit per IRQ), the level/edg

Re: [kvm-unit-tests PATCH v2 7/9] arm: pmu: test 32-bit <-> 64-bit transitions

2020-03-05 Thread Andrew Jones
On Thu, Jan 30, 2020 at 12:25:08PM +0100, Eric Auger wrote: > Test configurations where we transit from 32b to 64b > counters and conversely. Also tests configuration where > chain counters are configured but only one counter is > enabled. > > Signed-off-by: Eric Auger > --- > arm/pmu.c

Re: [kvm-unit-tests PATCH v2 5/9] arm: pmu: Basic event counter Tests

2020-03-05 Thread Andrew Jones
On Thu, Jan 30, 2020 at 12:25:06PM +0100, Eric Auger wrote: > Adds the following tests: > - event-counter-config: test event counter configuration > - basic-event-count: > - programs counters #0 and #1 to count 2 required events > (resp. CPU_CYCLES and INST_RETIRED). Counter #0 is preset > to

Re: [kvm-unit-tests PATCH v2 6/9] arm: pmu: Test chained counter

2020-03-05 Thread Andrew Jones
On Thu, Jan 30, 2020 at 12:25:07PM +0100, Eric Auger wrote: > Add 2 tests exercising chained counters. The first one uses > CPU_CYCLES and the second one uses SW_INCR. > > Signed-off-by: Eric Auger > --- > arm/pmu.c | 128 ++ > arm/unittests.cf

Re: [kvm-unit-tests PATCH v2 5/9] arm: pmu: Basic event counter Tests

2020-03-05 Thread Andrew Jones
On Thu, Jan 30, 2020 at 12:25:06PM +0100, Eric Auger wrote: > Adds the following tests: > - event-counter-config: test event counter configuration > - basic-event-count: > - programs counters #0 and #1 to count 2 required events > (resp. CPU_CYCLES and INST_RETIRED). Counter #0 is preset > to

Re: [kvm-unit-tests PATCH v2 4/9] arm: pmu: Check Required Event Support

2020-03-05 Thread Andrew Jones
On Thu, Jan 30, 2020 at 12:25:05PM +0100, Eric Auger wrote: > If event counters are implemented check the common events > required by the PMUv3 are implemented. > > Some are unconditionally required (SW_INCR, CPU_CYCLES, > either INST_RETIRED or INST_SPEC). Some others only are > required if the i

Re: [kvm-unit-tests PATCH v2 3/9] arm: pmu: Add a pmu struct

2020-03-05 Thread Andrew Jones
On Thu, Jan 30, 2020 at 12:25:04PM +0100, Eric Auger wrote: > This struct aims at storing information potentially used by > all tests such as the pmu version, the read-only part of the > PMCR, the number of implemented event counters, ... > > Signed-off-by: Eric Auger > --- > arm/pmu.c | 30

Re: [kvm-unit-tests PATCH v2 2/9] arm: pmu: Let pmu tests take a sub-test parameter

2020-03-05 Thread Andrew Jones
On Thu, Jan 30, 2020 at 12:25:03PM +0100, Eric Auger wrote: > As we intend to introduce more PMU tests, let's add > a sub-test parameter that will allow to categorize > them. Existing tests are in the cycle-counter category. > > Signed-off-by: Eric Auger > --- > arm/pmu.c | 24 ++

Re: [PATCH v6 0/6] KASan for arm

2020-03-05 Thread Linus Walleij
Hi Florian, On Fri, Jan 17, 2020 at 8:55 PM Florian Fainelli wrote: > Let me submit and rebase v7 get the auto builders some days to see if it > exposes a new build issue and then we toss it to RMK's patch tracker and > fix bugs from there? Sorry for hammering, can we get some initial patches g