Re: [PATCH 1/2] KVM: arm64: vgic: Forbid invalid userspace Redistributor accesses

2020-11-15 Thread Marc Zyngier
Hi Zenghui, On 2020-11-13 14:28, Zenghui Yu wrote: It's expected that users will access registers in the redistributor *if* the RD has been initialized properly. Unfortunately userspace can be bogus enough to access registers before setting the RD base address, and KVM implicitly allows it (we

Re: [RFC] vfio-pci/migration: Dirty logging of the Memory BAR region?

2020-11-15 Thread Paolo Bonzini
On 15/11/20 15:31, Zenghui Yu wrote: diff --git a/softmmu/memory.c b/softmmu/memory.c index 71951fe4dc..0958db1a08 100644 --- a/softmmu/memory.c +++ b/softmmu/memory.c @@ -1806,7 +1806,10 @@ bool memory_region_is_ram_device(MemoryRegion *mr)  uint8_t memory_region_get_dirty_log_mask(MemoryRegion

[RFC] vfio-pci/migration: Dirty logging of the Memory BAR region?

2020-11-15 Thread Zenghui Yu
Hi folks, While trying the new vfio-pci migration on my arm64 server, I noticed an error at the very beginning: qemu-system-aarch64: kvm_set_user_memory_region: KVM_SET_USER_MEMORY_REGION failed, slot=5, start=0x80, size=0x10: Invalid argument The reason is that we've registered