Re: [PATCH v2] KVM: arm64: Prevent mixed-width VM creation

2021-05-25 Thread Mark Rutland
On Mon, May 24, 2021 at 06:07:52PM +0100, Marc Zyngier wrote: > It looks like we have tolerated creating mixed-width VMs since... > forever. However, that was never the intention, and we'd rather > not have to support that pointless complexity. > > Forbid such a setup by making sure all the vcpus

[kvm-unit-tests PATCH v2 3/4] arm64: enable its-migration tests for TCG

2021-05-25 Thread Alex Bennée
With the support for TCG emulated GIC we can also test these now. Signed-off-by: Alex Bennée Cc: Shashi Mallela --- arm/unittests.cfg | 2 -- 1 file changed, 2 deletions(-) diff --git a/arm/unittests.cfg b/arm/unittests.cfg index f776b66..1a39428 100644 --- a/arm/unittests.cfg +++ b/arm/unitte

[kvm-unit-tests PATCH v2 0/4] enable LPI and ITS for TCG

2021-05-25 Thread Alex Bennée
This is a companion to Shashi's series enabling LPI and ITS features for QEMU's TCG emulation. This is part of our push for a sbsa-ref platform which needs a more modern set of features. Since the last posting this is now at v3: From: Shashi Mallela Subject: [PATCH v3 0/8] GICv3 LPI and ITS f

[kvm-unit-tests PATCH v2 2/4] scripts/arch-run: don't use deprecated server/nowait options

2021-05-25 Thread Alex Bennée
The very fact that QEMU drops the deprecation warning while running is enough to confuse the its-migration test into failing. The boolean options server and wait have accepted the long form options for a long time. Signed-off-by: Alex Bennée Cc: Shashi Mallela --- scripts/arch-run.bash | 4 ++--

[kvm-unit-tests PATCH v2 4/4] arm64: split its-migrate-unmapped-collection into KVM and TCG variants

2021-05-25 Thread Alex Bennée
When running the test in TCG we are basically running on bare metal so don't rely on having a particular kernel errata applied. You might wonder why we handle this with a totally new test name instead of adjusting the append to take an extra parameter? Well the run_migration shell script uses eval

[kvm-unit-tests PATCH v2 1/4] arm64: remove invalid check from its-trigger test

2021-05-25 Thread Alex Bennée
While an IRQ is not "guaranteed to be visible until an appropriate invalidation" it doesn't stop the actual implementation delivering it earlier if it wants to. This is the case for QEMU's TCG and as tests should only be checking architectural compliance this check is invalid. Signed-off-by: Alex

[kvm-unit-tests RFC PATCH] arm64: split pmu tests into tcg/kvm variants

2021-05-25 Thread Alex Bennée
QEMU is able to give a counter for instructions retired under TCG but you need to enable -icount for it to work. Split the tests into kvm/tcg variants to support this. [AJB: I wonder if the solution is to have a totally separate unittests.cfg for TCG mode here?] Signed-off-by: Alex Bennée --- a

Re: [PATCH v2 5/5] KVM: arm64: selftests: get-reg-list: Split base and pmu registers

2021-05-25 Thread Ricardo Koller
On Wed, May 19, 2021 at 04:07:26PM +0200, Andrew Jones wrote: > Since KVM commit 11663111cd49 ("KVM: arm64: Hide PMU registers from > userspace when not available") the get-reg-list* tests have been > failing with > > ... > ... There are 74 missing registers. > The following lines are missin

Re: [PATCH v6 1/4] KVM: stats: Separate common stats from architecture specific ones

2021-05-25 Thread Jing Zhang
Hi Krish, On Tue, May 25, 2021 at 2:49 PM Krish Sadhukhan wrote: > > > On 5/24/21 8:18 AM, Jing Zhang wrote: > > Put all common statistics in a separate structure to ease > > statistics handling for the incoming new statistics API. > > > > No functional change intended. > > > > Reviewed-by: David

Re: [PATCH v2 5/5] KVM: arm64: selftests: get-reg-list: Split base and pmu registers

2021-05-25 Thread Andrew Jones
On Tue, May 25, 2021 at 01:09:22PM -0700, Ricardo Koller wrote: > On Wed, May 19, 2021 at 04:07:26PM +0200, Andrew Jones wrote: > > Since KVM commit 11663111cd49 ("KVM: arm64: Hide PMU registers from > > userspace when not available") the get-reg-list* tests have been > > failing with > > > > ..