RE: [PATCH] doc/arm: take care restore order of GICR_* in ITS restore

2021-07-22 Thread Jianyong Wu
Hi Marc, Get it! Thanks for your explanation. Thanks Jianyong > -Original Message- > From: Marc Zyngier > Sent: Thursday, July 22, 2021 4:11 PM > To: Jianyong Wu > Cc: James Morse ; Andre Przywara > ; lushenm...@huawei.com; > k...@vger.kernel.org; kvmarm@lists.cs.columbia.edu; linux-

Re: [PATCH v2 00/12] KVM: Add idempotent controls for migrating system counter state

2021-07-22 Thread Oliver Upton
On Wed, Jul 21, 2021 at 8:28 AM Andrew Jones wrote: > > On Fri, Jul 16, 2021 at 09:26:17PM +, Oliver Upton wrote: > > KVM's current means of saving/restoring system counters is plagued with > > temporal issues. At least on ARM64 and x86, we migrate the guest's > > system counter by-value

Re: [PATCH 04/16] KVM: arm64: Add MMIO checking infrastructure

2021-07-22 Thread Marc Zyngier
On Tue, 20 Jul 2021 16:49:45 +0100, Quentin Perret wrote: > > On Tuesday 20 Jul 2021 at 14:15:56 (+0100), Marc Zyngier wrote: > > On Tue, 20 Jul 2021 12:13:20 +0100, > > Quentin Perret wrote: > > > > > > On Thursday 15 Jul 2021 at 17:31:47 (+0100), Marc Zyngier wrote: > > > > +struct

Re: [RFC PATCH 4/5] iommu/arm-smmu-v3: Use pinned VMID for NESTED stage with BTM

2021-07-22 Thread Jean-Philippe Brucker
Hi Shameer, On Wed, Jul 21, 2021 at 08:54:00AM +, Shameerali Kolothum Thodi wrote: > > More generally I think this pinned VMID set conflicts with that of > > stage-2-only domains (which is the default state until a guest attaches a > > PASID table). Say you have one guest using DOMAIN_NESTED

Re: [PATCH v2 3/3] kvm/arm: Align the VMID allocation with the arm64 ASID one

2021-07-22 Thread Will Deacon
Hi Vladimir, On Thu, Jul 22, 2021 at 04:22:26PM +0100, Vladimir Murzin wrote: > On 7/22/21 10:50 AM, Will Deacon wrote: > > As an aside: I'm more and more inclined to rip out the CnP stuff given > > that it doesn't appear to being any benefits, but does have some clear > > downsides. Perhaps

Re: [PATCH 00/16] KVM: arm64: MMIO guard PV services

2021-07-22 Thread Marc Zyngier
On Thu, 22 Jul 2021 14:25:15 +0100, Andrew Jones wrote: > > On Thu, Jul 22, 2021 at 11:00:26AM +0100, Marc Zyngier wrote: > > On Wed, 21 Jul 2021 22:42:43 +0100, > > Andrew Jones wrote: > > > > > > On Thu, Jul 15, 2021 at 05:31:43PM +0100, Marc Zyngier wrote: > > > > KVM/arm64 currently

Re: [PATCH v2 3/3] kvm/arm: Align the VMID allocation with the arm64 ASID one

2021-07-22 Thread Vladimir Murzin
On 7/22/21 10:50 AM, Will Deacon wrote: > As an aside: I'm more and more inclined to rip out the CnP stuff given > that it doesn't appear to being any benefits, but does have some clear > downsides. Perhaps something for next week. Can you please clarify what do you mean by "it doesn't appear to

Re: [PATCH 00/16] KVM: arm64: MMIO guard PV services

2021-07-22 Thread Andrew Jones
On Thu, Jul 22, 2021 at 11:00:26AM +0100, Marc Zyngier wrote: > On Wed, 21 Jul 2021 22:42:43 +0100, > Andrew Jones wrote: > > > > On Thu, Jul 15, 2021 at 05:31:43PM +0100, Marc Zyngier wrote: > > > KVM/arm64 currently considers that any memory access outside of a > > > memslot is a MMIO access.

Re: [PATCH v2 3/3] kvm/arm: Align the VMID allocation with the arm64 ASID one

2021-07-22 Thread Quentin Perret
On Thursday 22 Jul 2021 at 06:45:14 (+), Shameerali Kolothum Thodi wrote: > > From: Will Deacon [mailto:w...@kernel.org] > > > diff --git a/arch/arm64/kvm/hyp/nvhe/mem_protect.c > > b/arch/arm64/kvm/hyp/nvhe/mem_protect.c > > > index 4b60c0056c04..a02c4877a055 100644 > > > ---

Re: [PATCH 00/16] KVM: arm64: MMIO guard PV services

2021-07-22 Thread Marc Zyngier
On Wed, 21 Jul 2021 22:42:43 +0100, Andrew Jones wrote: > > On Thu, Jul 15, 2021 at 05:31:43PM +0100, Marc Zyngier wrote: > > KVM/arm64 currently considers that any memory access outside of a > > memslot is a MMIO access. This so far has served us very well, but > > obviously relies on the guest

Re: [PATCH v2 3/3] kvm/arm: Align the VMID allocation with the arm64 ASID one

2021-07-22 Thread Will Deacon
On Thu, Jul 22, 2021 at 06:45:14AM +, Shameerali Kolothum Thodi wrote: > > > diff --git a/arch/arm64/kvm/hyp/nvhe/tlb.c > > b/arch/arm64/kvm/hyp/nvhe/tlb.c > > > index 83dc3b271bc5..42df9931ed9a 100644 > > > --- a/arch/arm64/kvm/hyp/nvhe/tlb.c > > > +++ b/arch/arm64/kvm/hyp/nvhe/tlb.c > > > @@

[PATCH V9 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks

2021-07-22 Thread Zhu Lingshan
From: Like Xu For "struct perf_guest_info_callbacks", the two fields "is_in_guest" and "is_user_mode" are replaced with a new multiplexed member named "state", and the "get_guest_ip" field will be renamed to "get_ip". For arm64, xen and kvm/x86, the application of DEFINE_STATIC_CALL_RET0 could

Re: [PATCH V8 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks

2021-07-22 Thread Zhu, Lingshan
On 7/21/2021 7:57 PM, Like Xu wrote: On 16/7/2021 4:53 pm, Zhu Lingshan wrote: +    } else if (xenpmu_data->pmu.r.regs.cpl & 3) oh, my typo, will fix in V9 Thanks Lingshan, serious for this version ? arch/x86/xen/pmu.c:438:9: error: expected identifier or ‘(’ before ‘return’   438 |

Re: [PATCH V8 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks

2021-07-22 Thread Zhu, Lingshan
On 7/21/2021 7:57 PM, Like Xu wrote: On 16/7/2021 4:53 pm, Zhu Lingshan wrote: +    } else if (xenpmu_data->pmu.r.regs.cpl & 3) Lingshan, serious for this version ? arch/x86/xen/pmu.c:438:9: error: expected identifier or ‘(’ before ‘return’   438 | return state;   |

Re: [PATCH] doc/arm: take care restore order of GICR_* in ITS restore

2021-07-22 Thread Marc Zyngier
On Thu, 22 Jul 2021 03:49:52 +0100, Jianyong Wu wrote: > > Hello Marc, > > > -Original Message- > > From: Marc Zyngier > > Sent: Wednesday, July 21, 2021 5:54 PM > > To: Jianyong Wu > > Cc: James Morse ; Andre Przywara > > ; lushenm...@huawei.com; > > k...@vger.kernel.org;

RE: [PATCH v2 3/3] kvm/arm: Align the VMID allocation with the arm64 ASID one

2021-07-22 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Will Deacon [mailto:w...@kernel.org] > Sent: 21 July 2021 17:32 > To: Shameerali Kolothum Thodi > Cc: linux-arm-ker...@lists.infradead.org; kvmarm@lists.cs.columbia.edu; > linux-ker...@vger.kernel.org; m...@kernel.org; catalin.mari...@arm.com; >

RE: [PATCH v2 2/3] kvm/arm: Introduce a new vmid allocator for KVM

2021-07-22 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Will Deacon [mailto:w...@kernel.org] > Sent: 21 July 2021 17:06 > To: Shameerali Kolothum Thodi > Cc: linux-arm-ker...@lists.infradead.org; kvmarm@lists.cs.columbia.edu; > linux-ker...@vger.kernel.org; m...@kernel.org; catalin.mari...@arm.com; >

RE: [PATCH v2 1/3] arch/arm64: Introduce a capability to tell whether 16-bit VMID is available

2021-07-22 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Will Deacon [mailto:w...@kernel.org] > Sent: 21 July 2021 16:23 > To: Shameerali Kolothum Thodi > Cc: linux-arm-ker...@lists.infradead.org; kvmarm@lists.cs.columbia.edu; > linux-ker...@vger.kernel.org; m...@kernel.org; catalin.mari...@arm.com; >