Re: [PATCH v6 12/64] KVM: arm64: nv: Add non-VHE-EL2->EL1 translation helpers

2022-02-02 Thread Alexandru Elisei
Hi Marc, On Fri, Jan 28, 2022 at 12:18:20PM +, Marc Zyngier wrote: > Some EL2 system registers immediately affect the current execution > of the system, so we need to use their respective EL1 counterparts. > For this we need to define a mapping between the two. In general, > this only affects

Re: [PATCH v6 09/64] KVM: arm64: nv: Support virtual EL2 exceptions

2022-02-02 Thread Alexandru Elisei
Hi, On Fri, Jan 28, 2022 at 12:18:17PM +, Marc Zyngier wrote: > From: Jintack Lim > > Support injecting exceptions and performing exception returns to and > from virtual EL2. This must be done entirely in software except when > taking an exception from vEL0 to vEL2 when the virtual HCR_EL2.

Re: [PATCH v6 06/64] KVM: arm64: nv: Add nested virt VCPU primitives for vEL2 VCPU state

2022-02-02 Thread Alexandru Elisei
Hi Marc, On Fri, Jan 28, 2022 at 12:18:14PM +, Marc Zyngier wrote: > From: Christoffer Dall > > When running a nested hypervisor we commonly have to figure out if > the VCPU mode is running in the context of a guest hypervisor or guest > guest, or just a normal guest. > > Add convenient pri

Re: [PATCH v6 04/64] KVM: arm64: nv: Allow userspace to set PSR_MODE_EL2x

2022-02-02 Thread Alexandru Elisei
Hi Marc, On Fri, Jan 28, 2022 at 12:18:12PM +, Marc Zyngier wrote: > From: Christoffer Dall > > We were not allowing userspace to set a more privileged mode for the VCPU > than EL1, but we should allow this when nested virtualization is enabled > for the VCPU. > > Reviewed-by: Russell King

Re: [PATCH v6 03/64] KVM: arm64: nv: Reset VCPU to EL2 registers if VCPU nested virt is set

2022-02-02 Thread Alexandru Elisei
Hi Marc, On Fri, Jan 28, 2022 at 12:18:11PM +, Marc Zyngier wrote: > From: Christoffer Dall > > Reset the VCPU with PSTATE.M = EL2h when the nested virtualization > feature is enabled on the VCPU. Looks good to me: Reviewed-by: Alexandru Elisei Thanks, Alex > > Reviewed-by: Russell Kin