Re: [PATCH v2 1/2] KVM: arm64: Add PMU event filtering infrastructure

Hi Marc, On 10.03.20 19:00, Marc Zyngier wrote: On 2020-03-10 17:40, Auger Eric wrote: Hi Marc, On 3/10/20 12:03 PM, Marc Zyngier wrote: Hi Eric, On 2020-03-09 18:05, Auger Eric wrote: Hi Marc, On 3/9/20 1:48 PM, Marc Zyngier wrote: It can be desirable to expose a PMU to a guest, and yet

Re: [PATCH 1/1] KVM: inject data abort if instruction cannot be decoded

On 06.09.19 15:50, Peter Maydell wrote: On Fri, 6 Sep 2019 at 14:41, Alexander Graf wrote: On 06.09.19 15:31, Peter Maydell wrote: (b) we try to reuse the code we already have that does TCG exception injection, which might or might not be a design mistake, and That's probably a design

Re: [PATCH 1/1] KVM: inject data abort if instruction cannot be decoded

On 06.09.19 15:12, Christoffer Dall wrote: On Fri, Sep 06, 2019 at 02:08:15PM +0200, Alexander Graf wrote: On 06.09.19 10:00, Christoffer Dall wrote: On Thu, Sep 05, 2019 at 02:09:18PM +0100, Marc Zyngier wrote: On 05/09/2019 10:22, Christoffer Dall wrote: On Thu, Sep 05, 2019 at 09:56

Re: [UNVERIFIED SENDER] Re: [PATCH 1/1] KVM: inject data abort if instruction cannot be decoded

On 06.09.19 14:34, Marc Zyngier wrote: On 06/09/2019 13:08, Alexander Graf wrote: On 06.09.19 10:00, Christoffer Dall wrote: On Thu, Sep 05, 2019 at 02:09:18PM +0100, Marc Zyngier wrote: [...] @@ -673,6 +694,8 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *run

Re: [PATCH 1/1] KVM: inject data abort if instruction cannot be decoded

On 06.09.19 10:00, Christoffer Dall wrote: On Thu, Sep 05, 2019 at 02:09:18PM +0100, Marc Zyngier wrote: On 05/09/2019 10:22, Christoffer Dall wrote: On Thu, Sep 05, 2019 at 09:56:44AM +0100, Peter Maydell wrote: On Thu, 5 Sep 2019 at 09:52, Marc Zyngier wrote: On Thu, 05 Sep 2019

Re: [UNVERIFIED SENDER] Re: [PATCH 0/9] arm64: Stolen time support

On 14.08.19 16:19, Marc Zyngier wrote: On Wed, 14 Aug 2019 14:02:25 +0100, Alexander Graf wrote: On 05.08.19 15:06, Steven Price wrote: On 03/08/2019 19:05, Marc Zyngier wrote: On Fri, 2 Aug 2019 15:50:08 +0100 Steven Price wrote: Hi Steven, This series add support

Re: [PATCH 0/9] arm64: Stolen time support

On 05.08.19 15:06, Steven Price wrote: On 03/08/2019 19:05, Marc Zyngier wrote: On Fri, 2 Aug 2019 15:50:08 +0100 Steven Price wrote: Hi Steven, This series add support for paravirtualized time for arm64 guests and KVM hosts following the specification in Arm's document DEN 0057A:

Re: [PATCH kvm-unit-tests v4] arm: Add PL031 test

On 25.07.19 15:25, Andrew Jones wrote: On Thu, Jul 25, 2019 at 03:09:49PM +0200, Alexander Graf wrote: This patch adds a unit test for the PL031 RTC that is used in the virt machine. It just pokes basic functionality. I've mostly written it to familiarize myself with the device, but I

[PATCH kvm-unit-tests v2] arm: Add PL031 test

-by: Alexander Graf --- v1 -> v2: - Use FDT to find base, irq and existence - Put isb after timer read - Use dist_base for gicv3 --- arm/Makefile.common | 1 + arm/pl031.c | 265 lib/arm/asm/gic.h | 1 + 3 files changed, 267 inserti

Re: [PATCH kvm-unit-tests] arm: Add PL031 test

On 10.07.19 16:25, Marc Zyngier wrote: Hi Alex, I don't know much about pl031, so my comments are pretty general... On 10/07/2019 14:27, Alexander Graf wrote: This patch adds a unit test for the PL031 RTC that is used in the virt machine. It just pokes basic functionality. I've mostly

Re: [PATCH kvm-unit-tests] arm: Add PL031 test

On 11.07.19 11:42, Andre Przywara wrote: On Thu, 11 Jul 2019 09:52:42 +0200 Paolo Bonzini wrote: Hi, On 11/07/19 07:49, Alexander Graf wrote: I agree that it would belong more in qtest, but tests in not exactly the right place is better than no tests. The problem with qtest

Re: [PATCH v3 7/9] KVM: arm/arm64: Only clean the dcache on translation fault

On 23.08.18 14:43, Marc Zyngier wrote: > On 23/08/18 13:24, Alexander Graf wrote: >> On 08/23/2018 01:16 PM, Marc Zyngier wrote: >>> On 21/08/18 17:54, Alexander Graf wrote: >>>> On 08/21/2018 05:08 PM, Marc Zyngier wrote: >>>>> On 21/08/18 15:08, Ale

Re: [PATCH v3 7/9] KVM: arm/arm64: Only clean the dcache on translation fault

On 08/23/2018 01:16 PM, Marc Zyngier wrote: On 21/08/18 17:54, Alexander Graf wrote: On 08/21/2018 05:08 PM, Marc Zyngier wrote: On 21/08/18 15:08, Alexander Graf wrote: On 08/21/2018 03:57 PM, Marc Zyngier wrote: On 21/08/18 14:35, Alexander Graf wrote: On 10/23/2017 06:11 PM, Marc Zyngier

Re: [PATCH v3 7/9] KVM: arm/arm64: Only clean the dcache on translation fault

On 08/21/2018 05:08 PM, Marc Zyngier wrote: On 21/08/18 15:08, Alexander Graf wrote: On 08/21/2018 03:57 PM, Marc Zyngier wrote: On 21/08/18 14:35, Alexander Graf wrote: On 10/23/2017 06:11 PM, Marc Zyngier wrote: The only case where we actually need to perform a dcache maintenance is when

Re: [PATCH v3 7/9] KVM: arm/arm64: Only clean the dcache on translation fault

On 08/21/2018 04:08 PM, Alexander Graf wrote: On 08/21/2018 03:57 PM, Marc Zyngier wrote: On 21/08/18 14:35, Alexander Graf wrote: On 10/23/2017 06:11 PM, Marc Zyngier wrote: The only case where we actually need to perform a dcache maintenance is when we map the page for the first time

Re: [PATCH v3 7/9] KVM: arm/arm64: Only clean the dcache on translation fault

On 08/21/2018 03:57 PM, Marc Zyngier wrote: On 21/08/18 14:35, Alexander Graf wrote: On 10/23/2017 06:11 PM, Marc Zyngier wrote: The only case where we actually need to perform a dcache maintenance is when we map the page for the first time, and subsequent permission faults do not require

Re: [PATCH v3 7/9] KVM: arm/arm64: Only clean the dcache on translation fault

On 08/21/2018 03:35 PM, Alexander Graf wrote: On 10/23/2017 06:11 PM, Marc Zyngier wrote: The only case where we actually need to perform a dcache maintenance is when we map the page for the first time, and subsequent permission faults do not require cache maintenance. Let's make it conditional

Re: [PATCH v3 7/9] KVM: arm/arm64: Only clean the dcache on translation fault

On 10/23/2017 06:11 PM, Marc Zyngier wrote: The only case where we actually need to perform a dcache maintenance is when we map the page for the first time, and subsequent permission faults do not require cache maintenance. Let's make it conditional on not being a permission fault (and thus a

Re: [PATCH v2] KVM: arm/arm64: Handle hva aging while destroying the vm

On 05.07.17 10:57, Suzuki K Poulose wrote: Hi Alex, On Wed, Jul 05, 2017 at 08:20:31AM +0200, Alexander Graf wrote: The kvm_age_hva callback may be called all the way concurrently while kvm_mmu_notifier_release() is running. The release function sets kvm->arch.pgd = NULL which the ag

[PATCH v2] KVM: arm/arm64: Handle hva aging while destroying the vm

nce a NULL pgd pointer. This patch adds a check for that case, so that we leave the aging function silently. Cc: sta...@vger.kernel.org Fixes: 293f29363 ("kvm-arm: Unmap shadow pagetables properly") Signed-off-by: Alexander Graf <ag...@suse.de> --- v1 -> v2: - Fix commit

Re: [PATCH] KVM: arm/arm64: Handle hva aging while destroying the vm

On 07/03/2017 10:03 AM, Christoffer Dall wrote: Hi Alex, On Fri, Jun 23, 2017 at 05:21:59PM +0200, Alexander Graf wrote: If we want to age an HVA while the VM is getting destroyed, we have a tiny race window during which we may end up dereferencing an invalid kvm->arch.pgd value. C

[PATCH] KVM: arm/arm64: Handle hva aging while destroying the vm

ase() kvm_arch_flush_shadow_all() kvm_free_stage2_pgd() stage2_get_pmd() set kvm->arch.pgd = 0 stage2_get_pud() arch.pgd> This patch adds a check for that case. Signed-off-by: Alexander Graf <a

Re: [PATCH v2 00/25] arm64: KVM: Mediate access to GICv3 sysregs at EL2

assume it's a different issue for now. Tested-by: Alexander Graf <ag...@suse.de> Alex ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v3] kvm: arm/arm64: Fix locking for kvm_free_stage2_pgd

On 04.04.17 12:35, Suzuki K Poulose wrote: Hi Christoffer, On 04/04/17 11:13, Christoffer Dall wrote: Hi Suzuki, On Mon, Apr 03, 2017 at 03:12:43PM +0100, Suzuki K Poulose wrote: In kvm_free_stage2_pgd() we don't hold the kvm->mmu_lock while calling unmap_stage2_range() on the entire

Re: [PATCH v3 0/5] Support userspace irqchip with arch timers

On 05.04.17 11:28, Christoffer Dall wrote: This series is the second version of the rework of the patches to support architected timers with a userspace irqchip sent by Alexander Graf [1]. We first cleanup some of the timer code to make it easier to understand what is being done in the later

Re: [PATCH v3 3/5] KVM: arm/arm64: Support arch timers with a userspace gic

On 06.04.17 10:25, Marc Zyngier wrote: On 06/04/17 09:16, Alexander Graf wrote: On 05.04.17 11:28, Christoffer Dall wrote: From: Alexander Graf <ag...@suse.de> @@ -559,6 +628,13 @@ int kvm_timer_enable(struct kvm_vcpu *vcpu) if (timer->enabled)

Re: [PATCH v3 3/5] KVM: arm/arm64: Support arch timers with a userspace gic

On 05.04.17 11:28, Christoffer Dall wrote: From: Alexander Graf <ag...@suse.de> If you're running with a userspace gic or other interrupt constroller (that is no vgic in the kernel), then you have so far not been able to use the architected timers, because the output of the architected

Re: [PATCH v2 2/5] KVM: arm/arm64: Add ARM user space interrupt signaling ABI

ernel, which may result in interrupt line state changes, so we lose out on for example timer and PMU events if we run with user space gic emulation. Define an ABI to publish such device output levels to userspace. Signed-off-by: Alexander Graf <ag...@suse.de> Signed-off-by: Christoffer D

Re: [PATCH] arm: Add simple arch timer test

On 16/11/2016 16:54, Andrew Jones wrote: On Mon, Sep 19, 2016 at 04:52:01PM +0200, Andrew Jones wrote: On Mon, Sep 19, 2016 at 01:44:40PM +0200, Alexander Graf wrote: All virtualization capable ARM cores support the ARM architected virtual timer. This patch adds minimalistic checks whether

Re: [RFC 1/2] linux-headers: update

On 01/11/2016 11:19, Peter Maydell wrote: On 29 October 2016 at 22:10, Alexander Graf <ag...@suse.de> wrote: This patch updates the Linux headers to include the in-progress user space ARM timer patches. It is explicitly RFC, as the patches are not merged yet. --- Is there a cover

[RFC 1/2] linux-headers: update

This patch updates the Linux headers to include the in-progress user space ARM timer patches. It is explicitly RFC, as the patches are not merged yet. --- linux-headers/asm-arm/kvm.h | 1 + linux-headers/asm-arm64/kvm.h | 1 + linux-headers/linux/kvm.h | 6 ++ 3 files changed, 8

[RFC 2/2] ARM: KVM: Enable in-kernel timers with user space gic

emulation, we miss out on timer events which are only available from kernel space. This patch leverages the new kernel/user space pending line synchronization for those timer events. Signed-off-by: Alexander Graf <ag...@suse.de> --- hw/arm/virt.c| 10 ++ target-arm/cpu.h | 3 +++

Re: [PATCH 0/3] Support userspace irqchip with arch timers

> On 29 Oct 2016, at 15:19, Paolo Bonzini wrote: > > What the status of userspace for this thing? Are QEMU patches being > posted and reviewed? I didn't see a notification that the patches were merged. Are they in Linus' tree yet? Then I can post

Re: [PATCH 0/3] Support userspace irqchip with arch timers

> Am 28.10.2016 um 17:57 schrieb Marc Zyngier <marc.zyng...@arm.com>: > >> On 28/10/16 16:52, Alexander Graf wrote: >> >> >>> Am 28.10.2016 um 16:38 schrieb Marc Zyngier <marc.zyng...@arm.com>: >>> >>> Alex, >>> >>

Re: [PATCH 0/3] Support userspace irqchip with arch timers

> Am 28.10.2016 um 16:38 schrieb Marc Zyngier <marc.zyng...@arm.com>: > > Alex, > >> On 30/09/16 20:31, Alexander Graf wrote: >> >> >>> On 30.09.16 17:43, Christoffer Dall wrote: >>>> On Fri, Sep 30, 2016 at 05:38:11PM +0200,

Re: development guide for installing KVMARM kernel

On 10.10.16 15:50, Marc Zyngier wrote: > On 2016-10-06 19:54, Eugene Bagdasaryan wrote: >> Hey Marc >> >> I basically want to try and install OpenStack on RPi, which I guess >> is possible. > > Sounds pretty ambitious, but I guess someone has to try... > >> (1) For the 64-bit arm OS, what

Re: [PATCH 0/3] Support userspace irqchip with arch timers

On 30.09.16 17:43, Christoffer Dall wrote: > On Fri, Sep 30, 2016 at 05:38:11PM +0200, Alexander Graf wrote: >> >> >> On 30.09.16 16:54, Alexander Graf wrote: >>> >>> >>> On 27.09.16 21:08, Christoffer Dall wrote: >>>> Hi Alex, >>

Re: [PATCH 0/3] Support userspace irqchip with arch timers

On 30.09.16 17:43, Christoffer Dall wrote: > On Fri, Sep 30, 2016 at 05:38:11PM +0200, Alexander Graf wrote: >> >> >> On 30.09.16 16:54, Alexander Graf wrote: >>> >>> >>> On 27.09.16 21:08, Christoffer Dall wrote: >>>> Hi Alex, >>

[PATCH v7] KVM: arm/arm64: Route vtimer events to user space

successfully run edk2 and Linux with user space gic emulation. Signed-off-by: Alexander Graf <ag...@suse.de> --- v1 -> v2: - Add back curly brace that got lost v2 -> v3: - Split into patch set v3 -> v4: - Improve documentation v4 -> v5: - Rewrite to use pending state s

Re: [PATCH v4 2/2] KVM: arm/arm64: Route vtimer events to user space

On 20.09.16 11:21, Marc Zyngier wrote: > On 19/09/16 18:39, Alexander Graf wrote: >> >> >> On 19.09.16 16:48, Marc Zyngier wrote: >>> On 19/09/16 12:14, Alexander Graf wrote: >>>> We have 2 modes for dealing with interrupts in the ARM world. We can

Re: [PATCH v4 2/2] KVM: arm/arm64: Route vtimer events to user space

On 19.09.16 16:48, Marc Zyngier wrote: > On 19/09/16 12:14, Alexander Graf wrote: >> We have 2 modes for dealing with interrupts in the ARM world. We can either >> handle them all using hardware acceleration through the vgic or we can >> emulate >> a gic in user s

[PATCH v4 2/2] KVM: arm/arm64: Route vtimer events to user space

-off-by: Alexander Graf <ag...@suse.de> --- v1 -> v2: - Add back curly brace that got lost v2 -> v3: - Split into patch set v3 -> v4: - Improve documentation --- Documentation/virtual/kvm/api.txt | 30 - arch/arm/include/asm/kvm_host.h | 3 + arc

[PATCH v4 0/2] KVM: ARM: Enable vtimers with user space gic

t;only only" in documentation - Split patches - Remove kvm_emulate.h include v3 -> v4: - Improve documentation Alexander Graf (2): KVM: arm/arm64: Add vcpu ENABLE_CAP functionality KVM: arm/arm64: Route vtimer events to user space Documentation/virtual/kvm/api.txt | 34 ++- a

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

On 16.09.16 15:30, Christoffer Dall wrote: > On Fri, Sep 16, 2016 at 02:31:42PM +0200, Paolo Bonzini wrote: >> >> >> On 16/09/2016 14:30, Christoffer Dall wrote: >> This patch set allows user space to receive vtimer events as well as mask >> them, so that we can handle all vtimer related

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

> Am 16.09.2016 um 15:46 schrieb Andrew Jones : > >> On Fri, Sep 16, 2016 at 03:30:27PM +0200, Christoffer Dall wrote: >>> On Fri, Sep 16, 2016 at 02:31:42PM +0200, Paolo Bonzini wrote: >>> >>> >>> On 16/09/2016 14:30, Christoffer Dall wrote: >>> This patch set allows

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

> On 16 Sep 2016, at 14:29, Christoffer Dall <christoffer.d...@linaro.org> > wrote: > > On Fri, Sep 16, 2016 at 02:25:01PM +0200, Alexander Graf wrote: >> >>> On 16 Sep 2016, at 12:20, Marc Zyngier <marc.zyng...@arm.com> wrote: >>> >>>

Re: [PATCH v2] KVM: arm/arm64: Route vtimer events to user space

> On 16 Sep 2016, at 11:44, Christoffer Dall <christoffer.d...@linaro.org> > wrote: > > Alex, > > On Fri, Sep 16, 2016 at 07:09:13AM +0200, Alexander Graf wrote: >> We have 2 modes for dealing with interrupts in the ARM world. We can either >> handle

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

> On 16 Sep 2016, at 12:20, Marc Zyngier <marc.zyng...@arm.com> wrote: > > Hi Alex, > > On 16/09/16 07:26, Alexander Graf wrote: >> Some systems out there (well, one type in particular - the Raspberry Pi >> series) >> do have virtualization capabilitie

[PATCH v3 2/2] KVM: arm/arm64: Route vtimer events to user space

-off-by: Alexander Graf <ag...@suse.de> --- v1 -> v2: - Add back curly brace that got lost v2 -> v3: - Split into patch set --- Documentation/virtual/kvm/api.txt | 24 +++- arch/arm/include/asm/kvm_host.h | 3 + arch/arm/kvm/arm.c| 22 --- arch/a

[PATCH v3 1/2] KVM: arm/arm64: Add vcpu ENABLE_CAP functionality

In a follow-up patch we will need to enable capabilities on demand for backwards compatibility. This patch adds the generic framework to handle vcpu cap enablement to the arm code base. Signed-off-by: Alexander Graf <ag...@suse.de> --- Documentation/virtual/kvm/api.txt | 4 +++- arch/a

[PATCH] KVM: arm/arm64: timer: Fix hw sync for user space irqchip path

[ 74.941406] [] kvm_arch_vcpu_ioctl_run+0xfc/0x630 [ 74.947766] [] kvm_vcpu_ioctl+0x2f4/0x710 [ 74.953420] [] do_vfs_ioctl+0xb0/0x728 [ 74.958807] [] SyS_ioctl+0x94/0xa8 [ 74.963844] [] el0_svc_naked+0x38/0x3c Fixes: 0919e84c0 Cc: sta...@vger.kernel.org Signed-off-by: Alexander Graf <

[PATCH] KVM: arm/arm64: Route vtimer events to user space

. Signed-off-by: Alexander Graf <ag...@suse.de> --- A branch with WIP QEMU code can be found here: https://github.com/agraf/qemu.git no-kvm-irqchip --- Documentation/virtual/kvm/api.txt | 28 - arch/arm/include/asm/kvm_host.h | 3 + arch/arm/kvm/arm.c

Re: issues with emulated PCI MMIO backed by host memory under KVM

On 06/28/2016 12:55 PM, Laszlo Ersek wrote: On 06/27/16 12:34, Christoffer Dall wrote: On Mon, Jun 27, 2016 at 11:47:18AM +0200, Ard Biesheuvel wrote: So first of all, let me reiterate that I could only find a single instance in QEMU where a PCI MMIO region is backed by host memory, which is

Re: issues with emulated PCI MMIO backed by host memory under KVM

> Am 27.06.2016 um 15:57 schrieb Ard Biesheuvel : > >> On 27 June 2016 at 15:35, Christoffer Dall >> wrote: >>> On Mon, Jun 27, 2016 at 02:30:46PM +0200, Ard Biesheuvel wrote: On 27 June 2016 at 12:34, Christoffer Dall

Re: issues with emulated PCI MMIO backed by host memory under KVM

> Am 27.06.2016 um 12:34 schrieb Christoffer Dall : > >> On Mon, Jun 27, 2016 at 11:47:18AM +0200, Ard Biesheuvel wrote: >>> On 27 June 2016 at 11:16, Christoffer Dall >>> wrote: >>> Hi, >>> >>> I'm going to ask some stupid questions

Re: issues with emulated PCI MMIO backed by host memory under KVM

> Am 24.06.2016 um 16:04 schrieb Ard Biesheuvel : > > Hi all, > > This old subject came up again in a discussion related to PCIe support > for QEMU/KVM under Tianocore. The fact that we need to map PCI MMIO > regions as cacheable is preventing us from reusing a

Re: issues with emulated PCI MMIO backed by host memory under KVM

> Am 24.06.2016 um 20:16 schrieb Ard Biesheuvel : > >> On 24 June 2016 at 16:04, Ard Biesheuvel wrote: >> [...] >> Note that this issue not only affects framebuffers on PCI cards, it >> also affects emulated USB host controllers (perhaps

Re: [PATCH v5 1/2] arm/arm64: KVM: Detect vGIC presence at runtime

On 22.04.16 00:04, Peter Maydell wrote: > On 21 April 2016 at 22:41, Alexander Graf <ag...@suse.de> wrote: >> So effectively all we'd need is to set CNTHCTL_EL2.EL1PCEN to 0 for >> guests that have no in-kernel irqchip, no? We should then trap on all >> timer accesses

Re: [PATCH] KVM: arm/arm64: Handle forward time correction gracefully

nd restart the timer for the remaining time when the condition is detected. This patch implements the latter, with a bit of refactoring in order to avoid too much code duplication. Reported-by: Alexander Graf <ag...@suse.de> Signed-off-by: Marc Zyngier <marc.zyng...@arm.com> Oh - before I forget. T

Re: [PATCH] KVM: arm/arm64: Handle forward time correction gracefully

nd restart the timer for the remaining time when the condition is detected. This patch implements the latter, with a bit of refactoring in order to avoid too much code duplication. Reported-by: Alexander Graf <ag...@suse.de> Signed-off-by: Marc Zyngier <marc.zyng...@arm.com> Looks good, I can

Re: the arm cache coherency cluster v2

On 18.03.15 20:18, Andrew Jones wrote: On Wed, Mar 18, 2015 at 03:08:20PM -0400, Andrew Jones wrote: In reply to this message I'll send two series' one for KVM and one for QEMU. The two series' are their respective component complements, and attempt to implement cache coherency for arm