Re: [PATCH v6 1/6] ARM: Add TTBR operator for kasan_init

2019-07-14 Thread Liuwenliang (Abbott Liu)
Hi Florian and Linus Walleij! Thanks Florian for picking these patches up. Thanks Linus Walleij for review these patches. Yes, This patch is refactoring patch. But we need use set_ttbr0/get_ttbr0 (in 0005-Initialize-the-mapping-of-KASan-shadow-memory.patch) which is define in This patch. So if

Re: [PATCH v3 2/6] Disable instrumentation for some code

2018-04-07 Thread Liuwenliang (Abbott Liu)
On Tue, Apr 03, 2018 at 19:39, Russell King - ARM Linux: >On Tue, Apr 03, 2018 at 12:30:42PM +0100, Marc Zyngier wrote: >> On 02/04/18 13:04, Abbott Liu wrote: >> > From: Andrey Ryabinin >> > >> > Disable instrumentation for arch/arm/boot/compressed/* >> > ,arch/arm/kvm/hyp/* and arch/arm/vdso/*

Re: [PATCH v2 0/7] KASan for arm

2018-03-26 Thread Liuwenliang (Abbott Liu)
On 26 March 2018 at 7:59, Joel Stanley wrote: >On 18 March 2018 at 23:23, Abbott Liu wrote: > >>These patches add arch specific code for kernel address sanitizer >> (see Documentation/kasan.txt). > >Thanks for implementing this. I gave the series a spin on an ASPEED >ast2500 (ARMv5) system

Re: [PATCH 7/7] Enable KASan for arm

2018-03-24 Thread Liuwenliang (Abbott Liu)
On 03/20/2018 2:30 AM, kbuild test robot wrote: >All errors (new ones prefixed by >>): > > arch/arm/kernel/entry-common.S: Assembler messages: >>> arch/arm/kernel/entry-common.S:85: Error: invalid constant >>> (b6e0) after fixup I'm sorry! We need to add the fellowing code to solve

Re: [PATCH v2 0/7] KASan for arm

2018-03-24 Thread Liuwenliang (Abbott Liu)
On 03/20/2018 2:30 AM, Abbott Liu wrote: >BTW, it looks like you have some section mismatches: > >WARNING: vmlinux.o(.meminit.text+0x40): Section mismatch in reference >from the function kasan_pte_populate() to the function >.init.text:kasan_alloc_block.constprop.5() >The function __meminit kasan_p

Re: [PATCH v2 0/7] KASan for arm

2018-03-24 Thread Liuwenliang (Abbott Liu)
On Mon, Mar 19, 2018 at 16:44 , Dmitry Vyukov wrote: >Hi Abbott, > >I've skimmed through the changes and they generally look good to me. I >am not an expect in arm, so I did not look too closely on these parts >(which is actually most of the changes). > >FWIW >Acked-by: Dmitry Vyukov > >Please als

Re: [PATCH 3/7] Disable instrumentation for some code

2018-03-24 Thread Liuwenliang (Abbott Liu)
On 19/03/2018 16:38, Marc Zyngier wrote: >You need to extend this at least to arch/arm/kvm/hyp/Makefile, as the >KASAN shadow region won't be mapped in HYP. See commit a6cdf1c08cbfe for >more details (all the arm64 comments in this patch apply to 32bit as well). Thanks for your review. I will disab

Re: [PATCH v2 0/7] KASan for arm

2018-03-19 Thread Liuwenliang (Abbott Liu)
On 03/19/2018 09:23 AM, Florian Fainelli wrote: >On 03/18/2018 06:20 PM, Liuwenliang (Abbott Liu) wrote: >> On 03/19/2018 03:14 AM, Florian Fainelli wrote: >>> Thanks for posting these patches! Just FWIW, you cannot quite add >>> someone's Tested-by for a patch

Re: [PATCH v2 0/7] KASan for arm

2018-03-19 Thread Liuwenliang (Abbott Liu)
On 03/19/2018 03:14 AM, Florian Fainelli wrote: >Thanks for posting these patches! Just FWIW, you cannot quite add >someone's Tested-by for a patch series that was just resubmitted given >the differences with v1. I just gave it a spin on a Cortex-A5 (no LPAE) >and it looks like test_kasan.ko is pas

Re: [PATCH 1/7] 2 1-byte checks more safer for memory_is_poisoned_16

2018-03-19 Thread Liuwenliang (Abbott Liu)
On Sun, Mar 18, 2018 at 21:21:20PM +0800, Russell King wrote: >On Sun, Mar 18, 2018 at 08:53:36PM +0800, Abbott Liu wrote: >> Because in some architecture(eg. arm) instruction set, non-aligned >> access support is not very well, so 2 1-byte checks is more >> safer than 1 2-byte check. The impact on