Re: [PATCH v5 08/14] KVM: arm64: Protect stage-2 traversal with RCU

On Mon, Nov 14, 2022, Oliver Upton wrote: > Hi Marek, > > On Mon, Nov 14, 2022 at 03:29:14PM +0100, Marek Szyprowski wrote: > > This patch landed in today's linux-next (20221114) as commit > > c3119ae45dfb ("KVM: arm64: Protect stage-2 traversal with RCU"). > > Unfortunately it introduces a

Re: [PATCH] KVM: arm64: Cleanup the __get_fault_info() to take out the code that validates HPFAR

> > Honestly, I'd refrain from such changes *unless* they enable something > else. The current code is well understood by people hacking on it, and > although I don't mind revamping it, it has to be for a good reason. > > I'd be much more receptive to such a change if it was a prefix to >

Re: [PATCH] KVM: arm64: Cleanup the __get_fault_info() to take out the code that validates HPFAR

> > +static inline bool __hpfar_is_valid(u64 esr) > > Unlike what the name implies, this function returns true for some > cases that HPFAR is not valid (i.e. SEA). I think the function > returns true when KVM doesn't need HPFAR, or when HPFAR is valid. > IMHO the name might be a bit misleading,

[PATCH] KVM: arm64: Cleanup the __get_fault_info() to take out the code that validates HPFAR

. No functional changes are intended. Suggested-by: Oliver Upton Signed-off-by: Mingwei Zhang --- arch/arm64/kvm/hyp/include/hyp/fault.h | 36 -- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/arch/arm64/kvm/hyp/include/hyp/fault.h b/arch/arm64/kvm/hyp