Re: [PATCH] arm64: KVM: Use SMCCC_ARCH_WORKAROUND_1 for Falkor BP hardening

2018-03-05 Thread Timur Tabi
On Fri, Mar 2, 2018 at 3:50 PM, Shanker Donthineni wrote: > diff --git a/arch/arm64/include/asm/cpucaps.h > b/arch/arm64/include/asm/cpucaps.h > index bb26382..6ecc249 100644 > --- a/arch/arm64/include/asm/cpucaps.h > +++ b/arch/arm64/include/asm/cpucaps.h > @@ -43,7 +43,7 @@ > #define ARM64_SVE

Re: [PATCH v3 2/2] arm64: Add software workaround for Falkor erratum 1041

2017-11-15 Thread Timur Tabi
On Tue, Nov 14, 2017 at 7:05 PM, Stephen Boyd wrote: > This also applies to Kryo CPUs. I have a patch[1] for the 1003 > Falkor errata that adds the Kryo MIDR check which can also be > used for this errata. > > [1] https://patchwork.kernel.org/patch/10048987/ Please submit a follow-up patch for E

Re: [PATCH v4 2/4] arm64: Work around Falkor erratum 1003

2017-01-27 Thread Timur Tabi
On 01/25/2017 09:52 AM, Christopher Covington wrote: + .desc = "Qualcomm Falkor erratum 1003", FYI, this needs to say, "Qualcomm Technologies Falkor ...". Same thing with the 1009 patch. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.

Re: [PATCH v3 2/5] arm64: Work around Falkor erratum 1003

2017-01-11 Thread Timur Tabi
On 01/11/2017 12:37 PM, Mark Rutland wrote: The name, as it is, is perfectly descriptive. Let's not sacrifice legibility over a non-issue. I don't want to kick a dead horse or anything, but changing it to QCOM_FLKR_ERRATUM_1003 would eliminate all the spacing problems without sacrificing any

Re: [PATCH v3 2/5] arm64: Work around Falkor erratum 1003

2017-01-11 Thread Timur Tabi
On 01/11/2017 12:33 PM, Mark Rutland wrote: It'll need to affect all lines since the kconfig column needs to expand by at least one character to fit QCOM_FALKOR_ERRATUM_1003. Or we can make the macro shorter. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, I

Re: [PATCH v2 2/5] arm64: Work around Falkor erratum 1003

2017-01-06 Thread Timur Tabi
Christopher Covington wrote: > Also, since this can't be changed via the menu, why bother putting it in? I put it in in response to review comments asking for the magic number to be clarified by a #define or variable. I could not find a suitably shared header between the files in question, so I

Re: [PATCH v2 2/5] arm64: Work around Falkor erratum 1003

2017-01-06 Thread Timur Tabi
Christopher Covington wrote: > Looks like you've made an unrelated whitespace change that affected the entire table, > not just the line you're adding. I'm making space for "QCOM_FALKOR_ERRATUM_1003". Ok, but you're also shrinking the other columns. I think a better solution is to make the

Re: [PATCH v2 2/5] arm64: Work around Falkor erratum 1003

2016-12-29 Thread Timur Tabi
On 12/29/2016 04:43 PM, Christopher Covington wrote: +config QCOM_FALKOR_E1003_RESERVED_ASID + int + default 1 + depends on QCOM_FALKOR_ERRATUM_1003 Also, since this can't be changed via the menu, why bother putting it in? -- Qualcomm Datacenter Technologies, Inc. as an affil

Re: [PATCH v2 2/5] arm64: Work around Falkor erratum 1003

2016-12-29 Thread Timur Tabi
On 12/29/2016 04:43 PM, Christopher Covington wrote: -| Implementor| Component | Erratum ID | Kconfig | -++-+-+-+ -| ARM| Cortex-A53 | #826319 | ARM64_ERRATUM_826319

Re: [PATCH] arm64/kvm: Add generic v8 KVM target

2015-06-19 Thread Timur Tabi
On 06/17/2015 04:00 AM, Suzuki K. Poulose wrote: &genericv8_target_table); kvm_register_target_sys_reg_table(KVM_ARM_TARGET_XGENE_POTENZA, &genericv8_target_table); + kvm_register_target_sys_reg_tabl