Re: [PATCH] arm64: Don't report clear pmds and puds as huge

2015-07-01 Thread Steve Capper
On 1 July 2015 at 14:28, Catalin Marinas wrote: > On Wed, Jul 01, 2015 at 02:18:31PM +0100, Catalin Marinas wrote: >> On Wed, Jul 01, 2015 at 02:08:31PM +0200, Christoffer Dall wrote: >> > diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c >> > index 2de9d2e..0eeb4f09 100644 >>

Re: [PATCH] arm64: Don't report clear pmds and puds as huge

2015-07-01 Thread Catalin Marinas
On Wed, Jul 01, 2015 at 02:18:31PM +0100, Catalin Marinas wrote: > On Wed, Jul 01, 2015 at 02:08:31PM +0200, Christoffer Dall wrote: > > diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c > > index 2de9d2e..0eeb4f09 100644 > > --- a/arch/arm64/mm/hugetlbpage.c > > +++ b/arch/arm

Re: [PATCH] arm64: Don't report clear pmds and puds as huge

2015-07-01 Thread Catalin Marinas
On Wed, Jul 01, 2015 at 02:08:31PM +0200, Christoffer Dall wrote: > The current pmd_huge() and pud_huge() functions simply check if the table > bit is not set and reports the entries as huge in that case. This is > counter-intuitive as a clear pmd/pud cannot also be a huge pmd/pud, and > it is inc

Re: [PATCH] arm64: Don't report clear pmds and puds as huge

2015-07-01 Thread Marc Zyngier
On 01/07/15 13:08, Christoffer Dall wrote: > The current pmd_huge() and pud_huge() functions simply check if the table > bit is not set and reports the entries as huge in that case. This is > counter-intuitive as a clear pmd/pud cannot also be a huge pmd/pud, and > it is inconsistent with at least

Re: [PATCH] arm64: Don't report clear pmds and puds as huge

2015-07-01 Thread Christoffer Dall
On Wed, Jul 01, 2015 at 01:24:34PM +0100, Steve Capper wrote: > On 1 July 2015 at 13:08, Christoffer Dall wrote: > > The current pmd_huge() and pud_huge() functions simply check if the table > > bit is not set and reports the entries as huge in that case. This is > > counter-intuitive as a clear

Re: [PATCH] arm64: Don't report clear pmds and puds as huge

2015-07-01 Thread Steve Capper
On 1 July 2015 at 13:08, Christoffer Dall wrote: > The current pmd_huge() and pud_huge() functions simply check if the table > bit is not set and reports the entries as huge in that case. This is > counter-intuitive as a clear pmd/pud cannot also be a huge pmd/pud, and > it is inconsistent with a

[PATCH] arm64: Don't report clear pmds and puds as huge

2015-07-01 Thread Christoffer Dall
The current pmd_huge() and pud_huge() functions simply check if the table bit is not set and reports the entries as huge in that case. This is counter-intuitive as a clear pmd/pud cannot also be a huge pmd/pud, and it is inconsistent with at least arm and x86. To prevent others from making the sa