Re: [PATCH] arm64: KVM: Enable support for Cortex-A72

2016-08-24 Thread Peter Maydell
On 24 August 2016 at 11:19, Suzuki K Poulose wrote: > On 24/08/16 10:23, Shannon Zhao wrote: >> Yes, this works for qemu with "-cpu host". But if it specifies the cpu >> type with "-cpu cortex-a72". It will fail without this patch. > > > Thats because you specify the expected target from the kerne

Re: [PATCH] arm64: KVM: Enable support for Cortex-A72

2016-08-24 Thread Suzuki K Poulose
On 24/08/16 10:23, Shannon Zhao wrote: On 2016/8/24 16:57, Suzuki K Poulose wrote: On 24/08/16 08:21, Shannon Zhao wrote: In order to allow KVM to run on Cortex-A72 physical cpus, enable KVM support for Cortex-A72. Do we really need this change ? Given that A72 is using the generic_v8 table

Re: [PATCH] arm64: KVM: Enable support for Cortex-A72

2016-08-24 Thread Shannon Zhao
On 2016/8/24 16:57, Suzuki K Poulose wrote: > On 24/08/16 08:21, Shannon Zhao wrote: >> In order to allow KVM to run on Cortex-A72 physical cpus, enable KVM >> support for Cortex-A72. > > Do we really need this change ? Given that A72 is using the generic_v8 > table, > it will automatically be s

Re: [PATCH] arm64: KVM: Enable support for Cortex-A72

2016-08-24 Thread Marc Zyngier
On Wed, 24 Aug 2016 15:21:37 +0800 Shannon Zhao wrote: Hi Shannon, > In order to allow KVM to run on Cortex-A72 physical cpus, enable KVM > support for Cortex-A72. > > Signed-off-by: Shannon Zhao Why do we need any of this? Since bca556ac468a ("arm64/kvm: Add generic v8 KVM target"), we supp

Re: [PATCH] arm64: KVM: Enable support for Cortex-A72

2016-08-24 Thread Suzuki K Poulose
On 24/08/16 08:21, Shannon Zhao wrote: In order to allow KVM to run on Cortex-A72 physical cpus, enable KVM support for Cortex-A72. Do we really need this change ? Given that A72 is using the generic_v8 table, it will automatically be supported via the GENERIC_V8 target. That was added just for

[PATCH] arm64: KVM: Enable support for Cortex-A72

2016-08-24 Thread Shannon Zhao
In order to allow KVM to run on Cortex-A72 physical cpus, enable KVM support for Cortex-A72. Signed-off-by: Shannon Zhao --- arch/arm64/include/asm/cputype.h | 1 + arch/arm64/include/uapi/asm/kvm.h| 3 ++- arch/arm64/kvm/guest.c | 2 ++ arch/arm64/kvm/sys_regs_generic_v8.c