Re: [PATCH] arm64: KVM: set right LR register value for 32 bit guest when inject abort

2017-10-17 Thread gengdongjiu
Hi Christoffer On 2017/10/17 3:59, Christoffer Dall wrote: > On Mon, Oct 16, 2017 at 04:10:01PM +, gengdongjiu wrote: >> Hi Marc, >> >>> >>> Please also update the 32bit code accordingly, as it looks broken too. >> >> I have updated the 32 bit code according, in my hand, there is no arm32 host

Re: [PATCH] arm64: KVM: set right LR register value for 32 bit guest when inject abort

2017-10-16 Thread Christoffer Dall
On Mon, Oct 16, 2017 at 04:10:01PM +, gengdongjiu wrote: > Hi Marc, > > > > > Please also update the 32bit code accordingly, as it looks broken too. > > I have updated the 32 bit code according, in my hand, there is no arm32 host > environment, > So there is no method to verify it in the ar

Re: [PATCH] arm64: KVM: set right LR register value for 32 bit guest when inject abort

2017-10-16 Thread gengdongjiu
Hi Marc, > > Please also update the 32bit code accordingly, as it looks broken too. I have updated the 32 bit code according, in my hand, there is no arm32 host environment, So there is no method to verify it in the arm32 host, only verify the patch in the arm64 host. Anyway I firstly send th

Re: [PATCH] arm64: KVM: set right LR register value for 32 bit guest when inject abort

2017-10-14 Thread gengdongjiu
Hi Marc, On 2017/10/13 23:12, Marc Zyngier wrote: > On 13/10/17 15:29, gengdongjiu wrote: >> Hi Marc, >> Thank you very much for your time to review it. >> >>> On 12/10/17 17:44, Dongjiu Geng wrote: When a exception is trapped to EL2, hardware uses ELR_ELx to hold the current fault

Re: [PATCH] arm64: KVM: set right LR register value for 32 bit guest when inject abort

2017-10-13 Thread Marc Zyngier
On 13/10/17 15:29, gengdongjiu wrote: > Hi Marc, > Thank you very much for your time to review it. > >> On 12/10/17 17:44, Dongjiu Geng wrote: >>> When a exception is trapped to EL2, hardware uses ELR_ELx to hold the >>> current fault instruction address. If KVM wants to inject a abort to >>>

Re: [PATCH] arm64: KVM: set right LR register value for 32 bit guest when inject abort

2017-10-13 Thread gengdongjiu
Hi Marc, Thank you very much for your time to review it. > On 12/10/17 17:44, Dongjiu Geng wrote: > > When a exception is trapped to EL2, hardware uses ELR_ELx to hold the > > current fault instruction address. If KVM wants to inject a abort to > > 32 bit guest, it needs to set the LR registe

Re: [PATCH] arm64: KVM: set right LR register value for 32 bit guest when inject abort

2017-10-13 Thread Marc Zyngier
On 12/10/17 17:44, Dongjiu Geng wrote: > When a exception is trapped to EL2, hardware uses ELR_ELx to hold > the current fault instruction address. If KVM wants to inject a > abort to 32 bit guest, it needs to set the LR register for the > guest to emulate this abort happened in the guest. Becaus

[PATCH] arm64: KVM: set right LR register value for 32 bit guest when inject abort

2017-10-12 Thread Dongjiu Geng
When a exception is trapped to EL2, hardware uses ELR_ELx to hold the current fault instruction address. If KVM wants to inject a abort to 32 bit guest, it needs to set the LR register for the guest to emulate this abort happened in the guest. Because ARM32 architecture is Multi-pipeline, so the