Re: [PATCH] selftests: KVM: Call ucall_init when setting up in rseq_test

2021-09-28 Thread Sean Christopherson
On Tue, Sep 28, 2021, Andrew Jones wrote: > On Mon, Sep 27, 2021 at 08:05:14PM +, Sean Christopherson wrote: > > My vote would be to rework arm64's ucall_init() as a prep patch and drop > > the param > > in the process. There are zero tests that provide a non-NULL value, but > > that's > >

Re: [PATCH] selftests: KVM: Call ucall_init when setting up in rseq_test

2021-09-28 Thread Paolo Bonzini
On 24/09/21 00:00, Oliver Upton wrote: While x86 does not require any additional setup to use the ucall infrastructure, arm64 needs to set up the MMIO address used to signal a ucall to userspace. rseq_test does not initialize the MMIO address, resulting in the test spinning indefinitely. Fix

Re: [PATCH] selftests: KVM: Call ucall_init when setting up in rseq_test

2021-09-28 Thread Andrew Jones
On Mon, Sep 27, 2021 at 08:05:14PM +, Sean Christopherson wrote: > On Fri, Sep 24, 2021, Andrew Jones wrote: > > On Fri, Sep 24, 2021 at 12:09:06AM +, Sean Christopherson wrote: > > > On Thu, Sep 23, 2021, Oliver Upton wrote: > > > > While x86 does not require any additional setup to use

Re: [PATCH] selftests: KVM: Call ucall_init when setting up in rseq_test

2021-09-27 Thread Sean Christopherson
On Fri, Sep 24, 2021, Andrew Jones wrote: > On Fri, Sep 24, 2021 at 12:09:06AM +, Sean Christopherson wrote: > > On Thu, Sep 23, 2021, Oliver Upton wrote: > > > While x86 does not require any additional setup to use the ucall > > > infrastructure, arm64 needs to set up the MMIO address used to

Re: [PATCH] selftests: KVM: Call ucall_init when setting up in rseq_test

2021-09-24 Thread Andrew Jones
On Fri, Sep 24, 2021 at 12:09:06AM +, Sean Christopherson wrote: > On Thu, Sep 23, 2021, Oliver Upton wrote: > > While x86 does not require any additional setup to use the ucall > > infrastructure, arm64 needs to set up the MMIO address used to signal a > > ucall to userspace. rseq_test does

Re: [PATCH] selftests: KVM: Call ucall_init when setting up in rseq_test

2021-09-24 Thread Paolo Bonzini
On 24/09/21 02:10, Oliver Upton wrote: */ vm = vm_create_default(VCPU_ID, 0, guest_code); + ucall_init(vm, NULL); Any reason not to do this automatically in vm_create()? There is 0% chance I'm going to remember to add this next time I write a common selftest, arm64 is the

Re: [PATCH] selftests: KVM: Call ucall_init when setting up in rseq_test

2021-09-23 Thread Oliver Upton
On Thu, Sep 23, 2021 at 5:09 PM Sean Christopherson wrote: > > On Thu, Sep 23, 2021, Oliver Upton wrote: > > While x86 does not require any additional setup to use the ucall > > infrastructure, arm64 needs to set up the MMIO address used to signal a > > ucall to userspace. rseq_test does not

Re: [PATCH] selftests: KVM: Call ucall_init when setting up in rseq_test

2021-09-23 Thread Sean Christopherson
On Thu, Sep 23, 2021, Oliver Upton wrote: > While x86 does not require any additional setup to use the ucall > infrastructure, arm64 needs to set up the MMIO address used to signal a > ucall to userspace. rseq_test does not initialize the MMIO address, > resulting in the test spinning

[PATCH] selftests: KVM: Call ucall_init when setting up in rseq_test

2021-09-23 Thread Oliver Upton
While x86 does not require any additional setup to use the ucall infrastructure, arm64 needs to set up the MMIO address used to signal a ucall to userspace. rseq_test does not initialize the MMIO address, resulting in the test spinning indefinitely. Fix the issue by calling ucall_init() during