Re: [PATCH 02/14] KVM: arm64: Tear down unlinked stage-2 subtree after break-before-make

2022-10-09 Thread Oliver Upton
Hey Ricardo, On Tue, Sep 13, 2022 at 05:20:11PM -0700, Ricardo Koller wrote: [...] > > diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c > > index d8127c25424c..5c0c8028d71c 100644 > > --- a/arch/arm64/kvm/hyp/pgtable.c > > +++ b/arch/arm64/kvm/hyp/pgtable.c > > @@

Re: [PATCH 02/14] KVM: arm64: Tear down unlinked stage-2 subtree after break-before-make

2022-09-09 Thread Oliver Upton
On Wed, Sep 07, 2022 at 01:57:17PM -0700, David Matlack wrote: > On Tue, Aug 30, 2022 at 07:41:20PM +, Oliver Upton wrote: > [...] > > > > +static int stage2_map_walk_leaf(u64 addr, u64 end, u32 level, kvm_pte_t > > *ptep, > > + struct stage2_map_data *data); > > +

Re: [PATCH 02/14] KVM: arm64: Tear down unlinked stage-2 subtree after break-before-make

2022-09-09 Thread Oliver Upton
On Tue, Sep 06, 2022 at 02:35:47PM +, Quentin Perret wrote: > Hi Oliver, > > On Tuesday 30 Aug 2022 at 19:41:20 (+), Oliver Upton wrote: > > static int stage2_map_walk_table_pre(u64 addr, u64 end, u32 level, > > kvm_pte_t *ptep, > >

[PATCH 02/14] KVM: arm64: Tear down unlinked stage-2 subtree after break-before-make

2022-08-30 Thread Oliver Upton
The break-before-make sequence is a bit annoying as it opens a window wherein memory is unmapped from the guest. KVM should replace the PTE as quickly as possible and avoid unnecessary work in between. Presently, the stage-2 map walker tears down a removed table before installing a block mapping