Re: [PATCH 1/2] kvm/arm: skip MMIO insn after emulation

2018-12-11 Thread Christoffer Dall
On Fri, Nov 09, 2018 at 03:07:10PM +, Mark Rutland wrote: > When we emulate an MMIO instruction, we advance the CPU state within > decode_hsr(), before emulating the instruction effects. > > Having this logic in decode_hsr() is opaque, and advancing the state > before emulation is problematic.

Re: [PATCH 1/2] kvm/arm: skip MMIO insn after emulation

2018-11-09 Thread Alex Bennée
Mark Rutland writes: > When we emulate an MMIO instruction, we advance the CPU state within > decode_hsr(), before emulating the instruction effects. > > Having this logic in decode_hsr() is opaque, and advancing the state > before emulation is problematic. It gets in the way of applying > consi

[PATCH 1/2] kvm/arm: skip MMIO insn after emulation

2018-11-09 Thread Mark Rutland
When we emulate an MMIO instruction, we advance the CPU state within decode_hsr(), before emulating the instruction effects. Having this logic in decode_hsr() is opaque, and advancing the state before emulation is problematic. It gets in the way of applying consistent single-step logic, and it pre