Re: [PATCH 1/4] KVM: arm64: Enable Pointer Authentication at EL2 if available

2020-06-15 Thread Andrew Scull
On Mon, Jun 15, 2020 at 09:19:51AM +0100, Marc Zyngier wrote: > While initializing EL2, switch Pointer Authentication if detected ^ nit: on? > from EL1. We use the EL1-provided keys though. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/kvm/hyp-init.S | 11 +

Re: [PATCH 1/4] KVM: arm64: Enable Pointer Authentication at EL2 if available

2020-06-15 Thread Marc Zyngier
On 2020-06-15 11:03, Mark Rutland wrote: On Mon, Jun 15, 2020 at 09:19:51AM +0100, Marc Zyngier wrote: While initializing EL2, switch Pointer Authentication if detected from EL1. We use the EL1-provided keys though. Perhaps "enable address authentication", to avoid confusion with context-switc

Re: [PATCH 1/4] KVM: arm64: Enable Pointer Authentication at EL2 if available

2020-06-15 Thread Marc Zyngier
Hi Andrew, On 2020-06-15 09:48, Andrew Scull wrote: On Mon, Jun 15, 2020 at 09:19:51AM +0100, Marc Zyngier wrote: While initializing EL2, switch Pointer Authentication if detected ^ nit: on? Yes. from EL1. We use the EL1-provided keys though. Signed-off-

Re: [PATCH 1/4] KVM: arm64: Enable Pointer Authentication at EL2 if available

2020-06-15 Thread Mark Rutland
On Mon, Jun 15, 2020 at 09:19:51AM +0100, Marc Zyngier wrote: > While initializing EL2, switch Pointer Authentication if detected > from EL1. We use the EL1-provided keys though. Perhaps "enable address authentication", to avoid confusion with context-switch, and since generic authentication canno

[PATCH 1/4] KVM: arm64: Enable Pointer Authentication at EL2 if available

2020-06-15 Thread Marc Zyngier
While initializing EL2, switch Pointer Authentication if detected from EL1. We use the EL1-provided keys though. Signed-off-by: Marc Zyngier --- arch/arm64/kvm/hyp-init.S | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/kvm/hyp-init.S b/arch/arm64/kvm/hyp-init.S index