Re: [PATCH 2/4] KVM: arm64: Don't serialize if the access flag isn't set

2022-12-01 Thread Oliver Upton
On Tue, Nov 29, 2022 at 09:15:21PM +, Oliver Upton wrote: > Hi Ricardo, > > Thanks for having a look. > > On Tue, Nov 29, 2022 at 12:52:12PM -0800, Ricardo Koller wrote: > > On Tue, Nov 29, 2022 at 07:19:44PM +, Oliver Upton wrote: > > [...] > > > > + ret = stage2_update_leaf_attrs(pgt,

Re: [PATCH 2/4] KVM: arm64: Don't serialize if the access flag isn't set

2022-11-30 Thread Ricardo Koller
On Wed, Nov 30, 2022 at 08:21:17AM +, Marc Zyngier wrote: > On Wed, 30 Nov 2022 01:23:20 +, > Ricardo Koller wrote: > > > > On Tue, Nov 29, 2022 at 09:15:21PM +, Oliver Upton wrote: > > > Hi Ricardo, > > > > > > Thanks for having a look. > > > > > > On Tue, Nov 29, 2022 at 12:52:12P

Re: [PATCH 2/4] KVM: arm64: Don't serialize if the access flag isn't set

2022-11-30 Thread Marc Zyngier
On Wed, 30 Nov 2022 01:23:20 +, Ricardo Koller wrote: > > On Tue, Nov 29, 2022 at 09:15:21PM +, Oliver Upton wrote: > > Hi Ricardo, > > > > Thanks for having a look. > > > > On Tue, Nov 29, 2022 at 12:52:12PM -0800, Ricardo Koller wrote: > > > On Tue, Nov 29, 2022 at 07:19:44PM +, O

Re: [PATCH 2/4] KVM: arm64: Don't serialize if the access flag isn't set

2022-11-29 Thread Ricardo Koller
On Tue, Nov 29, 2022 at 09:15:21PM +, Oliver Upton wrote: > Hi Ricardo, > > Thanks for having a look. > > On Tue, Nov 29, 2022 at 12:52:12PM -0800, Ricardo Koller wrote: > > On Tue, Nov 29, 2022 at 07:19:44PM +, Oliver Upton wrote: > > [...] > > > > + ret = stage2_update_leaf_attrs(pgt,

Re: [PATCH 2/4] KVM: arm64: Don't serialize if the access flag isn't set

2022-11-29 Thread Oliver Upton
Hi Ricardo, Thanks for having a look. On Tue, Nov 29, 2022 at 12:52:12PM -0800, Ricardo Koller wrote: > On Tue, Nov 29, 2022 at 07:19:44PM +, Oliver Upton wrote: [...] > > + ret = stage2_update_leaf_attrs(pgt, addr, 1, > > KVM_PTE_LEAF_ATTR_LO_S2_AF, 0, > > +

Re: [PATCH 2/4] KVM: arm64: Don't serialize if the access flag isn't set

2022-11-29 Thread Ricardo Koller
On Tue, Nov 29, 2022 at 07:19:44PM +, Oliver Upton wrote: > Of course, if the PTE wasn't changed then there are absolutely no > serialization requirements. Skip the DSB for an unsuccessful update to > the access flag. > > Signed-off-by: Oliver Upton > --- > arch/arm64/kvm/hyp/pgtable.c | 10

[PATCH 2/4] KVM: arm64: Don't serialize if the access flag isn't set

2022-11-29 Thread Oliver Upton
Of course, if the PTE wasn't changed then there are absolutely no serialization requirements. Skip the DSB for an unsuccessful update to the access flag. Signed-off-by: Oliver Upton --- arch/arm64/kvm/hyp/pgtable.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/ar