Re: [PATCH 3/5] KVM: arm64: Drop check_kvm_target_cpu() based percpu probe

2021-08-10 Thread Anshuman Khandual
On 8/10/21 6:58 PM, Will Deacon wrote: > On Tue, Aug 10, 2021 at 12:32:39PM +0530, Anshuman Khandual wrote: >> kvm_target_cpu() never returns a negative error code, so check_kvm_target() >> would never have 'ret' filled with a negative error code. Hence the percpu >> probe via check_kvm_target_c

Re: [PATCH 3/5] KVM: arm64: Drop check_kvm_target_cpu() based percpu probe

2021-08-10 Thread Will Deacon
On Tue, Aug 10, 2021 at 12:32:39PM +0530, Anshuman Khandual wrote: > kvm_target_cpu() never returns a negative error code, so check_kvm_target() > would never have 'ret' filled with a negative error code. Hence the percpu > probe via check_kvm_target_cpu() does not make sense as its never going to

[PATCH 3/5] KVM: arm64: Drop check_kvm_target_cpu() based percpu probe

2021-08-10 Thread Anshuman Khandual
kvm_target_cpu() never returns a negative error code, so check_kvm_target() would never have 'ret' filled with a negative error code. Hence the percpu probe via check_kvm_target_cpu() does not make sense as its never going to find an unsupported CPU, forcing kvm_arch_init() to exit early. Hence let