Re: [PATCH kvmtool 13/21] hw/serial: Refactor trap handler

2021-02-24 Thread Andre Przywara
On Mon, 22 Feb 2021 17:40:36 + Alexandru Elisei wrote: Hi Alex, > On 2/18/21 2:41 PM, Andre Przywara wrote: > > On Tue, 16 Feb 2021 14:22:05 + > > Alexandru Elisei wrote: > > > >> Hi Andre, > >> > >> Patch looks good, nitpicks below. > >> > >> On 12/10/20 2:29 PM, Andre Przywara wrote

Re: [PATCH kvmtool 13/21] hw/serial: Refactor trap handler

2021-02-22 Thread Alexandru Elisei
Hi Andre, On 2/18/21 2:41 PM, Andre Przywara wrote: > On Tue, 16 Feb 2021 14:22:05 + > Alexandru Elisei wrote: > >> Hi Andre, >> >> Patch looks good, nitpicks below. >> >> On 12/10/20 2:29 PM, Andre Przywara wrote: >>> With the planned retirement of the special ioport emulation code, we >>> n

Re: [PATCH kvmtool 13/21] hw/serial: Refactor trap handler

2021-02-18 Thread Andre Przywara
On Tue, 16 Feb 2021 14:22:05 + Alexandru Elisei wrote: > Hi Andre, > > Patch looks good, nitpicks below. > > On 12/10/20 2:29 PM, Andre Przywara wrote: > > With the planned retirement of the special ioport emulation code, we > > need to provide an emulation function compatible with the MMIO

Re: [PATCH kvmtool 13/21] hw/serial: Refactor trap handler

2021-02-16 Thread Alexandru Elisei
Hi Andre, Patch looks good, nitpicks below. On 12/10/20 2:29 PM, Andre Przywara wrote: > With the planned retirement of the special ioport emulation code, we > need to provide an emulation function compatible with the MMIO prototype. > > Adjust the trap handler to use that new function, and provi

[PATCH kvmtool 13/21] hw/serial: Refactor trap handler

2020-12-10 Thread Andre Przywara
With the planned retirement of the special ioport emulation code, we need to provide an emulation function compatible with the MMIO prototype. Adjust the trap handler to use that new function, and provide shims to implement the old ioport interface, for now. Signed-off-by: Andre Przywara --- hw