Re: [PATCH kvmtool v3 2/9] update_headers.sh: Cleanly report failure on error

2019-06-03 Thread Dave Martin
On Fri, May 31, 2019 at 06:03:10PM +0100, Andre Przywara wrote: > On Thu, 30 May 2019 16:13:07 +0100 > Dave Martin wrote: > > > If in intermediate step fails, update_headers.sh blindly continues > > and may return success status. > > > > To avoid errors going unnoticed when driving this script,

Re: [PATCH kvmtool v3 2/9] update_headers.sh: Cleanly report failure on error

2019-05-31 Thread Andre Przywara
On Thu, 30 May 2019 16:13:07 +0100 Dave Martin wrote: > If in intermediate step fails, update_headers.sh blindly continues > and may return success status. > > To avoid errors going unnoticed when driving this script, exit and > report failure status as soon as something goes wrong. For good >

[PATCH kvmtool v3 2/9] update_headers.sh: Cleanly report failure on error

2019-05-30 Thread Dave Martin
If in intermediate step fails, update_headers.sh blindly continues and may return success status. To avoid errors going unnoticed when driving this script, exit and report failure status as soon as something goes wrong. For good measure, also fail on expansion of undefined shell variables to aid