Re: [PATCH v11 03/40] arm64: cpufeature: Always specify and use a field width for capabilities

2022-03-02 Thread Qian Cai
On Mon, Feb 07, 2022 at 03:20:32PM +, Mark Brown wrote: > Since all the fields in the main ID registers are 4 bits wide we have up > until now not bothered specifying the width in the code. Since we now > wish to use this mechanism to enumerate features from the floating point > feature registe

Re: [PATCH v11 03/40] arm64: cpufeature: Always specify and use a field width for capabilities

2022-03-02 Thread Mark Brown
On Wed, Mar 02, 2022 at 11:52:49AM +, Catalin Marinas wrote: > On Wed, Mar 02, 2022 at 10:12:09AM +, Marc Zyngier wrote: > > I don't think that's on purpose, and we should definitely address > > this. Maybe we should have a warning if we spot an occurrence of > > .width being 0. > We shou

Re: [PATCH v11 03/40] arm64: cpufeature: Always specify and use a field width for capabilities

2022-03-02 Thread Mark Brown
On Tue, Mar 01, 2022 at 05:56:41PM -0500, Qian Cai wrote: > On Mon, Feb 07, 2022 at 03:20:32PM +, Mark Brown wrote: > > Since all the fields in the main ID registers are 4 bits wide we have up > > until now not bothered specifying the width in the code. Since we now > Do we leave this one alon

Re: [PATCH v11 03/40] arm64: cpufeature: Always specify and use a field width for capabilities

2022-03-02 Thread Catalin Marinas
On Wed, Mar 02, 2022 at 10:12:09AM +, Marc Zyngier wrote: > On Tue, 01 Mar 2022 22:56:41 +, > Qian Cai wrote: > > > > On Mon, Feb 07, 2022 at 03:20:32PM +, Mark Brown wrote: > > > Since all the fields in the main ID registers are 4 bits wide we have up > > > until now not bothered spe

Re: [PATCH v11 03/40] arm64: cpufeature: Always specify and use a field width for capabilities

2022-03-02 Thread Marc Zyngier
On Tue, 01 Mar 2022 22:56:41 +, Qian Cai wrote: > > On Mon, Feb 07, 2022 at 03:20:32PM +, Mark Brown wrote: > > Since all the fields in the main ID registers are 4 bits wide we have up > > until now not bothered specifying the width in the code. Since we now > > wish to use this mechanism

Re: [PATCH v11 03/40] arm64: cpufeature: Always specify and use a field width for capabilities

2022-02-10 Thread Suzuki K Poulose
On 07/02/2022 15:20, Mark Brown wrote: Since all the fields in the main ID registers are 4 bits wide we have up until now not bothered specifying the width in the code. Since we now wish to use this mechanism to enumerate features from the floating point feature registers which do not follow this

Re: [PATCH v11 03/40] arm64: cpufeature: Always specify and use a field width for capabilities

2022-02-10 Thread Catalin Marinas
On Mon, Feb 07, 2022 at 03:20:32PM +, Mark Brown wrote: > Since all the fields in the main ID registers are 4 bits wide we have up > until now not bothered specifying the width in the code. Since we now > wish to use this mechanism to enumerate features from the floating point > feature registe

[PATCH v11 03/40] arm64: cpufeature: Always specify and use a field width for capabilities

2022-02-07 Thread Mark Brown
Since all the fields in the main ID registers are 4 bits wide we have up until now not bothered specifying the width in the code. Since we now wish to use this mechanism to enumerate features from the floating point feature registers which do not follow this pattern add a width to the table. This