Re: [PATCH v2] KVM: arm64: nvhe: Fix build with profile optimization

2022-10-13 Thread Denis Nikitin
Thank you Marc for figuring out the filtering-out solution! It fixed the build on ChromeOS. I will update the patch and also filter out `-fprofile-use` which will avoid a similar problem with the instrumented PGO in the future. Thanks, Denis On Thu, Oct 13, 2022 at 4:09 AM Marc Zyngier wrote: >

Re: [PATCH v2] KVM: arm64: nvhe: Fix build with profile optimization

2022-10-13 Thread Marc Zyngier
On Tue, 11 Oct 2022 03:15:36 +0100, Denis Nikitin wrote: > > On Sat, Oct 8, 2022 at 7:22 PM Marc Zyngier wrote: > > > > On Thu, 06 Oct 2022 17:28:17 +0100, > > Denis Nikitin wrote: > > > > > > Hi Mark, > > > > s/k/c/ > > > > > > > > This problem currently blocks the PGO roll on the ChromeOS ker

Re: [PATCH v2] KVM: arm64: nvhe: Fix build with profile optimization

2022-10-10 Thread Denis Nikitin
On Sat, Oct 8, 2022 at 7:22 PM Marc Zyngier wrote: > > On Thu, 06 Oct 2022 17:28:17 +0100, > Denis Nikitin wrote: > > > > Hi Mark, > > s/k/c/ > > > > > This problem currently blocks the PGO roll on the ChromeOS kernel and > > we need some kind of a solution. > > I'm sorry, but I don't feel constr

Re: [PATCH v2] KVM: arm64: nvhe: Fix build with profile optimization

2022-10-08 Thread Marc Zyngier
On Thu, 06 Oct 2022 17:28:17 +0100, Denis Nikitin wrote: > > Hi Mark, s/k/c/ > > This problem currently blocks the PGO roll on the ChromeOS kernel and > we need some kind of a solution. I'm sorry, but I don't feel constrained by your internal deadlines. I have my own... > Could you please ta

Re: [PATCH v2] KVM: arm64: nvhe: Fix build with profile optimization

2022-10-06 Thread Denis Nikitin
Hi Mark, This problem currently blocks the PGO roll on the ChromeOS kernel and we need some kind of a solution. Could you please take a look? Thanks, Denis On Thu, Sep 29, 2022 at 9:13 AM Denis Nikitin wrote: > > Hi Marc, > > Please let me know what you think about this approach. > > Thanks, >

Re: [PATCH v2] KVM: arm64: nvhe: Fix build with profile optimization

2022-09-29 Thread Denis Nikitin
Hi Marc, Please let me know what you think about this approach. Thanks, Denis On Thu, Sep 22, 2022 at 11:04 PM Manoj Gupta wrote: > > > > On Thu, Sep 22, 2022 at 10:01 PM Denis Nikitin wrote: >> >> Hi Mark, >> >> On Thu, Sep 22, 2022 at 3:38 AM Marc Zyngier wrote: >> > >> > I was really hopin

Re: [PATCH v2] KVM: arm64: nvhe: Fix build with profile optimization

2022-09-23 Thread Manoj Gupta
On Thu, Sep 22, 2022 at 10:01 PM Denis Nikitin wrote: > Hi Mark, > > On Thu, Sep 22, 2022 at 3:38 AM Marc Zyngier wrote: > > > > I was really hoping that you'd just drop the flags from the CFLAGS > > instead of removing the generated section. Something like: > > > > diff --git a/arch/arm64/kvm/h

Re: [PATCH v2] KVM: arm64: nvhe: Fix build with profile optimization

2022-09-22 Thread Denis Nikitin
Hi Mark, On Thu, Sep 22, 2022 at 3:38 AM Marc Zyngier wrote: > > I was really hoping that you'd just drop the flags from the CFLAGS > instead of removing the generated section. Something like: > > diff --git a/arch/arm64/kvm/hyp/nvhe/Makefile > b/arch/arm64/kvm/hyp/nvhe/Makefile > index b5c5119c

Re: [PATCH v2] KVM: arm64: nvhe: Fix build with profile optimization

2022-09-22 Thread Marc Zyngier
On Thu, 22 Sep 2022 06:31:45 +0100, Denis Nikitin wrote: > > Kernel build with clang and KCFLAGS=-fprofile-sample-use fails with: > > error: arch/arm64/kvm/hyp/nvhe/kvm_nvhe.tmp.o: Unexpected SHT_REL > section ".rel.llvm.call-graph-profile" > > Starting from 13.0.0 llvm can generate SHT_REL sec

[PATCH v2] KVM: arm64: nvhe: Fix build with profile optimization

2022-09-22 Thread Denis Nikitin
Kernel build with clang and KCFLAGS=-fprofile-sample-use fails with: error: arch/arm64/kvm/hyp/nvhe/kvm_nvhe.tmp.o: Unexpected SHT_REL section ".rel.llvm.call-graph-profile" Starting from 13.0.0 llvm can generate SHT_REL section, see https://reviews.llvm.org/rGca3bdb57fa1ac98b711a735de048c12b5fdd