[PATCH v2 1/4] arm64: arm_pmu: remove unnecessary isb instruction

2018-11-21 Thread Andrew Murray
The armv8pmu_enable_event_counter function issues an isb instruction after enabling a pair of counters - this doesn't provide any value and is inconsistent with the armv8pmu_disable_event_counter. In any case armv8pmu_enable_event_counter is always called with the PMU stopped. Starting the PMU wit

Re: [PATCH v2 1/4] arm64: arm_pmu: remove unnecessary isb instruction

2018-11-20 Thread Suzuki K Poulose
On 11/20/2018 02:15 PM, Andrew Murray wrote: The armv8pmu_enable_event_counter function issues an isb instruction after enabling a pair of counters - this doesn't provide any value and is inconsistent with the armv8pmu_disable_event_counter. In any case armv8pmu_enable_event_counter is always ca

Re: [PATCH v2 1/4] arm64: arm_pmu: remove unnecessary isb instruction

2018-11-21 Thread Mark Rutland
On Tue, Nov 20, 2018 at 02:15:19PM +, Andrew Murray wrote: > The armv8pmu_enable_event_counter function issues an isb instruction > after enabling a pair of counters - this doesn't provide any value > and is inconsistent with the armv8pmu_disable_event_counter. > > In any case armv8pmu_enable_

Re: [PATCH v2 1/4] arm64: arm_pmu: remove unnecessary isb instruction

2018-11-22 Thread Andrew Murray
On Wed, Nov 21, 2018 at 03:58:14PM +, Mark Rutland wrote: > On Tue, Nov 20, 2018 at 02:15:19PM +, Andrew Murray wrote: > > The armv8pmu_enable_event_counter function issues an isb instruction > > after enabling a pair of counters - this doesn't provide any value > > and is inconsistent with