Re: [PATCH v2 2/9] KVM: Add documentation for VCPU requests

2017-04-07 Thread Paolo Bonzini
On 06/04/2017 22:29, Christoffer Dall wrote: > We could encode the lazy/non-lazy thing in a bit in the request number > that gets masked off before clearing/checking the request bit, but > perhaps there are nicer solutions. Actually this is the first "nice" solution that it's been proposed. Tha

Re: [PATCH v2 2/9] KVM: Add documentation for VCPU requests

2017-04-06 Thread Christoffer Dall
On Wed, Apr 05, 2017 at 10:46:07PM +0200, Radim Krčmář wrote: > 2017-04-05 20:29+0200, Paolo Bonzini: > > On 05/04/2017 19:45, Christoffer Dall wrote: > But the problem is that kvm_make_all_cpus_request() only sends IPIs to > CPUs where the mode was different from OUTSIDE_GUEST_MODE, so t

Re: [PATCH v2 2/9] KVM: Add documentation for VCPU requests

2017-04-06 Thread Christoffer Dall
On Wed, Apr 05, 2017 at 08:29:12PM +0200, Paolo Bonzini wrote: > > > On 05/04/2017 19:45, Christoffer Dall wrote: > >>> But the problem is that kvm_make_all_cpus_request() only sends IPIs to > >>> CPUs where the mode was different from OUTSIDE_GUEST_MODE, so there it's > >>> about !OUTSIDE_GUEST_

Re: [PATCH v2 2/9] KVM: Add documentation for VCPU requests

2017-04-06 Thread Radim Krčmář
2017-04-06 12:18+0200, Christian Borntraeger: > On 03/31/2017 06:06 PM, Andrew Jones wrote: >> Signed-off-by: Andrew Jones >> +VCPU Requests and Guest Mode >> + > > FWIW, s390 does not implement the guest mode. Maybe add some words that not > all architectures implemen

Re: [PATCH v2 2/9] KVM: Add documentation for VCPU requests

2017-04-06 Thread Andrew Jones
On Thu, Apr 06, 2017 at 12:18:02PM +0200, Christian Borntraeger wrote: > On 03/31/2017 06:06 PM, Andrew Jones wrote: > > Signed-off-by: Andrew Jones > > --- > > Documentation/virtual/kvm/vcpu-requests.rst | 114 > > > > 1 file changed, 114 insertions(+) > > create m

Re: [PATCH v2 2/9] KVM: Add documentation for VCPU requests

2017-04-06 Thread Christian Borntraeger
On 03/31/2017 06:06 PM, Andrew Jones wrote: > Signed-off-by: Andrew Jones > --- > Documentation/virtual/kvm/vcpu-requests.rst | 114 > > 1 file changed, 114 insertions(+) > create mode 100644 Documentation/virtual/kvm/vcpu-requests.rst > > diff --git a/Documentatio

Re: [PATCH v2 2/9] KVM: Add documentation for VCPU requests

2017-04-05 Thread Radim Krčmář
2017-04-05 20:29+0200, Paolo Bonzini: > On 05/04/2017 19:45, Christoffer Dall wrote: But the problem is that kvm_make_all_cpus_request() only sends IPIs to CPUs where the mode was different from OUTSIDE_GUEST_MODE, so there it's about !OUTSIDE_GUEST_MODE rather than !IN_GUEST_MODE, s

Re: [PATCH v2 2/9] KVM: Add documentation for VCPU requests

2017-04-05 Thread Paolo Bonzini
On 05/04/2017 19:45, Christoffer Dall wrote: >>> But the problem is that kvm_make_all_cpus_request() only sends IPIs to >>> CPUs where the mode was different from OUTSIDE_GUEST_MODE, so there it's >>> about !OUTSIDE_GUEST_MODE rather than !IN_GUEST_MODE, so there's some >>> subtlety here which I

Re: [PATCH v2 2/9] KVM: Add documentation for VCPU requests

2017-04-05 Thread Christoffer Dall
On Wed, Apr 05, 2017 at 04:11:40PM +0200, Radim Krčmář wrote: > 2017-04-04 19:23+0200, Christoffer Dall: > > On Tue, Apr 04, 2017 at 07:06:00PM +0200, Andrew Jones wrote: > >> On Tue, Apr 04, 2017 at 05:24:03PM +0200, Christoffer Dall wrote: > >> > On Fri, Mar 31, 2017 at 06:06:51PM +0200, Andrew J

Re: [PATCH v2 2/9] KVM: Add documentation for VCPU requests

2017-04-05 Thread Radim Krčmář
2017-04-04 19:23+0200, Christoffer Dall: > On Tue, Apr 04, 2017 at 07:06:00PM +0200, Andrew Jones wrote: >> On Tue, Apr 04, 2017 at 05:24:03PM +0200, Christoffer Dall wrote: >> > On Fri, Mar 31, 2017 at 06:06:51PM +0200, Andrew Jones wrote: >> > > +and will definitely see the request, or is outside

Re: [PATCH v2 2/9] KVM: Add documentation for VCPU requests

2017-04-04 Thread Paolo Bonzini
On 04/04/2017 19:23, Christoffer Dall wrote: >> I think all !IN_GUEST_MODE should behave the same, so I was avoiding >> the use of EXITING_GUEST_MODE and OUTSIDE_GUEST_MODE, which wouldn't be >> hard to address, but then I'd also have to address >> READING_SHADOW_PAGE_TABLES, which may complicate

Re: [PATCH v2 2/9] KVM: Add documentation for VCPU requests

2017-04-04 Thread Christoffer Dall
On Tue, Apr 04, 2017 at 07:06:00PM +0200, Andrew Jones wrote: > On Tue, Apr 04, 2017 at 05:24:03PM +0200, Christoffer Dall wrote: > > Hi Drew, > > > > On Fri, Mar 31, 2017 at 06:06:51PM +0200, Andrew Jones wrote: > > > Signed-off-by: Andrew Jones > > > --- > > > Documentation/virtual/kvm/vcpu-re

Re: [PATCH v2 2/9] KVM: Add documentation for VCPU requests

2017-04-04 Thread Andrew Jones
On Tue, Apr 04, 2017 at 05:24:03PM +0200, Christoffer Dall wrote: > Hi Drew, > > On Fri, Mar 31, 2017 at 06:06:51PM +0200, Andrew Jones wrote: > > Signed-off-by: Andrew Jones > > --- > > Documentation/virtual/kvm/vcpu-requests.rst | 114 > > > > 1 file changed, 114

Re: [PATCH v2 2/9] KVM: Add documentation for VCPU requests

2017-04-04 Thread Christoffer Dall
Hi Drew, On Fri, Mar 31, 2017 at 06:06:51PM +0200, Andrew Jones wrote: > Signed-off-by: Andrew Jones > --- > Documentation/virtual/kvm/vcpu-requests.rst | 114 > > 1 file changed, 114 insertions(+) > create mode 100644 Documentation/virtual/kvm/vcpu-requests.rst >

[PATCH v2 2/9] KVM: Add documentation for VCPU requests

2017-03-31 Thread Andrew Jones
Signed-off-by: Andrew Jones --- Documentation/virtual/kvm/vcpu-requests.rst | 114 1 file changed, 114 insertions(+) create mode 100644 Documentation/virtual/kvm/vcpu-requests.rst diff --git a/Documentation/virtual/kvm/vcpu-requests.rst b/Documentation/virtual/kvm/