Re: [PATCH v2 3/4] KVM: arm/arm64: Move to common kvm_mmu_memcache infrastructure

2019-03-15 Thread Paolo Bonzini
On 31/01/19 10:52, Christoffer Dall wrote: > +#define KVM_MMU_CACHE_GFPGFP_KERNEL > +#define KVM_MMU_CACHE_PAGE_GFP (GFP_KERNEL | __GFP_ZERO) This should be GFP_KERNEL_ACCOUNT. Can you leave GFP_KERNEL_ACCOUNT in virt/kvm/kvm_main.c, and only use these #defines to add __GFP_ZERO? I

[PATCH v2 3/4] KVM: arm/arm64: Move to common kvm_mmu_memcache infrastructure

2019-01-31 Thread Christoffer Dall
Now when we have a common mmu mmemcache implementation, we can reuse this for arm and arm64. The common implementation has a slightly different behavior when allocating objects under high memory pressure; whereas the current arm/arm64 implementation will give up and return -ENOMEM if the full