Re: [PATCH v3 07/21] KVM: arm64: Convert kvm_phys_addr_ioremap() to generic page-table API

2020-09-02 Thread Gavin Shan
On 8/25/20 7:39 PM, Will Deacon wrote: Convert kvm_phys_addr_ioremap() to use kvm_pgtable_stage2_map() instead of stage2_set_pte(). Cc: Marc Zyngier Cc: Quentin Perret Signed-off-by: Will Deacon --- arch/arm64/kvm/hyp/pgtable.c | 14 +- arch/arm64/kvm/mmu.c | 29 +++

Re: [PATCH v3 07/21] KVM: arm64: Convert kvm_phys_addr_ioremap() to generic page-table API

2020-09-02 Thread Will Deacon
On Tue, Sep 01, 2020 at 06:08:01PM +0100, Alexandru Elisei wrote: > On 8/25/20 10:39 AM, Will Deacon wrote: > > Convert kvm_phys_addr_ioremap() to use kvm_pgtable_stage2_map() instead > > of stage2_set_pte(). > > > > Cc: Marc Zyngier > > Cc: Quentin Perret > > Signed-off-by: Will Deacon > > ---

Re: [PATCH v3 07/21] KVM: arm64: Convert kvm_phys_addr_ioremap() to generic page-table API

2020-09-01 Thread Alexandru Elisei
Hi Will, The patch looks correct to me. I also had another look at the pre-order visitor for kvm_pgtable_stage2_map, and it will not try to map the address range using a block mapping (kvm_block_mapping_supported returns false). One nitpick below. On 8/25/20 10:39 AM, Will Deacon wrote: > Conver

[PATCH v3 07/21] KVM: arm64: Convert kvm_phys_addr_ioremap() to generic page-table API

2020-08-25 Thread Will Deacon
Convert kvm_phys_addr_ioremap() to use kvm_pgtable_stage2_map() instead of stage2_set_pte(). Cc: Marc Zyngier Cc: Quentin Perret Signed-off-by: Will Deacon --- arch/arm64/kvm/hyp/pgtable.c | 14 +- arch/arm64/kvm/mmu.c | 29 - 2 files changed, 13