[PATCH v3 15/20] KVM: arm64: Set an impdef ESR for Virtual-SError using VSESR_EL2.

2017-10-05 Thread James Morse
Prior to v8.2's RAS Extensions, the HCR_EL2.VSE 'virtual SError' feature generated an SError with an implementation defined ESR_EL1.ISS, because we had no mechanism to specify the ESR value. On Juno this generates an all-zero ESR, the most significant bit 'ISV' is clear indicating the remainder of

Re: [PATCH v3 15/20] KVM: arm64: Set an impdef ESR for Virtual-SError using VSESR_EL2.

2017-10-13 Thread gengdongjiu
Hi James, After checking this patch, I think my patch[1] already include this logic(only a little difference). In my first version patch [2], It sets the virtual ESR in the KVM, but Marc and other people disagree that[3][4],and propose to set its value and injection by userspace(when RAS is

Re: [PATCH v3 15/20] KVM: arm64: Set an impdef ESR for Virtual-SError using VSESR_EL2.

2017-10-13 Thread James Morse
Hi gengdongjiu, On 13/10/17 10:25, gengdongjiu wrote: > After checking this patch, I think my patch[1] already include this > logic(only a little > difference). Your kvm_handle_guest_sei() is similar to where this series ends up, but the purpose of this patch is to keep KVMs existing behaviour.

Re: [PATCH v3 15/20] KVM: arm64: Set an impdef ESR for Virtual-SError using VSESR_EL2.

2017-10-15 Thread gengdongjiu
Hi James, Thanks for your mail. > Hi gengdongjiu, > > On 13/10/17 10:25, gengdongjiu wrote: > > After checking this patch, I think my patch[1] already include this > > logic(only a little difference). > > Your kvm_handle_guest_sei() is similar to where this series ends up, but the > purpose o

Re: [PATCH v3 15/20] KVM: arm64: Set an impdef ESR for Virtual-SError using VSESR_EL2.

2017-10-15 Thread gengdongjiu
> In fact I have below method for that, what do you think about that? > > 1. If there is no RAS, old method, directly inject virtual SError, not need > to specify ESR, as shown in the [1] > 2. If there is RAS, KVM set "the kvm_run" guest exit type value to let user > space handle the SError abo

Re: [PATCH v3 15/20] KVM: arm64: Set an impdef ESR for Virtual-SError using VSESR_EL2.

2017-10-16 Thread James Morse
Hi gengdongjiu, On 16/10/17 04:17, gengdongjiu wrote: >> In fact I have below method for that, what do you think about that? >> >> 1. If there is no RAS, old method, directly inject virtual SError, not need >> to specify ESR, as shown in the [1] >> 2. If there is RAS, KVM set "the kvm_run" gues

Re: [PATCH v3 15/20] KVM: arm64: Set an impdef ESR for Virtual-SError using VSESR_EL2.

2017-10-16 Thread James Morse
Hi gengdongjiu, On 15/10/17 17:09, gengdongjiu wrote: >> On 13/10/17 10:25, gengdongjiu wrote: >>> In my first version patch [2], It sets the virtual ESR in the KVM, but >>> Marc and other people disagree that[3][4],and propose to set its value >>> and injection by userspace(when RAS is enabled).

Re: [PATCH v3 15/20] KVM: arm64: Set an impdef ESR for Virtual-SError using VSESR_EL2.

2017-10-18 Thread gengdongjiu
Hi James, Thanks for your mail. and very sorry for my late response. > > Hi gengdongjiu, > > On 15/10/17 17:09, gengdongjiu wrote: > >> On 13/10/17 10:25, gengdongjiu wrote: > >>> In my first version patch [2], It sets the virtual ESR in the KVM, > >>> but Marc and other people disagree that[