Re: [PATCH v3 2/2] KVM: arm64: Don't acquire RCU read lock for exclusive table walks

2022-11-18 Thread Oliver Upton
On Fri, Nov 18, 2022 at 12:19:50PM +, Will Deacon wrote: > On Thu, Nov 17, 2022 at 06:23:23PM +, Oliver Upton wrote: > > On Thu, Nov 17, 2022 at 05:49:52PM +, Will Deacon wrote: > > > On Wed, Nov 16, 2022 at 04:56:55PM +, Oliver Upton wrote: > > > > [...] > > > > > > -static inlin

Re: [PATCH v3 2/2] KVM: arm64: Don't acquire RCU read lock for exclusive table walks

2022-11-18 Thread Will Deacon
On Thu, Nov 17, 2022 at 06:23:23PM +, Oliver Upton wrote: > On Thu, Nov 17, 2022 at 05:49:52PM +, Will Deacon wrote: > > On Wed, Nov 16, 2022 at 04:56:55PM +, Oliver Upton wrote: > > [...] > > > > -static inline void kvm_pgtable_walk_begin(void) {} > > > -static inline void kvm_pgtabl

Re: [PATCH v3 2/2] KVM: arm64: Don't acquire RCU read lock for exclusive table walks

2022-11-17 Thread Oliver Upton
Hi Will, Thanks for having a look. On Thu, Nov 17, 2022 at 05:49:52PM +, Will Deacon wrote: > On Wed, Nov 16, 2022 at 04:56:55PM +, Oliver Upton wrote: [...] > > -static inline void kvm_pgtable_walk_begin(void) {} > > -static inline void kvm_pgtable_walk_end(void) {} > > +static inline

Re: [PATCH v3 2/2] KVM: arm64: Don't acquire RCU read lock for exclusive table walks

2022-11-17 Thread Will Deacon
On Wed, Nov 16, 2022 at 04:56:55PM +, Oliver Upton wrote: > Marek reported a BUG resulting from the recent parallel faults changes, > as the hyp stage-1 map walker attempted to allocate table memory while > holding the RCU read lock: > > BUG: sleeping function called from invalid context at

[PATCH v3 2/2] KVM: arm64: Don't acquire RCU read lock for exclusive table walks

2022-11-16 Thread Oliver Upton
Marek reported a BUG resulting from the recent parallel faults changes, as the hyp stage-1 map walker attempted to allocate table memory while holding the RCU read lock: BUG: sleeping function called from invalid context at include/linux/sched/mm.h:274 in_atomic(): 0, irqs_disabled(): 0, non