Re: [PATCH v5 1/4] KVM: stats: Separate common stats from architecture specific ones

2021-05-21 Thread Jing Zhang
On Tue, May 18, 2021 at 1:40 PM Krish Sadhukhan wrote: > > > On 5/18/21 10:25 AM, Jing Zhang wrote: > > Hi David, > > > > On Tue, May 18, 2021 at 11:27 AM David Matlack wrote: > >> On Mon, May 17, 2021 at 5:10 PM Jing Zhang wrote: > >> > >>> Actually the definition of kvm_{vcpu,vm}_stat are arc

Re: [PATCH v5 1/4] KVM: stats: Separate common stats from architecture specific ones

2021-05-18 Thread David Matlack
On Mon, May 17, 2021 at 5:10 PM Jing Zhang wrote: > Actually the definition of kvm_{vcpu,vm}_stat are arch specific. There is > no real structure for arch agnostic stats. Most of the stats in common > structures are arch agnostic, but not all of them. > There are some benefits to put all common s

Re: [PATCH v5 1/4] KVM: stats: Separate common stats from architecture specific ones

2021-05-18 Thread Jing Zhang
Hi David, On Tue, May 18, 2021 at 11:27 AM David Matlack wrote: > > On Mon, May 17, 2021 at 5:10 PM Jing Zhang wrote: > > > Actually the definition of kvm_{vcpu,vm}_stat are arch specific. There is > > no real structure for arch agnostic stats. Most of the stats in common > > structures are arc

Re: [PATCH v5 1/4] KVM: stats: Separate common stats from architecture specific ones

2021-05-18 Thread Krish Sadhukhan
On 5/18/21 10:25 AM, Jing Zhang wrote: Hi David, On Tue, May 18, 2021 at 11:27 AM David Matlack wrote: On Mon, May 17, 2021 at 5:10 PM Jing Zhang wrote: Actually the definition of kvm_{vcpu,vm}_stat are arch specific. There is no real structure for arch agnostic stats. Most of the stats i

Re: [PATCH v5 1/4] KVM: stats: Separate common stats from architecture specific ones

2021-05-18 Thread David Matlack
On Mon, May 17, 2021 at 9:24 AM Jing Zhang wrote: > > Put all common statistics in a separate structure to ease > statistics handling for the incoming new statistics API. > > No functional change intended. > > Signed-off-by: Jing Zhang > --- > arch/arm64/include/asm/kvm_host.h | 9 ++--- >

Re: [PATCH v5 1/4] KVM: stats: Separate common stats from architecture specific ones

2021-05-17 Thread Jing Zhang
Hi David, On Mon, May 17, 2021 at 6:39 PM David Matlack wrote: > > On Mon, May 17, 2021 at 9:24 AM Jing Zhang wrote: > > > > Put all common statistics in a separate structure to ease > > statistics handling for the incoming new statistics API. > > > > No functional change intended. > > > > Signe

[PATCH v5 1/4] KVM: stats: Separate common stats from architecture specific ones

2021-05-17 Thread Jing Zhang
Put all common statistics in a separate structure to ease statistics handling for the incoming new statistics API. No functional change intended. Signed-off-by: Jing Zhang --- arch/arm64/include/asm/kvm_host.h | 9 ++--- arch/arm64/kvm/guest.c | 12 ++-- arch/mips/in