Re: [PATCH v6 00/21] KVM: Add idempotent controls for migrating system counter state

2021-08-11 Thread Oliver Upton
On Wed, Aug 11, 2021 at 6:05 AM Paolo Bonzini wrote: > > On 04/08/21 10:57, Oliver Upton wrote: > > KVM's current means of saving/restoring system counters is plagued with > > temporal issues. At least on ARM64 and x86, we migrate the guest's > > system counter by-value through the respective

Re: [PATCH v6 00/21] KVM: Add idempotent controls for migrating system counter state

2021-08-11 Thread Marc Zyngier
On Wed, 11 Aug 2021 19:56:22 +0100, Oliver Upton wrote: [...] > > Time is ticking for 5.15 due to my vacation, I'll see if I have some > > time to look at it further next week. > > > > I agree that arm64 can be done separately from x86. > > Marc, just a disclaimer: > > I'm going to separate

Re: [PATCH v6 00/21] KVM: Add idempotent controls for migrating system counter state

2021-08-11 Thread Paolo Bonzini
On 04/08/21 10:57, Oliver Upton wrote: KVM's current means of saving/restoring system counters is plagued with temporal issues. At least on ARM64 and x86, we migrate the guest's system counter by-value through the respective guest system register values (cntvct_el0, ia32_tsc). Restoring system

Re: [PATCH v6 00/21] KVM: Add idempotent controls for migrating system counter state

2021-08-10 Thread Marc Zyngier
On Tue, 10 Aug 2021 01:04:38 +0100, Oliver Upton wrote: > > On Wed, Aug 4, 2021 at 3:03 PM Oliver Upton wrote: > > > > On Wed, Aug 4, 2021 at 4:05 AM Oliver Upton wrote: > > > > > > On Wed, Aug 4, 2021 at 1:58 AM Oliver Upton wrote: > > > > > > > > KVM's current means of saving/restoring

Re: [PATCH v6 00/21] KVM: Add idempotent controls for migrating system counter state

2021-08-09 Thread Oliver Upton
On Wed, Aug 4, 2021 at 3:03 PM Oliver Upton wrote: > > On Wed, Aug 4, 2021 at 4:05 AM Oliver Upton wrote: > > > > On Wed, Aug 4, 2021 at 1:58 AM Oliver Upton wrote: > > > > > > KVM's current means of saving/restoring system counters is plagued with > > > temporal issues. At least on ARM64 and

Re: [PATCH v6 00/21] KVM: Add idempotent controls for migrating system counter state

2021-08-04 Thread Oliver Upton
On Wed, Aug 4, 2021 at 4:05 AM Oliver Upton wrote: > > On Wed, Aug 4, 2021 at 1:58 AM Oliver Upton wrote: > > > > KVM's current means of saving/restoring system counters is plagued with > > temporal issues. At least on ARM64 and x86, we migrate the guest's > > system counter by-value through the

Re: [PATCH v6 00/21] KVM: Add idempotent controls for migrating system counter state

2021-08-04 Thread Oliver Upton
On Wed, Aug 4, 2021 at 1:58 AM Oliver Upton wrote: > > KVM's current means of saving/restoring system counters is plagued with > temporal issues. At least on ARM64 and x86, we migrate the guest's > system counter by-value through the respective guest system register > values (cntvct_el0,

[PATCH v6 00/21] KVM: Add idempotent controls for migrating system counter state

2021-08-04 Thread Oliver Upton
KVM's current means of saving/restoring system counters is plagued with temporal issues. At least on ARM64 and x86, we migrate the guest's system counter by-value through the respective guest system register values (cntvct_el0, ia32_tsc). Restoring system counters by-value is brittle as the state