Re: [PATCH v8 4/5] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes

2019-01-08 Thread Andrew Murray
On Tue, Jan 08, 2019 at 01:14:25PM +0100, Christoffer Dall wrote: > On Tue, Jan 08, 2019 at 11:25:13AM +, Andrew Murray wrote: > > On Tue, Jan 08, 2019 at 11:18:43AM +0100, Christoffer Dall wrote: > > > On Fri, Jan 04, 2019 at 03:32:06PM +, Will Deacon wrote: > > > > On Tue, Dec 18, 2018

Re: [PATCH v8 4/5] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes

2019-01-08 Thread Christoffer Dall
On Tue, Jan 08, 2019 at 12:12:13PM +, Marc Zyngier wrote: > On 08/01/2019 12:03, Christoffer Dall wrote: > > On Tue, Jan 08, 2019 at 11:50:59AM +, Marc Zyngier wrote: > >> On Tue, 08 Jan 2019 11:25:13 +, > >> Andrew Murray wrote: > >> > >> Hi Andrew, > >> > >>> My only doubt about

Re: [PATCH v8 4/5] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes

2019-01-08 Thread Christoffer Dall
On Tue, Jan 08, 2019 at 11:25:13AM +, Andrew Murray wrote: > On Tue, Jan 08, 2019 at 11:18:43AM +0100, Christoffer Dall wrote: > > On Fri, Jan 04, 2019 at 03:32:06PM +, Will Deacon wrote: > > > On Tue, Dec 18, 2018 at 01:02:26PM +0100, Christoffer Dall wrote: > > > > On Wed, Dec 12, 2018

Re: [PATCH v8 4/5] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes

2019-01-08 Thread Marc Zyngier
On 08/01/2019 12:03, Christoffer Dall wrote: > On Tue, Jan 08, 2019 at 11:50:59AM +, Marc Zyngier wrote: >> On Tue, 08 Jan 2019 11:25:13 +, >> Andrew Murray wrote: >> >> Hi Andrew, >> >>> My only doubt about this is as follows. If, on a KVM host you run this: >>> >>> perf stat -e cycles:H

Re: [PATCH v8 4/5] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes

2019-01-08 Thread Marc Zyngier
On Tue, 08 Jan 2019 11:25:13 +, Andrew Murray wrote: Hi Andrew, > My only doubt about this is as follows. If, on a KVM host you run this: > > perf stat -e cycles:H lkvm run ... > > then on the VHE host the cycles reported represents the entire non-guest > cycles > associated with running

Re: [PATCH v8 4/5] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes

2019-01-08 Thread Andrew Murray
On Tue, Jan 08, 2019 at 11:18:43AM +0100, Christoffer Dall wrote: > On Fri, Jan 04, 2019 at 03:32:06PM +, Will Deacon wrote: > > On Tue, Dec 18, 2018 at 01:02:26PM +0100, Christoffer Dall wrote: > > > On Wed, Dec 12, 2018 at 10:29:32AM +, Andrew Murray wrote: > > > > Add support for the :G

Re: [PATCH v8 4/5] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes

2019-01-08 Thread Christoffer Dall
On Fri, Jan 04, 2019 at 03:32:06PM +, Will Deacon wrote: > On Tue, Dec 18, 2018 at 01:02:26PM +0100, Christoffer Dall wrote: > > On Wed, Dec 12, 2018 at 10:29:32AM +, Andrew Murray wrote: > > > Add support for the :G and :H attributes in perf by handling the > > >

Re: [PATCH v8 4/5] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes

2019-01-04 Thread Will Deacon
On Tue, Dec 18, 2018 at 01:02:26PM +0100, Christoffer Dall wrote: > On Wed, Dec 12, 2018 at 10:29:32AM +, Andrew Murray wrote: > > Add support for the :G and :H attributes in perf by handling the > > exclude_host/exclude_guest event attributes. > > > > We notify KVM of counters that we wish

Re: [PATCH v8 4/5] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes

2018-12-18 Thread Andrew Jones
On Tue, Dec 18, 2018 at 07:51:21PM +0100, Christoffer Dall wrote: > On Tue, Dec 18, 2018 at 04:27:05PM +, Andrew Murray wrote: > > On Tue, Dec 18, 2018 at 03:38:33PM +0100, Christoffer Dall wrote: > > > On Tue, Dec 18, 2018 at 01:25:32PM +, Andrew Murray wrote: > > > > On Tue, Dec 18, 2018

Re: [PATCH v8 4/5] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes

2018-12-18 Thread Christoffer Dall
On Tue, Dec 18, 2018 at 04:27:05PM +, Andrew Murray wrote: > On Tue, Dec 18, 2018 at 03:38:33PM +0100, Christoffer Dall wrote: > > On Tue, Dec 18, 2018 at 01:25:32PM +, Andrew Murray wrote: > > > On Tue, Dec 18, 2018 at 01:02:26PM +0100, Christoffer Dall wrote: > > > > On Wed, Dec 12, 2018

Re: [PATCH v8 4/5] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes

2018-12-18 Thread Andrew Murray
On Tue, Dec 18, 2018 at 03:38:33PM +0100, Christoffer Dall wrote: > On Tue, Dec 18, 2018 at 01:25:32PM +, Andrew Murray wrote: > > On Tue, Dec 18, 2018 at 01:02:26PM +0100, Christoffer Dall wrote: > > > On Wed, Dec 12, 2018 at 10:29:32AM +, Andrew Murray wrote: > > > > Add support for the

Re: [PATCH v8 4/5] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes

2018-12-18 Thread Andrew Murray
On Tue, Dec 18, 2018 at 01:02:26PM +0100, Christoffer Dall wrote: > On Wed, Dec 12, 2018 at 10:29:32AM +, Andrew Murray wrote: > > Add support for the :G and :H attributes in perf by handling the > > exclude_host/exclude_guest event attributes. > > > > We notify KVM of counters that we wish

Re: [PATCH v8 4/5] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes

2018-12-18 Thread Christoffer Dall
On Wed, Dec 12, 2018 at 10:29:32AM +, Andrew Murray wrote: > Add support for the :G and :H attributes in perf by handling the > exclude_host/exclude_guest event attributes. > > We notify KVM of counters that we wish to be enabled or disabled on > guest entry/exit and thus defer from starting

Re: [PATCH v8 4/5] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes

2018-12-12 Thread Andrew Murray
On Wed, Dec 12, 2018 at 10:55:33AM +, Suzuki K Poulose wrote: > > > On 12/12/2018 10:29, Andrew Murray wrote: > > Add support for the :G and :H attributes in perf by handling the > > exclude_host/exclude_guest event attributes. > > > > We notify KVM of counters that we wish to be enabled or

Re: [PATCH v8 4/5] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes

2018-12-12 Thread Suzuki K Poulose
On 12/12/2018 10:29, Andrew Murray wrote: Add support for the :G and :H attributes in perf by handling the exclude_host/exclude_guest event attributes. We notify KVM of counters that we wish to be enabled or disabled on guest entry/exit and thus defer from starting or stopping :G events as

Re: [PATCH v8 4/5] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes

2018-12-12 Thread Suzuki K Poulose
On 12/12/2018 10:47, Julien Thierry wrote: On 12/12/2018 10:42, Suzuki K Poulose wrote: On 12/12/2018 10:29, Andrew Murray wrote: Add support for the :G and :H attributes in perf by handling the exclude_host/exclude_guest event attributes. We notify KVM of counters that we wish to be

Re: [PATCH v8 4/5] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes

2018-12-12 Thread Julien Thierry
On 12/12/2018 10:42, Suzuki K Poulose wrote: > > > On 12/12/2018 10:29, Andrew Murray wrote: >> Add support for the :G and :H attributes in perf by handling the >> exclude_host/exclude_guest event attributes. >> >> We notify KVM of counters that we wish to be enabled or disabled on >> guest

Re: [PATCH v8 4/5] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes

2018-12-12 Thread Suzuki K Poulose
On 12/12/2018 10:29, Andrew Murray wrote: Add support for the :G and :H attributes in perf by handling the exclude_host/exclude_guest event attributes. We notify KVM of counters that we wish to be enabled or disabled on guest entry/exit and thus defer from starting or stopping :G events as

[PATCH v8 4/5] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes

2018-12-12 Thread Andrew Murray
Add support for the :G and :H attributes in perf by handling the exclude_host/exclude_guest event attributes. We notify KVM of counters that we wish to be enabled or disabled on guest entry/exit and thus defer from starting or stopping :G events as per the events exclude_host attribute. With