Re: [PATCH v9 3/7] KVM: Support dirty ring in conjunction with bitmap

2022-11-10 Thread Gavin Shan
Hi Marc, On 11/10/22 6:25 PM, Marc Zyngier wrote: On Wed, 09 Nov 2022 00:51:21 +, Gavin Shan wrote: On 11/9/22 8:32 AM, Sean Christopherson wrote: That said, there're no remaining issues that can't be sorted out on top, so don't hold up v10 if I don't look at it in a timely manner for

Re: [PATCH v9 3/7] KVM: Support dirty ring in conjunction with bitmap

2022-11-10 Thread Marc Zyngier
Hi Gavin, On Wed, 09 Nov 2022 00:51:21 +, Gavin Shan wrote: > > On 11/9/22 8:32 AM, Sean Christopherson wrote: > > That said, there're no remaining issues that can't be sorted out > > on top, so don't hold up v10 if I don't look at it in a timely > > manner for whatever reason. I agree

Re: [PATCH v9 3/7] KVM: Support dirty ring in conjunction with bitmap

2022-11-08 Thread Gavin Shan
Hi Sean, On 11/9/22 8:32 AM, Sean Christopherson wrote: On Wed, Nov 09, 2022, Gavin Shan wrote: On 11/9/22 8:05 AM, Sean Christopherson wrote: On Wed, Nov 09, 2022, Gavin Shan wrote: On 11/9/22 12:25 AM, Sean Christopherson wrote: I have no objection to disallowing userspace from disabling

Re: [PATCH v9 3/7] KVM: Support dirty ring in conjunction with bitmap

2022-11-08 Thread Sean Christopherson
On Wed, Nov 09, 2022, Gavin Shan wrote: > Hi Sean, > > On 11/9/22 8:05 AM, Sean Christopherson wrote: > > On Wed, Nov 09, 2022, Gavin Shan wrote: > > > On 11/9/22 12:25 AM, Sean Christopherson wrote: > > > > I have no objection to disallowing userspace from disabling the combo, > > > > but I > >

Re: [PATCH v9 3/7] KVM: Support dirty ring in conjunction with bitmap

2022-11-08 Thread Gavin Shan
Hi Sean, On 11/9/22 8:05 AM, Sean Christopherson wrote: On Wed, Nov 09, 2022, Gavin Shan wrote: On 11/9/22 12:25 AM, Sean Christopherson wrote: I have no objection to disallowing userspace from disabling the combo, but I think it's worth requiring cap->args[0] to be '0' just in case we change

Re: [PATCH v9 3/7] KVM: Support dirty ring in conjunction with bitmap

2022-11-08 Thread Sean Christopherson
On Wed, Nov 09, 2022, Gavin Shan wrote: > Hi Sean, > > On 11/9/22 12:25 AM, Sean Christopherson wrote: > > I have no objection to disallowing userspace from disabling the combo, but I > > think it's worth requiring cap->args[0] to be '0' just in case we change > > our minds > > in the future. >

Re: [PATCH v9 3/7] KVM: Support dirty ring in conjunction with bitmap

2022-11-08 Thread Gavin Shan
Hi Sean, On 11/9/22 12:25 AM, Sean Christopherson wrote: On Tue, Nov 08, 2022, Gavin Shan wrote: diff --git a/virt/kvm/Kconfig b/virt/kvm/Kconfig index 800f9470e36b..228be1145cf3 100644 --- a/virt/kvm/Kconfig +++ b/virt/kvm/Kconfig @@ -33,6 +33,14 @@ config HAVE_KVM_DIRTY_RING_ACQ_REL

Re: [PATCH v9 3/7] KVM: Support dirty ring in conjunction with bitmap

2022-11-08 Thread Sean Christopherson
On Tue, Nov 08, 2022, Gavin Shan wrote: > diff --git a/virt/kvm/Kconfig b/virt/kvm/Kconfig > index 800f9470e36b..228be1145cf3 100644 > --- a/virt/kvm/Kconfig > +++ b/virt/kvm/Kconfig > @@ -33,6 +33,14 @@ config HAVE_KVM_DIRTY_RING_ACQ_REL > bool > select HAVE_KVM_DIRTY_RING > >

[PATCH v9 3/7] KVM: Support dirty ring in conjunction with bitmap

2022-11-07 Thread Gavin Shan
ARM64 needs to dirty memory outside of a VCPU context when VGIC/ITS is enabled. It's conflicting with that ring-based dirty page tracking always requires a running VCPU context. Introduce a new flavor of dirty ring that requires the use of both VCPU dirty rings and a dirty bitmap. The expectation