Re: [RFC kvm-unit-tests PATCH 5/8] Makefile: add explicit mkdir for .o targets

2017-05-12 Thread Alex Bennée
Paolo Bonzini writes: > On 11/05/2017 17:30, Alex Bennée wrote: %.o: %.S + mkdir -p $(dir $@) >>> Should this use @ for cleanliness? >> > I'm not sure I follow. Did you mean use $(@D) directly? > > That too, but I was thinking of using "@mkdir" to avoid

Re: [RFC kvm-unit-tests PATCH 5/8] Makefile: add explicit mkdir for .o targets

2017-05-12 Thread Paolo Bonzini
On 11/05/2017 17:30, Alex Bennée wrote: >>> >>> %.o: %.S >>> + mkdir -p $(dir $@) >> Should this use @ for cleanliness? > > I'm not sure I follow. Did you mean use $(@D) directly? That too, but I was thinking of using "@mkdir" to avoid spamming the output with mkdir commands. Paolo

Re: [RFC kvm-unit-tests PATCH 5/8] Makefile: add explicit mkdir for .o targets

2017-05-11 Thread Alex Bennée
Paolo Bonzini writes: > On 06/04/2017 21:07, Alex Bennée wrote: >> This is fairly direct way of ensuring the target build directories are >> created before we build a binary blob. mkdir -p fails gracefully if >> the directory is already there. >> >> Signed-off-by: Alex

Re: [RFC kvm-unit-tests PATCH 5/8] Makefile: add explicit mkdir for .o targets

2017-04-27 Thread Paolo Bonzini
On 06/04/2017 21:07, Alex Bennée wrote: > This is fairly direct way of ensuring the target build directories are > created before we build a binary blob. mkdir -p fails gracefully if > the directory is already there. > > Signed-off-by: Alex Bennée > --- > Makefile | 5

Re: [RFC kvm-unit-tests PATCH 5/8] Makefile: add explicit mkdir for .o targets

2017-04-07 Thread Andrew Jones
On Thu, Apr 06, 2017 at 08:07:24PM +0100, Alex Bennée wrote: > This is fairly direct way of ensuring the target build directories are > created before we build a binary blob. mkdir -p fails gracefully if > the directory is already there. > > Signed-off-by: Alex Bennée >

[RFC kvm-unit-tests PATCH 5/8] Makefile: add explicit mkdir for .o targets

2017-04-06 Thread Alex Bennée
This is fairly direct way of ensuring the target build directories are created before we build a binary blob. mkdir -p fails gracefully if the directory is already there. Signed-off-by: Alex Bennée --- Makefile | 5 + 1 file changed, 5 insertions(+) diff --git