[kvm-unit-tests PATCH 1/3] arm: pmu: Fix overflow checks for PMUv3p5 long counters

2022-12-01 Thread Ricardo Koller
PMUv3p5 uses 64-bit counters irrespective of whether the PMU is configured for overflowing at 32 or 64-bits. The consequence is that tests that check the counter values after overflowing should not assume that values will be wrapped around 32-bits: they overflow into the other half of the 64-bit co

Re: [kvm-unit-tests PATCH 1/3] arm: pmu: Fix overflow checks for PMUv3p5 long counters

2022-12-09 Thread Alexandru Elisei
Hi, On Fri, Dec 02, 2022 at 04:55:25AM +, Ricardo Koller wrote: > PMUv3p5 uses 64-bit counters irrespective of whether the PMU is configured > for overflowing at 32 or 64-bits. The consequence is that tests that check > the counter values after overflowing should not assume that values will be

Re: [kvm-unit-tests PATCH 1/3] arm: pmu: Fix overflow checks for PMUv3p5 long counters

2022-12-10 Thread Marc Zyngier
On Fri, 09 Dec 2022 17:47:14 +, Alexandru Elisei wrote: > > Hi, > > On Fri, Dec 02, 2022 at 04:55:25AM +, Ricardo Koller wrote: > > PMUv3p5 uses 64-bit counters irrespective of whether the PMU is configured > > for overflowing at 32 or 64-bits. The consequence is that tests that check >

Re: [kvm-unit-tests PATCH 1/3] arm: pmu: Fix overflow checks for PMUv3p5 long counters

2022-12-11 Thread Alexandru Elisei
Hi Marc, On Sat, Dec 10, 2022 at 11:01:53AM +, Marc Zyngier wrote: > On Fri, 09 Dec 2022 17:47:14 +, > Alexandru Elisei wrote: > > > > Hi, > > > > On Fri, Dec 02, 2022 at 04:55:25AM +, Ricardo Koller wrote: > > > PMUv3p5 uses 64-bit counters irrespective of whether the PMU is config

Re: [kvm-unit-tests PATCH 1/3] arm: pmu: Fix overflow checks for PMUv3p5 long counters

2022-12-12 Thread Marc Zyngier
Alex, On Sun, 11 Dec 2022 11:40:39 +, Alexandru Elisei wrote: > > A simple "hey, you're wrong here, the PMU extensions do not follow the > principles of the ID scheme for fields in ID registers" would have > sufficed. This is what I did, and saved you the hassle of looking it up. > Guess y

Re: [kvm-unit-tests PATCH 1/3] arm: pmu: Fix overflow checks for PMUv3p5 long counters

2022-12-12 Thread Alexandru Elisei
Hi, On Mon, Dec 12, 2022 at 09:05:02AM +, Marc Zyngier wrote: > Alex, > > On Sun, 11 Dec 2022 11:40:39 +, > Alexandru Elisei wrote: > > > > A simple "hey, you're wrong here, the PMU extensions do not follow the > > principles of the ID scheme for fields in ID registers" would have > > s

Re: [kvm-unit-tests PATCH 1/3] arm: pmu: Fix overflow checks for PMUv3p5 long counters

2022-12-12 Thread Ricardo Koller
On Fri, Dec 09, 2022 at 05:47:14PM +, Alexandru Elisei wrote: > Hi, > > On Fri, Dec 02, 2022 at 04:55:25AM +, Ricardo Koller wrote: > > PMUv3p5 uses 64-bit counters irrespective of whether the PMU is configured > > for overflowing at 32 or 64-bits. The consequence is that tests that check

Re: [kvm-unit-tests PATCH 1/3] arm: pmu: Fix overflow checks for PMUv3p5 long counters

2022-12-13 Thread Alexandru Elisei
Hi, Some more comments below. On Fri, Dec 02, 2022 at 04:55:25AM +, Ricardo Koller wrote: > PMUv3p5 uses 64-bit counters irrespective of whether the PMU is configured > for overflowing at 32 or 64-bits. The consequence is that tests that check > the counter values after overflowing should not

Re: [kvm-unit-tests PATCH 1/3] arm: pmu: Fix overflow checks for PMUv3p5 long counters

2022-12-13 Thread Ricardo Koller
On Tue, Dec 13, 2022 at 12:36:14PM +, Alexandru Elisei wrote: > Hi, > > Some more comments below. > > On Fri, Dec 02, 2022 at 04:55:25AM +, Ricardo Koller wrote: > > PMUv3p5 uses 64-bit counters irrespective of whether the PMU is configured > > for overflowing at 32 or 64-bits. The conseq

Re: [kvm-unit-tests PATCH 1/3] arm: pmu: Fix overflow checks for PMUv3p5 long counters

2022-12-13 Thread Alexandru Elisei
Hi, On Tue, Dec 13, 2022 at 08:21:24AM -0800, Ricardo Koller wrote: > On Tue, Dec 13, 2022 at 12:36:14PM +, Alexandru Elisei wrote: > > Hi, > > > > Some more comments below. > > > > On Fri, Dec 02, 2022 at 04:55:25AM +, Ricardo Koller wrote: > > > PMUv3p5 uses 64-bit counters irrespectiv

Re: [kvm-unit-tests PATCH 1/3] arm: pmu: Fix overflow checks for PMUv3p5 long counters

2022-12-13 Thread Ricardo Koller
On Tue, Dec 13, 2022 at 04:43:38PM +, Alexandru Elisei wrote: > Hi, > > On Tue, Dec 13, 2022 at 08:21:24AM -0800, Ricardo Koller wrote: > > On Tue, Dec 13, 2022 at 12:36:14PM +, Alexandru Elisei wrote: > > > Hi, > > > > > > Some more comments below. > > > > > > On Fri, Dec 02, 2022 at 04

Re: [kvm-unit-tests PATCH 1/3] arm: pmu: Fix overflow checks for PMUv3p5 long counters

2022-12-14 Thread Alexandru Elisei
Hi, On Tue, Dec 13, 2022 at 10:01:06AM -0800, Ricardo Koller wrote: > On Tue, Dec 13, 2022 at 04:43:38PM +, Alexandru Elisei wrote: > > Hi, > > > > On Tue, Dec 13, 2022 at 08:21:24AM -0800, Ricardo Koller wrote: > > > On Tue, Dec 13, 2022 at 12:36:14PM +, Alexandru Elisei wrote: > > > > H

Re: [kvm-unit-tests PATCH 1/3] arm: pmu: Fix overflow checks for PMUv3p5 long counters

2022-12-14 Thread Ricardo Koller
On Wed, Dec 14, 2022 at 10:46:05AM +, Alexandru Elisei wrote: > Hi, > > On Tue, Dec 13, 2022 at 10:01:06AM -0800, Ricardo Koller wrote: > > On Tue, Dec 13, 2022 at 04:43:38PM +, Alexandru Elisei wrote: > > > Hi, > > > > > > On Tue, Dec 13, 2022 at 08:21:24AM -0800, Ricardo Koller wrote: >