Re: [kvm-unit-tests PATCH 6/6] run_tests: allow passing of options to QEMU

2017-01-17 Thread Alex Bennée
Paolo Bonzini writes: > On 12/01/2017 18:32, Andrew Jones wrote: >>> >>> +# Any options left for QEMU? >>> +shift $((OPTIND-1)) >>> +if [ "$#" -gt 0 ]; then >>> +extra_opts="$@" >>> +fi >> We can unconditionally do the extra_opts="$@", extra_opts will just >> be null

Re: [kvm-unit-tests PATCH 6/6] run_tests: allow passing of options to QEMU

2017-01-12 Thread Paolo Bonzini
On 12/01/2017 18:32, Andrew Jones wrote: >> >> +# Any options left for QEMU? >> +shift $((OPTIND-1)) >> +if [ "$#" -gt 0 ]; then >> +extra_opts="$@" >> +fi > We can unconditionally do the extra_opts="$@", extra_opts will just > be null in the case there aren't more args, like it was

Re: [kvm-unit-tests PATCH 6/6] run_tests: allow passing of options to QEMU

2017-01-12 Thread Andrew Jones
On Wed, Jan 11, 2017 at 04:28:41PM +, Alex Bennée wrote: > This allows additional options to be passed to QEMU. It follows the > convention of passing parameters after a -- to the child process. In > my case I'm using it to toggle MTTCG on an off: > > ./run_tests.sh -- --accel

Re: [kvm-unit-tests PATCH 6/6] run_tests: allow passing of options to QEMU

2017-01-12 Thread Paolo Bonzini
On 11/01/2017 17:28, Alex Bennée wrote: > This allows additional options to be passed to QEMU. It follows the > convention of passing parameters after a -- to the child process. In > my case I'm using it to toggle MTTCG on an off: > > ./run_tests.sh -- --accel tcg,thread=multi > >

[kvm-unit-tests PATCH 6/6] run_tests: allow passing of options to QEMU

2017-01-11 Thread Alex Bennée
This allows additional options to be passed to QEMU. It follows the convention of passing parameters after a -- to the child process. In my case I'm using it to toggle MTTCG on an off: ./run_tests.sh -- --accel tcg,thread=multi Signed-off-by: Alex Bennée --- v1 -