Re: The SENT_END challenge

2014-08-10 Thread Juan Martorell
Thank you for your answer, Jaume. On 9 August 2014 11:30, Jaume OrtolĂ  i Font jaumeort...@gmail.com wrote: Hi, A possible and simple solution is to write two rules. One for sentences with ending punctuation: pattern marker token regexp=yes(you|thei|ou)r/token

[RFC][PATCH] Add analyzed token readings to failed bad sentence test output

2014-08-10 Thread Silvan Jegen
If a rule test fails because no error has been found in the bad example sentence, one of the reason can be that the tokenization of the bad sentence example does not match the expected one in the rule itself. To identify these cases more easily, add the token readings to the assertion message.

Re: [RFC][PATCH] Add analyzed token readings to failed bad sentence test output

2014-08-10 Thread Daniel Naber
On 2014-08-10 17:37, Silvan Jegen wrote: If including the analyzed token readings is useful in other assertion messages as well, it may also be better to refactor the token reading code into its own function and making it less ad hoc. What do you think ? Thanks, I have committed your

chunks in exceptions

2014-08-10 Thread Andriy Rysin
Hi all I was writing a rule were I had to catch a phrase with last word being noun, but only if that noun is not part of adverb chunk (with another word following). The best way to do that seems to use adverb chunk in exception but looks like this is not supported. So after multiple experiments