[LARTC] Re: [PATCH] HTB O(1) class lookup

2007-02-08 Thread Jarek Poplawski
On Mon, Feb 05, 2007 at 06:14:13PM +0100, Simon Lodal wrote: ... > Regards ... It seems decisions makers need more time, so I'd add 2 cents more: 1c: an indentation could be improved (spaces around operators), like in these places: >+#define HTB_MAX_CLS (TC_H_MIN(-1)+1) ... >+ ht

[LARTC] Re: [PATCH] HTB O(1) class lookup

2007-02-08 Thread Jarek Poplawski
On Mon, Feb 05, 2007 at 06:14:13PM +0100, Simon Lodal wrote: > On Monday 05 February 2007 11:16, Jarek Poplawski wrote: > > On 01-02-2007 12:30, Andi Kleen wrote: > > > Simon Lodal <[EMAIL PROTECTED]> writes: > > >> Memory is generally not an issue, but CPU is, and you can not beat the > > >> CPU e

[LARTC] Re: [PATCH] HTB O(1) class lookup

2007-02-05 Thread Simon Lodal
On Thursday 01 February 2007 12:30, Andi Kleen wrote: > Simon Lodal <[EMAIL PROTECTED]> writes: > > Memory is generally not an issue, but CPU is, and you can not beat the > > CPU efficiency of plain array lookup (always faster, and constant time). > > Actually that's not true when the array doesn't

[LARTC] Re: [PATCH] HTB O(1) class lookup

2007-02-05 Thread Simon Lodal
On Monday 05 February 2007 11:16, Jarek Poplawski wrote: > On 01-02-2007 12:30, Andi Kleen wrote: > > Simon Lodal <[EMAIL PROTECTED]> writes: > >> Memory is generally not an issue, but CPU is, and you can not beat the > >> CPU efficiency of plain array lookup (always faster, and constant time). > >

[LARTC] Re: [PATCH] HTB O(1) class lookup

2007-02-05 Thread Jarek Poplawski
On 01-02-2007 12:30, Andi Kleen wrote: > Simon Lodal <[EMAIL PROTECTED]> writes: >> Memory is generally not an issue, but CPU is, and you can not beat the CPU >> efficiency of plain array lookup (always faster, and constant time). Probably for some old (or embedded) lean boxes used for small netw

[LARTC] Re: [PATCH] HTB O(1) class lookup

2007-02-03 Thread Simon Lodal
On Thursday 01 February 2007 07:08, Patrick McHardy wrote: > Simon Lodal wrote: > > This patch changes HTB's class storage from hash+lists to a two-level > > linear array, so it can do constant time (O(1)) class lookup by classid. > > It improves scalability for large number of classes. > > > > Wit

[LARTC] Re: [PATCH] HTB O(1) class lookup

2007-02-03 Thread Patrick McHardy
Simon Lodal wrote: > This patch changes HTB's class storage from hash+lists to a two-level linear > array, so it can do constant time (O(1)) class lookup by classid. It improves > scalability for large number of classes. > > Without the patch, ~14k htb classes can starve a Xeon-3.2 at only 15kpp