[Launchpad-reviewers] [Merge] ~pelpsi/lpcraft:backward-compatibility into lpcraft:main

2023-04-06 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/lpcraft:backward-compatibility into lpcraft:main. Commit message: Forced classic to True if snaps are configured as string If snaps are configured as string the classic confinment is forced to improve backward compatibility Requested reviews: Lau

[Launchpad-reviewers] [Merge] ~pelpsi/lpcraft:backward-compatibility into lpcraft:main

2023-04-06 Thread Jürgen Gmach
The proposal to merge ~pelpsi/lpcraft:backward-compatibility into lpcraft:main has been updated. Commit message changed to: Forced classic to True if snaps are configured as string If snaps are configured as string the classic confinement is forced to improve backward compatibility For more de

[Launchpad-reviewers] [Merge] ~cjwatson/lpcraft:docs-snap-proofreading into lpcraft:main

2023-04-06 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/lpcraft:docs-snap-proofreading into lpcraft:main. Commit message: Fix some typos in snap properties documentation Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/lpcraft/+

[Launchpad-reviewers] [Merge] ~pelpsi/lpcraft:release-0.0.52 into lpcraft:main

2023-04-06 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/lpcraft:release-0.0.52 into lpcraft:main. Commit message: New lpcraft release 0.0.52 Fix regression from adding support to snap keys passed as strings. For these keys confinement classic must be True by default to ensure backward compatibility. Re

Re: [Launchpad-reviewers] [Merge] ~cjwatson/lpcraft:release-command into lpcraft:main

2023-04-06 Thread Dan Ryan
Review: Approve I don't have any major concerns with the API design, I've been using this for some time now and it works as expected. I gave the proposal a cursory read and nothing jumped out at me either. Thanks! -- https://code.launchpad.net/~cjwatson/lpcraft/+git/lpcraft/+merge/435280 Your t

[Launchpad-reviewers] [Merge] ~ines-almeida/launchpad:update-package-diff-title-property into launchpad:master

2023-04-06 Thread Ines Almeida
Ines Almeida has proposed merging ~ines-almeida/launchpad:update-package-diff-title-property into launchpad:master. Commit message: Update PackageDiff.title Use archive.reference instead of archive.distribution in the title of a package diff Requested reviews: Launchpad code reviewers (laun

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:duplicate_ci_jobs into launchpad:master

2023-04-06 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:duplicate_ci_jobs into launchpad:master. Commit message: Stages now depend on series Stages now is a dictionary where each key corresponds to the series and the value is the old stages array. Requested reviews: Launchpad code reviewers

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-layers:xmlrpc-private-port into launchpad-layers:main

2023-04-06 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-layers:xmlrpc-private-port into launchpad-layers:main. Commit message: Set private_port for the xmlrpc_private vhost Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwat