Barry Price has proposed merging ~barryprice/launchpad/+git/launchpad:master
into launchpad:master.
Commit message:
launchpad-ppa-uploader crontab: Clean up rejected packages more aggressively to
conserve disk space
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more
Ines Almeida has proposed merging
~ines-almeida/launchpad:update-copyright-date-across-launchpad into
launchpad:master.
Commit message:
Remove date range from copyright note from lib/lp/code folder
This is an on going process to remove all instances of date ranges in copyright
notes from
Diff comments:
> diff --git a/lp-fetch-service/bundle.yaml b/lp-fetch-service/bundle.yaml
> new file mode 100644
> index 000..286
> --- /dev/null
> +++ b/lp-fetch-service/bundle.yaml
> @@ -0,0 +1,22 @@
> +{%- if stage_name == "production" %}
> +{%- set devel = False %}
> +{%- elif
Ines Almeida has proposed merging
~ines-almeida/launchpad-mojo-specs/+git/private:lp-fetch-service into
launchpad-mojo-specs:master.
Commit message:
Add barebones of lp-fetch-service mojo spec
While the charm and snap are not public, they require manually building, and
deploying from the
The proposal to merge
~ines-almeida/launchpad-mojo-specs/+git/private:lp-fetch-service into
launchpad-mojo-specs:master has been updated.
Description changed to:
This was tested deploying locally. Will try deploying in staging once this MP
is reviewed and approved.
The general structure was
Thank you all for the comments!
@petermakowski
Regarding impact on SEO, I ran lighthouse in the master branch and this one and
the scores are exactly identical (unfortunately, not incredibly high).
For reference, the scores were:
- Performance: 36
- Accessibility: 76
- Best pratices: 68
-
> These are the same links, right?
Yes, probably a copy-paste error, updated the links now
--
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/460819
Your team Launchpad code reviewers is requested to review the proposed merge of
Updated as requested. Unfortunatelly, some of the blog posts initially linked
are no longer available. But I believe the explanation + knowing this was
agreed with the legal team should suffice.
--
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/460944
Your team
The proposal to merge
~ines-almeida/launchpad:update-copyright-date-across-launchpad into
launchpad:master has been updated.
Commit message changed to:
Remove date range from copyright note in user-facing places
This is no longer necessary and only creates extra work once a year.
Canonical's
The proposal to merge
~ines-almeida/launchpad:update-copyright-date-across-launchpad into
launchpad:master has been updated.
Commit message changed to:
Remove date range from copyright note in user-facing places
This is no longer necessary and only creates extra work once a year.
Canonical's
The proposal to merge
~ines-almeida/launchpad:update-copyright-date-across-launchpad into
launchpad:master has been updated.
Description changed to:
Note that in this MP we are not updating the copyright message in every code
file, only the ones more user facing.
Discussion about this topic:
The proposal to merge
~ines-almeida/launchpad:update-copyright-date-across-launchpad into
launchpad:master has been updated.
Commit message changed to:
Remove date range from copyright note in user-facing places
This is no longer necessary and only creates extra work once a year (see for
Your commit message tells the what, but not the why. Could you please add a
reason why we do this? If you could find a link to the discussion we had would
be awesome (to this MP, not to the commit message). I think there were also a
couple of blog posts out there discussing why this makes
The proposal to merge
~ines-almeida/launchpad:update-copyright-date-across-launchpad into
launchpad:master has been updated.
Commit message changed to:
Remove date range from copyright note in user-facing places
For more details, see:
Ines Almeida has proposed merging
~ines-almeida/launchpad:update-copyright-date-across-launchpad into
launchpad:master.
Commit message:
Update Canonical Copyright message from 2004-2023 to 2004-2024 in the frontend
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more
The proposal to merge
~ines-almeida/launchpad:update-copyright-date-across-launchpad into
launchpad:master has been updated.
Status: Rejected => Superseded
For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/460927
--
Your team Launchpad code
The proposal to merge
~ines-almeida/launchpad:update-copyright-date-across-launchpad into
launchpad:master has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/460927
--
Your team Launchpad code
Philip Roche has proposed merging
~philroche/launchpad:feature/dont-expire-security-proposed-ppa into
launchpad:master.
Commit message:
feat: Don't expire Ubuntu Security Proposed PPA
This archive is used for many security builds and to ensure further support for
our
reproducible builds
*
- Annoynymous person (after): https://postimg.cc/21CmQF6P
- Logged in person (after): https://postimg.cc/21CmQF6P
*
These are the same links, right?
--
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/460819
Your team Launchpad code reviewers is
Diff comments:
> diff --git a/lib/lp/app/templates/root-index.pt
> b/lib/lp/app/templates/root-index.pt
> index ee51d55..2a6ffcf 100644
> --- a/lib/lp/app/templates/root-index.pt
> +++ b/lib/lp/app/templates/root-index.pt
> @@ -6,48 +6,7 @@
>metal:use-macro="view/macro:page/main_only"
>
> Could you also update copyright string? (from 2004-2023 to 2004-2024)
Done in a separate MP:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/460927
--
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/460819
Your team Launchpad code reviewers is
Ines Almeida has proposed merging
~ines-almeida/launchpad:update-copyright-date-across-launchpad into
launchpad:master.
Commit message:
Update Canonical Copyright message from 2004-2023 to 2004-2024 in the frontend
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more
It looks good! Could you also update copyright string? (from 2004-2023 to
2004-2024)
--
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/460819
Your team Launchpad code reviewers is requested to review the proposed merge of
A few screenshots:
- Annonymous person (before): https://postimg.cc/MX4vm42g
- Annoynymous person (after): https://postimg.cc/21CmQF6P
- Logged in person (after): https://postimg.cc/21CmQF6P
These screenshots were taken before removing the "See more..."
button, but the remaining should look
24 matches
Mail list logo
