Thank you Ines! Done,
https://git.launchpad.net/~launchpad/+git/dbpatches/commit/?id=fd495590ef1c9867bf861b22b18f90ebfed22412
--
https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/473368
Your team Launchpad code reviewers is requested to review the proposed merge of
~pelpsi/launc
Simone Pelosi has proposed merging
~pelpsi/launchpad:fetch-service-configuration-for-rock-builds into
launchpad:master.
Commit message:
Fetch service configuration for Rock builds
Integrate use_fetch_service flag to activate or deactivate fetch service
for a given rock recipe.
Requested re
The proposal to merge
~jugmac00/launchpad:fix-missing-rock-build-related-permissions into
launchpad:master has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/473391
--
Your team Launchpad code revie
The proposal to merge
~jugmac00/launchpad:fix-missing-rock-build-related-permissions into
launchpad:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/473391
--
Your team Launchpad code revie
```
jugmac00@lpdev:~/launchpad/launchpad$ make schema && bin/test -vcct test_rock
...
Total: 98 tests, 0 failures, 0 errors, 0 skipped in 1 minutes 50.604 seconds.
jugmac00@lpdev:~/launchpad/launchpad$
```
All rock related tests pass. The other two failing tests from
http://lpbuildbot.canonical.
Jürgen Gmach has proposed merging
~jugmac00/launchpad:fix-missing-rock-build-related-permissions into
launchpad:master.
Commit message:
Fix (more) missing permissions for rock build related changes
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Jürgen Gmach has proposed merging
~jugmac00/launchpad:fix-permission-issue-for-rockfiles into launchpad:master.
Commit message:
Fix missing permission for rockfile
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/lau
Thanks for the review! I was not aware how pre-requisite MPs work in detail
when I created this MP, so I missed to set one for this MP. As you noticed, the
last commit has the relevant changes. I spoke with Guruprasad about that, and
he mentioned that it is not necessary to recreate the MP, as y
Thanks for the feedback!
I hope I was able to address all your concerns. I will also update the commit
message when I rebase.
Diff comments:
> diff --git a/lib/lp/rocks/adapters/buildarch.py
> b/lib/lp/rocks/adapters/buildarch.py
> index 7f0cd5a..d2a1569 100644
> --- a/lib/lp/rocks/adapters/bu
Don't forget to allocate your patch in
https://code.launchpad.net/~launchpad/+git/dbpatches
See 'how to/make a database patch' documentation:
https://documentation.ubuntu.com/launchpad/en/latest/how-to/database-schema-changes-process/#making-a-database-patch
The patch itself looks good!
Diff c
Simone Pelosi has proposed merging
~pelpsi/launchpad:add-fetch-service-column-to-RockRecipe into
launchpad:db-devel.
Commit message:
Add use_fetch_service column to RockRecipe
This variable will be use to activate the fetch-service for this recipe.
Requested reviews:
Launchpad code revie
Diff comments:
> diff --git a/lpbuildd/target/apt.py b/lpbuildd/target/apt.py
> index 3f9ddca..d99e041 100644
> --- a/lpbuildd/target/apt.py
> +++ b/lpbuildd/target/apt.py
> @@ -13,6 +14,66 @@ from lpbuildd.target.operation import Operation
> logger = logging.getLogger(__name__)
>
>
> +def
Simone Pelosi has proposed merging ~pelpsi/launchpad:fix-rock-api-doc into
launchpad:master with ~jugmac00/launchpad:add-webservice-api-for-rock-changes
as a prerequisite.
Commit message:
Fix Rock API doc
These changes fix the URL entry point displayed on the generated
documentation.
Req
Diff comments:
> diff --git a/lpbuildd/target/apt.py b/lpbuildd/target/apt.py
> index 3f9ddca..d99e041 100644
> --- a/lpbuildd/target/apt.py
> +++ b/lpbuildd/target/apt.py
> @@ -13,6 +14,66 @@ from lpbuildd.target.operation import Operation
> logger = logging.getLogger(__name__)
>
>
> +def
Review: Approve
lgtm
--
https://code.launchpad.net/~pelpsi/launchpad-buildd/+git/launchpad-buildd/+merge/473136
Your team Launchpad code reviewers is requested to review the proposed merge of
~pelpsi/launchpad-buildd:deb822-support into launchpad-buildd:master.
Jürgen Gmach has proposed merging
~jugmac00/launchpad:add-explicit-model-for-rock-bases into launchpad:master
with ~jugmac00/launchpad:add-webservice-api-for-rock-changes as a prerequisite.
Commit message:
[WIP] Add explicit model for rock bases
Requested reviews:
Launchpad code reviewers (la
16 matches
Mail list logo
