Re: [Launchpad-reviewers] [Merge] ~cjwatson/lpcraft:release-command into lpcraft:main

2023-04-06 Thread Dan Ryan
Review: Approve I don't have any major concerns with the API design, I've been using this for some time now and it works as expected. I gave the proposal a cursory read and nothing jumped out at me either. Thanks! -- https://code.launchpad.net/~cjwatson/lpcraft/+git/lpcraft/+merge/435280 Your

Re: [Launchpad-reviewers] [Merge] ~pelpsi/lpcraft:lpcraft-conda-build-plugin-is-overly-aggressive into lpcraft:main

2023-04-05 Thread Dan Ryan
Review: Approve this looks like an elegant solution to the problem, thanks for tackling it! -- https://code.launchpad.net/~pelpsi/lpcraft/+git/lpcraft/+merge/440025 Your team Launchpad code reviewers is requested to review the proposed merge of

Re: [Launchpad-reviewers] [Merge] ~jugmac00/launchpad:converge-naming-for-package-repositories into launchpad:master

2022-08-16 Thread Dan Ryan
Review: Approve one question about the config file access (do you need more error handling around that?) but otherwise looks good to me Diff comments: > diff --git a/lib/lp/code/model/cibuildbehaviour.py > b/lib/lp/code/model/cibuildbehaviour.py > index 726bb80..a3e2439 100644 > ---

Re: [Launchpad-reviewers] [Merge] ~jugmac00/launchpad-buildd:provide-additional-repositories-instead-of-replacing-them into launchpad-buildd:master

2022-08-16 Thread Dan Ryan
Review: Approve this change makes sense to me -- I don't see any immediate concerns as this is largely a variable/argument name change as long as the other pieces are merged with it -- https://code.launchpad.net/~jugmac00/launchpad-buildd/+git/launchpad-buildd/+merge/428410 Your team Launchpad