Review: Approve
I don't have any major concerns with the API design, I've been using this for
some time now and it works as expected. I gave the proposal a cursory read and
nothing jumped out at me either. Thanks!
--
https://code.launchpad.net/~cjwatson/lpcraft/+git/lpcraft/+merge/435280
Your
Review: Approve
this looks like an elegant solution to the problem, thanks for tackling it!
--
https://code.launchpad.net/~pelpsi/lpcraft/+git/lpcraft/+merge/440025
Your team Launchpad code reviewers is requested to review the proposed merge of
Review: Approve
one question about the config file access (do you need more error handling
around that?)
but otherwise looks good to me
Diff comments:
> diff --git a/lib/lp/code/model/cibuildbehaviour.py
> b/lib/lp/code/model/cibuildbehaviour.py
> index 726bb80..a3e2439 100644
> ---
Review: Approve
this change makes sense to me -- I don't see any immediate concerns as this is
largely a variable/argument name change as long as the other pieces are merged
with it
--
https://code.launchpad.net/~jugmac00/launchpad-buildd/+git/launchpad-buildd/+merge/428410
Your team Launchpad
4 matches
Mail list logo