Guruprasad has proposed merging
~lgp171188/launchpad:update-ppa-signing-key-garbo-job-add-logging into
launchpad:master.
Commit message:
Add debug logging to the UpdatePPASigningKeyFingerprintToRSA4096Key garbo job
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more
The proposal to merge
~tushar5526/launchpad-mojo-specs/+git/private:add-config-to-build-noble-images
into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder has been updated.
Status: Needs review => Approved
For more details, see:
Review: Approve
LGTM
--
https://code.launchpad.net/~tushar5526/launchpad-mojo-specs/+git/private/+merge/470180
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
___
Mailing list:
Guruprasad has proposed merging
~lgp171188/launchpad:serve-rsa4096-when-archive-also-has-rsa1024-key into
launchpad:master.
Commit message:
Add a garbo job to switch the served signing key fingerprint of PPAs
When a PPA has an rsa1024 signing key and rsa4096 signing key, this job
will update
Note: This should be deployed only after all the affected archives have been
republished and dual-signed.
--
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/470160
Your team Launchpad code reviewers is requested to review the proposed merge of
Guruprasad has proposed merging
~lgp171188/launchpad:fix-ppa-key-updater-default-ppa-fingerprint-none-or-missing-in-gpgkey-table
into launchpad:master.
Commit message:
Add error handling when recursively trying to update the default PPA's signing
key
This handles unexpected situations like
Guruprasad has proposed merging
~lgp171188/launchpad:signing-service-proxy-typo-fix into launchpad:master.
Commit message:
Fix a typo in SigningServiceClient.sign
Also add tests for the SigningServiceClient to verify
the recent changes to this method.
Requested reviews:
Launchpad code
Guruprasad has proposed merging
~lgp171188/launchpad:update-publisher-multi-sign-archive-when-multiple-keys-available
into launchpad:master.
Commit message:
Sign the archive with all its OpenPGP signing keys
If an archive has more than one OpenPGP signing key, sign the archive's
metadata
Guruprasad has proposed merging
~lgp171188/launchpad:set-up-ppa-update-keys-cronscript into launchpad:master.
Commit message:
charm/launchpad-ppa-publisher: Add the PPA key updater cron job
Also use a unique name for the ppa-update-keys cron script,
Requested reviews:
Launchpad code
Guruprasad has proposed merging
~lgp171188/launchpad:update-bing-custom-search-site-url into launchpad:master.
Commit message:
Update Bing custom search site URL
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~lgp171188
Guruprasad has proposed merging
~lgp171188/launchpad:allow-setting-bing-custom-search-endpoint-launchpad-appserver-charm
into launchpad:master.
Commit message:
charm/launchpad-appserver: Make the bing custom search endpoint configurable
This allows us to update it without requiring any code
> about 2h, if you're curious - it was usually more like 9h on my old laptop by
> the time I left Canonical
It took ~6h hour on my 5-year-old laptop (8th-gen mobile i5) when I tried it
many months ago. So it looks like the cumulative generation-over-generation
improvements are significant
Review: Approve
Diff comments:
> diff --git a/lp-fetch-service/README.md b/lp-fetch-service/README.md
> new file mode 100644
> index 000..65e09cb
> --- /dev/null
> +++ b/lp-fetch-service/README.md
> @@ -0,0 +1,21 @@
> +# Launchpad fetch service
> +
> +This spec deploys Launchpad's fetch
Guruprasad has proposed merging
~lgp171188/launchpad:fix-launchpad-codehosting-config-changed-handler-when_any-instead-of-when
into launchpad:master.
Commit message:
charm/launchpad-codehosting: Use the when_any decorator for
config.changed.
This should fix the bug and allow the handler
Diff comments:
> diff --git a/lib/lp/app/templates/root-index.pt
> b/lib/lp/app/templates/root-index.pt
> index ee51d55..2a6ffcf 100644
> --- a/lib/lp/app/templates/root-index.pt
> +++ b/lib/lp/app/templates/root-index.pt
> @@ -6,48 +6,7 @@
>metal:use-macro="view/macro:page/main_only"
>
Guruprasad has proposed merging
~lgp171188/lpci:fix-snapcraft-bug-build-error-snapcraft-8.x into lpci:main.
Commit message:
Fix the build error with snapcraft 8.x
There was a bug in the sitecustomize.py file bundled with the lpci snap,
which caused the build process to depend on the version
Guruprasad has proposed merging
~lgp171188/lpci:fix-snapcraft-build-error-snapcraft-8.x into lpci:main.
Commit message:
Fix the build error with snapcraft 8.x
snapcraft 8.x is built on core22 while 7.x was built on core20, which is
the same base used by lpci. Due to this change and possible bug
The proposal to merge ~lgp171188/lp-source-dependencies:add-waitress-2.1.2 into
lp-source-dependencies:master has been updated.
Description changed to:
Related Launchpad MP -
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/459895
For more details, see:
Guruprasad has proposed merging
~lgp171188/lp-source-dependencies:add-waitress-2.1.2 into
lp-source-dependencies:master.
Commit message:
Add waitress 2.1.2
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~lgp171188/lp
The proposal to merge
~lgp171188/lp-source-dependencies:remove-unused-versions-of-pyyaml into
lp-source-dependencies:master has been updated.
Description changed to:
For more details, see:
https://code.launchpad.net/~lgp171188/lp-source-dependencies/+git/lp-source-dependencies/+merge/459893
The proposal to merge
~lgp171188/launchpad:upgrade-waitress-to-2.1.2-critical-security-fix into
launchpad:master has been updated.
Description changed to:
Related lp-source-dependencies MP -
https://code.launchpad.net/~lgp171188/lp-source-dependencies/+git/lp-source-dependencies/+merge/459896
Guruprasad has proposed merging
~lgp171188/launchpad:upgrade-waitress-to-2.1.2-critical-security-fix into
launchpad:master.
Commit message:
Upgrade waitress to 2.1.2 to fix multiple security issues
See
https://docs.pylonsproject.org/projects/waitress/en/latest/index.html#change-history
The proposal to merge
~lgp171188/lp-source-dependencies:remove-unused-versions-of-pyyaml into
lp-source-dependencies:master has been updated.
Description changed to:
Related Launchpad MP -
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/459895
For more details, see:
Guruprasad has proposed merging
~lgp171188/lp-source-dependencies:remove-unused-versions-of-pyyaml into
lp-source-dependencies:master.
Commit message:
Remove PyYAML 5.3.1 and 5.4.1
These are not used any more
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more
Guruprasad has proposed merging
~lgp171188/launchpad:pin-black-version-used-by-blackdoc into launchpad:master.
Commit message:
Pin the version of black used by the blackdoc pre-commit hook
... to the same version as the one used by the black pre-commit
hook.
Requested reviews:
Launchpad code
Related Launchpad requirements update MP -
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/459491
--
https://code.launchpad.net/~lgp171188/lp-source-dependencies/+git/lp-source-dependencies/+merge/459490
Your team Launchpad code reviewers is requested to review the proposed
Guruprasad has proposed merging ~lgp171188/launchpad:update-pyyaml-6.0.1 into
launchpad:master.
Commit message:
Upgrade PyYAML to 6.0.1
This pulls in a few critical security fixes and is possible because we
no longer depend on Python 3.5.
Requested reviews:
Launchpad code reviewers
Related lp-source-dependencies MP -
https://code.launchpad.net/~lgp171188/lp-source-dependencies/+git/lp-source-dependencies/+merge/459490
--
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/459491
Your team Launchpad code reviewers is requested to review the proposed merge
Guruprasad has proposed merging
~lgp171188/lp-source-dependencies:update-pyyaml-6.0.1 into
lp-source-dependencies:master.
Commit message:
Add PyYAML 6.0.1
We can do this now that we do not support Python 3.5 any more and pull
in the security fix for CVE-2020-1747.
Requested reviews
Guruprasad has proposed merging
~lgp171188/launchpad:fix-social-accounts-class-to-not-trigger-adblocker into
launchpad:master.
Commit message:
Update social accounts' elements' class names
The previous 'social_accounts*' class names were getting blocked by the
ad blockers.
Requested reviews
Guruprasad has proposed merging
~lgp171188/launchpad:fix-homeserver-domain-validation into launchpad:master.
Commit message:
Fix the matrix homeserver domain validation regex
The previous regex did not allow some valid TLDs like the
2-character-long ones.
Requested reviews:
Launchpad code
Diff comments:
> diff --git a/lib/lp/registry/browser/person.py
> b/lib/lp/registry/browser/person.py
> index 8f044fd..139b687 100644
> --- a/lib/lp/registry/browser/person.py
> +++ b/lib/lp/registry/browser/person.py
> @@ -2417,6 +2425,84 @@ class
> Given we don't want to add new `rst` tests, I can't base the tests on other
> social accounts, which means it will take a little longer to create them. I
> can focus on that tomorrow...
For browser and UI changes, I'd say that it is an okay compromise to write
doctests unless the alternative
Left a small comment. Don't forget to add appropriate tests.
Diff comments:
> diff --git a/lib/lp/app/browser/tales.py b/lib/lp/app/browser/tales.py
> index eb5cad2..9ec03a3 100644
> --- a/lib/lp/app/browser/tales.py
> +++ b/lib/lp/app/browser/tales.py
> @@ -3049,3 +3050,32 @@ class
Don't forget to add appropriate tests!
--
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/458537
Your team Launchpad code reviewers is requested to review the proposed merge of
~ines-almeida/launchpad:social-accounts-edit-view into launchpad:master.
Left a few minor comments/questions/suggestions. Will approve once they have
been addressed. Nice work!
Diff comments:
> diff --git a/lib/lp/registry/browser/person.py
> b/lib/lp/registry/browser/person.py
> index 8f044fd..139b687 100644
> --- a/lib/lp/registry/browser/person.py
> +++
> This adds a new view:
> https://launchpad.net/~/+editsocialaccounts-matrix
Don't forget to update the URL in this MP's commit message before merging. :)
--
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/458537
Your team Launchpad code reviewers is requested to review
Guruprasad has proposed merging
~lgp171188/launchpad:update-haproxy-relations-when-config-changes into
launchpad:master.
Commit message:
charm/launchpad-codehosting: Reconfigure haproxy relations on config changes
When a configuration variable used by an haproxy relation changes,
reconfigure
Guruprasad has proposed merging
~lgp171188/launchpad:codehosting-charm-https-vhost-config-fixes into
launchpad:master.
Commit message:
charm/launchpad-codehosting: Fix a bug in the bzr https vhost config
When renaming all the previous occurrences of
'codebrowse_internal_endpoint
Guruprasad has proposed merging
~lgp171188/launchpad:add-archivepublisher-role-ftpmaster-publisher-charm into
launchpad:master.
Commit message:
charm/launchpad-ftpmaster-publisher: Add archivepublisher DB role
This is used by the `scripts/populate-archive.py` script.
Requested reviews
Guruprasad has proposed merging
~lgp171188/launchpad:codehosting-charm-fix-cron-job-whitespace-typo into
launchpad:master.
Commit message:
charm/codehosting: Fix a typo in the supermirror-pull cron job
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see
Guruprasad has proposed merging
~lgp171188/launchpad:add-modified-branches-role-codehosting-charm into
launchpad:master.
Commit message:
charm/launchpad-codehosting: Add the 'modified-branches' role
Guruprasad has proposed merging
~lgp171188/launchpad:charm-launchpad-codehosting-block-on-required-config-options
into launchpad:master.
Commit message:
charm/launchpad-codehosting: Block on required configuration options
Also replace remove_state with clear_flag.
Requested reviews
Guruprasad has proposed merging ~lgp171188/launchpad:fix-data-dir-typo-readme
into launchpad:master.
Commit message:
charm/launchpad-codehosting: Fix typos in the README
The bzr repositories root directory was wrongly mentioned as
`/srv/launchpad/data/mirror` instead of `/srv/launchpad/data
The proposal to merge
~lgp171188/launchpad:charm-codehosting-simplify-cert-configuration into
launchpad:master has been updated.
Commit message changed to:
charm/launchpad-codehosting: Simplify TLS certification configuration
We do not need any value other than 'DEFAULT' for the `crts` list
Guruprasad has proposed merging
~lgp171188/launchpad:charm-codehosting-simplify-cert-configuration into
launchpad:master.
Commit message:
charm/launchpad-codehosting: Simplify TLS certification configuration
We do not need any value other than 'DEFAULT' `crts` list passed to the load
balancer
Guruprasad has proposed merging
~lgp171188/launchpad:update-codehosting-ssh-public-port into launchpad:master.
Commit message:
charm: Update the bzr sftp port to 5022 and make it configurable
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Guruprasad has proposed merging
~lgp171188/launchpad:charm-launchpad-codehosting into launchpad:master.
Commit message:
Add a launchpad-codehosting charm
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~lgp171188/launchpad
Note: This charm doesn't yet integrate with an haproxy instance that sits in
front of the `codehosting-apache2` charm, the `bzr-sftp` services, and the
`codebrowse` charm.
Also, I have only tested that the charm deploys without any errors and the
services start and run. I have to set up a bzr
Diff comments:
> diff --git
> a/charm/launchpad-codehosting/templates/launchpad-codehosting-secrets-lazr.conf.j2
>
> b/charm/launchpad-codehosting/templates/launchpad-codehosting-secrets-lazr.conf.j2
> new file mode 100644
TODO: Determine if any configuration needs to be in this file. If
Jürgen, the upstream PR has been merged and the maintainer published a new
release, 0.4, which allows us to upgrade Sphinx and remove all the pins. Can
you re-review?
--
https://code.launchpad.net/~lgp171188/rutabaga/+git/rutabaga/+merge/452819
Your team Launchpad code reviewers is requested to
Diff comments:
> diff --git a/setup.py b/setup.py
> index da1216e..59a1567 100644
> --- a/setup.py
> +++ b/setup.py
> @@ -20,16 +20,24 @@ requires = [
> 'PyYAML',
> 'waitress',
> ]
> +docs_requires = [
> +'cornice',
> +'cornice_sphinx',
> +'docutils<0.18',
> +
Guruprasad has proposed merging ~lgp171188/rutabaga:add-readthedocs-yaml into
rutabaga:master.
Commit message:
Add a .readthedocs.yaml configuration file
And add tox.ini to build the docs using tox
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see
Guruprasad has proposed merging
~lgp171188/launchpad:allow-distribution-bug-supervisor-to-create-structural-subscriptions
into launchpad:master.
Commit message:
Allow the distribution bug supervisor to add structural subscriptions
Guruprasad has proposed merging
~lgp171188/launchpad:drop-bionic-readline-mock-for-tests into launchpad:master.
Commit message:
Drop the readline mock in the test environment for bionic
Guruprasad has proposed merging
~lgp171188/launchpad:update-launchpad-layers-58edb3e5a88794c3baa2274a94e21d3a298a6c79
into launchpad:master.
Commit message:
charm: Update launchpad-layers to 58edb3e5a8
This pulls in a couple of improvements.
06169f9fa1 upload-queue-processor: Turn fsroot
Guruprasad has proposed merging ~lgp171188/launchpad-layers:add-scripts-dir
into launchpad-layers:main.
Commit message:
Add a 'scripts_dir' well-known directory
This can be used for placing scripts that are not in
the Launchpad source tree.
Requested reviews:
Launchpad code reviewers
The proposal to merge ~lgp171188/launchpad:remove-unused-demo-charm-code into
launchpad:master has been updated.
Commit message changed to:
charm/launchpad: Remove unused charm code
For more details, see:
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/452219
--
Your
Guruprasad has proposed merging
~lgp171188/launchpad:remove-unused-demo-charm-code into launchpad:master.
Commit message:
charm/launchpad: Remove the unused charm code
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
Guruprasad has proposed merging
~lgp171188/launchpad:fix-snaps-description-new-snap-page into launchpad:master.
Commit message:
Update the description for snaps in the new snap page
Use the description that is currently in https://snapcraft.io/docs.
LP: #2037033
Requested reviews
The proposal to merge ~lgp171188/launchpad:fix-snaps-description-new-snap-page
into launchpad:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/451926
--
Your team Launchpad code
Guruprasad has proposed merging
~lgp171188/launchpad:fix-snaps-description-new-snap-page into launchpad:master.
Commit message:
Update the description for snaps in the new snap page
Use the description that is currently in https://snapcraft.io/docs.
LP: #2037033
Requested reviews
Guruprasad has proposed merging ~lgp171188/launchpad:export-IMessage.visible
into launchpad:master.
Commit message:
Export IMessage.visible in the web service
And remove the downstream exports.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Guruprasad has proposed merging
~lgp171188/launchpad:launchpad-scripts-fix-sync-librarian-logs into
launchpad:master.
Commit message:
charm/launchpad-scripts: Pre-create the directories for sync-librarian-logs
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more
Diff comments:
> diff --git a/docs/development.rst b/docs/development.rst
> index aeb1b72..150ad9a 100644
> --- a/docs/development.rst
> +++ b/docs/development.rst
> @@ -1,35 +1,56 @@
> Development
> ===
>
> +Prerequisites
> +-
> +
> +* LXD is installed and set up. See
> Could you please update the commit message and say "why" you did these
> changes?
Jürgen, I have updated the git commit messages with some explanation now.
--
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/448673
Your team Launchpad code reviewers is requested to
Guruprasad has proposed merging
~lgp171188/turnip:revamp-development-environment-setup-docs into turnip:master.
Commit message:
Revamp the development environment setup docs
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
Guruprasad has proposed merging ~lgp171188/launchpad:make-lp-user-improvements
into launchpad:master.
Commit message:
Add the following improvements to the `make-lp-user` script
* Support looking for ed25519 SSH keys and importing them.
* Disable sending email on importing an SSH key
Guruprasad has proposed merging
~lgp171188/launchpad:add-extra-config-bzrsyncd-celerybeat into launchpad:master.
Commit message:
charm/launchpad-scripts-bzrsyncd: Add missing config to the celerybeat service
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details
Guruprasad has proposed merging
~lgp171188/launchpad:launchpad-scripts-bzrsyncd-fix-typo-celerybeat-service
into launchpad:master.
Commit message:
charm/launchpad-scripts-bzrsyncd: Fix a typo in the celerybeat service name
Requested reviews:
Launchpad code reviewers (launchpad-reviewers
Guruprasad has proposed merging
~lgp171188/launchpad:charm-bzrsyncd-tie-celery-services-to-active-flag into
launchpad:master.
Commit message:
charm/launchpad-scripts-bzrsyncd: Control celery services using juju
... configuration parameter `active`.
Requested reviews:
Launchpad code
Guruprasad has proposed merging
~lgp171188/launchpad:launchpad-scripts-charm-fixes into launchpad:master.
Commit message:
charm/launchpad-scripts: Fix issues found during production deployment
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Guruprasad has proposed merging
~lgp171188/launchpad:tie-celery-services-to-active-flag into launchpad:master.
Commit message:
charm/launchpad-scripts: Control systemd services using the juju 'active' config
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details
Diff comments:
> diff --git a/lib/canonical/launchpad/icing/style.css
> b/lib/canonical/launchpad/icing/style.css
> index 125f723..04dd339 100644
> --- a/lib/canonical/launchpad/icing/style.css
> +++ b/lib/canonical/launchpad/icing/style.css
> @@ -663,12 +692,18 @@ table.diff .line-no.active,
Guruprasad has proposed merging
~lgp171188/launchpad:launchpad-scripts-configuration-enable-debian-bugs-mirroring
into launchpad:master.
Commit message:
charm/launchpad-scripts: Add configuration to enable Debian bugs mirror
Requested reviews:
Launchpad code reviewers (launchpad-reviewers
Guruprasad has proposed merging ~lgp171188/lpci:release-0.2.3 into lpci:main.
Commit message:
Prepare release 0.2.3
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~lgp171188/lpci/+git/lpcraft/+merge/447295
--
Your team
Diff comments:
> diff --git a/doc/tutorials/creating-a-page-in-launchpad.rst
> b/doc/tutorials/creating-a-page-in-launchpad.rst
> new file mode 100644
> index 000..81e7853
> --- /dev/null
> +++ b/doc/tutorials/creating-a-page-in-launchpad.rst
> @@ -0,0 +1,120 @@
>
Guruprasad has proposed merging
~lgp171188/launchpad:tutorial-creating-a-new-page-in-launchpad into
launchpad:master.
Commit message:
Add a tutorial for creating a new page in Launchpad
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Guruprasad has proposed merging ~lgp171188/lpci:pin-upgrade-pyyaml into
lpci:main.
Commit message:
Pin PyYAML to >= 6.0.1 and upgrade it to 6.0.1
This fixes an issue caused by an unpinned `Cython` dependency in
`PyYAML`.
Requested reviews:
Launchpad code reviewers (launchpad-review
Guruprasad has proposed merging
~lgp171188/launchpad:launchpad-scripts-extra-volume-manual-steps into
launchpad:master.
Commit message:
charm/launchpad-scripts: Document the manual steps to setup a volume
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details
Diff comments:
> diff --git a/doc/explanation/performance.rst b/doc/explanation/performance.rst
> new file mode 100644
> index 000..578973a
> --- /dev/null
> +++ b/doc/explanation/performance.rst
> @@ -0,0 +1,73 @@
> +About Launchpad performance
> +===
> +
> +This
Guruprasad has proposed merging
~lgp171188/launchpad:launchpad-scripts-run-process-mail-when-configured into
launchpad:master.
Commit message:
charm/launchpad-scripts: Run the process-mail script only if the required
configuration is present
Requested reviews:
Launchpad code reviewers
Guruprasad has proposed merging
~lgp171188/launchpad-bastion-scripts:add-launchpad-scripts into
launchpad-bastion-scripts:main.
Commit message:
Add changes for the launchpad-scripts charm
And use spaces instead of tabs for indentation.
Requested reviews:
Launchpad code reviewers (launchpad
Diff comments:
> diff --git a/charm/launchpad-scripts/templates/crontab.j2
> b/charm/launchpad-scripts/templates/crontab.j2
> index d0c0072..cdcc68e 100644
> --- a/charm/launchpad-scripts/templates/crontab.j2
> +++ b/charm/launchpad-scripts/templates/crontab.j2
> @@ -31,7 +31,7 @@
Guruprasad has proposed merging ~lgp171188/launchpad:tweak-debbugs-sync-script
into launchpad:master.
Commit message:
Make the destination directory configurable in the debbugs-sync script
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Review: Approve
LGTM
--
https://code.launchpad.net/~cjwatson/lpbuildbot/remove-bionic/+merge/446728
Your team Launchpad code reviewers is subscribed to branch lp:lpbuildbot.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to :
Guruprasad has proposed merging
~lgp171188/launchpad:charm-launchpad-scripts-add-missing-role into
launchpad:master.
Commit message:
charm/launchpad-scripts: Add a missing database role needed by the charm
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details
Guruprasad has proposed merging ~lgp171188/txpkgupload:add-launchpad-logo-charm
into txpkgupload:master.
Commit message:
charm: Add the Launchpad logo to the charm
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~lgp171188
Guruprasad has proposed merging
~lgp171188/launchpad:launchpad-scripts-bzrsyncd-fix-actions into
launchpad:master.
Commit message:
charm/launchpad-scripts-bzrsyncd: Fix the broken actions
Make the actions.py script executable and make the 'start-services'
and the 'stop-services' actions
Diff comments:
> diff --git a/Makefile b/Makefile
> index 55d04d0..bc69913 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -105,8 +109,7 @@ clean: clean_pip
> build-tarball:
> @echo "Creating deployment tarball at $(TARBALL_BUILD_PATH)"
> rm -rf $(ENV)
> - $(MAKE) $(ENV)
> -
Diff comments:
> diff --git a/charm/launchpad-scripts-bzrsyncd/charmcraft.yaml
> b/charm/launchpad-scripts-bzrsyncd/charmcraft.yaml
> new file mode 100644
> index 000..9b28632
> --- /dev/null
> +++ b/charm/launchpad-scripts-bzrsyncd/charmcraft.yaml
> @@ -0,0 +1,63 @@
> +type: charm
>
Guruprasad has proposed merging
~lgp171188/launchpad:charm-launchpad-scripts-bzrsyncd into launchpad:master.
Commit message:
charm: Implement the launchpad-scripts-bzrsyncd charm
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Guruprasad has proposed merging
~lgp171188/launchpad-layers:update-turnip-base-launchpad-icon into
launchpad-layers:main.
Commit message:
turnip-base: Use the new Launchpad icon
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Diff comments:
> diff --git a/lib/lp/bugs/subscribers/bugactivity.py
> b/lib/lp/bugs/subscribers/bugactivity.py
> index c036186..d1d1bc8 100644
> --- a/lib/lp/bugs/subscribers/bugactivity.py
> +++ b/lib/lp/bugs/subscribers/bugactivity.py
> @@ -66,6 +66,10 @@ def
Done.
--
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/444926
Your team Launchpad code reviewers is requested to review the proposed merge of
~lgp171188/launchpad:check-teamparticipation-teammembership-dbuser into
launchpad:master.
The proposal to merge
~lgp171188/launchpad:check-teamparticipation-teammembership-dbuser into
launchpad:master has been updated.
Commit message changed to:
Use the teammembership dbuser in the check-teamparticipation.py script
All similar cron scripts have an explicit database user and only
Guruprasad has proposed merging
~lgp171188/launchpad:check-teamparticipation-teammembership-dbuser into
launchpad:master.
Commit message:
Use the teammembership dbuser in the check-teamparticipation.py script
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details
Left some suggestions and questions.
Diff comments:
> diff --git a/doc/how-to/create-job-publish-artifact.rst
> b/doc/how-to/create-job-publish-artifact.rst
> new file mode 100644
> index 000..5f641f9
> --- /dev/null
> +++ b/doc/how-to/create-job-publish-artifact.rst
> @@ -0,0 +1,71 @@
> +
On lunar, a command like 'bzr branch lp:lptools' has been failing with an error
like 'brz: ERROR: Not a branch:
"git+ssh://lgp171...@git.launchpad.net/lptools": Repository 'lptools' not
found..'. I have reported a bug for it -
https://bugs.launchpad.net/ubuntu/+source/breezy/+bug/2023998.
Review: Approve
LGTM
--
https://code.launchpad.net/~cjwatson/launchpad/+git/security/+merge/444818
Your team Launchpad code reviewers is subscribed to branch
~cjwatson/launchpad/+git/security:suppress-orm-addresses.
___
Mailing list:
1 - 100 of 334 matches
Mail list logo
