Simone Pelosi has proposed merging
~pelpsi/launchpad:update-package-test-regression into launchpad:master.
Commit message:
Test regression due log level changed in update_pkgcache.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
The proposal to merge
~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charm-rev-20 into
~launchpad/launchpad-mojo-specs/+git/private:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/private/
Simone Pelosi has proposed merging
~pelpsi/launchpad:update-pkgcache-log-finished-process into launchpad:master.
Commit message:
Update pkgcache process should log into info
If the process logs into debug we will not see important logs
inside the log file.
Requested reviews:
Launchpad
Simone Pelosi has proposed merging
~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charm-rev-20 into
~launchpad/launchpad-mojo-specs/+git/private:master.
Commit message:
fetch-service: bump charm rev to 20
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more
Simone Pelosi has proposed merging
~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charm-131 into
~launchpad/launchpad-mojo-specs/+git/private:master.
Commit message:
fetch-service: bump charm to rev 131.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more
Simone Pelosi has proposed merging ~pelpsi/launchpad-buildd:release-246 into
launchpad-buildd:master.
Commit message:
Release version 246
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-buildd/+git
The proposal to merge
~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charm-bump-to-rev-19
into ~launchpad/launchpad-mojo-specs/+git/private:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/
The proposal to merge
~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charm-bump-to-rev-19
into ~launchpad/launchpad-mojo-specs/+git/private:master has been updated.
Commit message changed to:
fetch-service: bump fetch-service charm rev to 19.
fetch-service: snap bump to 112.
For more
Simone Pelosi has proposed merging
~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charm-bump-to-rev-19
into ~launchpad/launchpad-mojo-specs/+git/private:master.
Commit message:
fetch-service: bump fetch-service charm rev to 19.
Requested reviews:
Launchpad code reviewers (launchpad
Simone Pelosi has proposed merging
~pelpsi/launchpad:fix-lpbuildbot-propagate-launchpad-context into
launchpad:master.
Commit message:
Add new variables to extra build args
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
The proposal to merge
~pelpsi/launchpad-mojo-specs/+git/private:bump-fetch-service-to-111-prod into
~launchpad/launchpad-mojo-specs/+git/private:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/priv
Simone Pelosi has proposed merging
~pelpsi/launchpad-mojo-specs/+git/private:bump-fetch-service-to-111-prod into
~launchpad/launchpad-mojo-specs/+git/private:master.
Commit message:
fetch-service: bump to 111 on prod.
Requested reviews:
Canonical Launchpad Engineering (launchpad)
For more
The proposal to merge
~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-bump-111-qastaging into
~launchpad/launchpad-mojo-specs/+git/private:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/pr
Simone Pelosi has proposed merging
~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-bump-111-qastaging into
~launchpad/launchpad-mojo-specs/+git/private:master.
Commit message:
fetch-service: bump revision to 111 on qastaging and devel.
Requested reviews:
Canonical Launchpad
Simone Pelosi has proposed merging
~pelpsi/launchpad-buildd:GOPROXY-and-CARGOHTTPCAINFO-configuration into
launchpad-buildd:master.
Commit message:
Configure GOPROXY and CARGO_HTTP_CAINFO if fetch service
These env variables should be in place for every build type if
the fetch service is
Review: Approve
Looks great!
--
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/475601
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
___
Mailing li
It looks great! Wait before merging, we should sync with the team :)
--
https://code.launchpad.net/~alvarocs/launchpad/+git/launchpad/+merge/475412
Your team Launchpad code reviewers is requested to review the proposed merge of
~alvarocs/launchpad:add-lp-templates-db into launchpad:db-devel.
_
Review: Approve
Looks great!
--
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/475536
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
___
Mailing li
Simone Pelosi has proposed merging
~pelpsi/launchpad-buildd:propagate-launchpad-context-to-the-builders into
launchpad-buildd:master.
Commit message:
Builders should be aware of the Launchpad context
Propagate the launchpad context to the builders,
LAUNCHPAD_INSTANCE and
Simone Pelosi has proposed merging
~pelpsi/launchpad:propagate-launchpad-context-to-builders into launchpad:master.
Commit message:
Propagate launchpad context to builders
This change is required in order to use the correct craft URLs.
The starcraft team will set the craft urls accordingly
Review: Approve
Looks good!
--
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/475515
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
___
Mailing lis
The proposal to merge
~pelpsi/launchpad-mojo-specs/+git/private:inspectors-configuration-fetch-service
into ~launchpad/launchpad-mojo-specs/+git/private:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+
Simone Pelosi has proposed merging
~pelpsi/launchpad-mojo-specs/+git/private:inspectors-configuration-fetch-service
into ~launchpad/launchpad-mojo-specs/+git/private:master.
Commit message:
fetch-service: added inspectors config.
Requested reviews:
Canonical Launchpad Engineering (launchpad
Simone Pelosi has proposed merging ~pelpsi/launchpad-buildd:release-245 into
launchpad-buildd:master.
Commit message:
Release version 245
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-buildd/+git
Review: Approve
Looks great!
--
https://code.launchpad.net/~lgp171188/launchpad-mojo-specs/+git/private/+merge/474710
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
___
Mailing list:
Simone Pelosi has proposed merging
~pelpsi/launchpad-buildd:fetch-service-implementation-for-sourcecraft into
launchpad-buildd:master.
Commit message:
Fetch service configuration for Sourcecraft builds
Integrate use_fetch_service flag to activate or deactivate fetch service
for a given
Simone Pelosi has proposed merging
~pelpsi/launchpad-buildd:shallow-git-clone-if-fetch-service into
launchpad-buildd:master.
Commit message:
If fetch-service is active use shallow git clone
Current builds with the fetch-service enabled would fail as the git
inspector of the fetch-service
The proposal to merge ~pelpsi/launchpad-buildd:deb822-extend-supported-options
into launchpad-buildd:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-buildd/+git/launchpad-buildd/+merge/474613
--
Your team Launchpa
The proposal to merge ~pelpsi/launchpad-buildd:deb822-extend-supported-options
into launchpad-buildd:master has been updated.
Commit message changed to:
Extend the supported deb options
There was a regression due the unsupported Trusted option.
For more details, see:
https://code.launchpad.net
Simone Pelosi has proposed merging
~pelpsi/launchpad-buildd:deb822-extend-supported-options into
launchpad-buildd:master.
Commit message:
Extend the supported deb options
There was a regression due the unsopported Trusted option.
Requested reviews:
Launchpad code reviewers (launchpad
Simone Pelosi has proposed merging ~pelpsi/launchpad-buildd:release-244 into
launchpad-buildd:master.
Commit message:
Release version 244
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-buildd/+git
Simone Pelosi has proposed merging ~pelpsi/launchpad-buildd:fix-rm-apt-cache
into launchpad-buildd:master.
Commit message:
Use rm -rf /var/lib/apt/lists instead ../lists/*
The * is silently failing and the cache is not deleted properly.
Requested reviews:
Launchpad code reviewers
Simone Pelosi has proposed merging
~pelpsi/launchpad-buildd:apt-fetch-service-initialization into
launchpad-buildd:master.
Commit message:
APT should use the proxy when run
In order to activate the proxy with apt we have to create the proxy
configuration inside /etc/apt/apt.conf.d/99proxy
Diff comments:
> diff --git a/lpbuildd/target/build_rock.py b/lpbuildd/target/build_rock.py
> index 2da488c..6eeb312 100644
> --- a/lpbuildd/target/build_rock.py
> +++ b/lpbuildd/target/build_rock.py
> @@ -76,7 +87,14 @@ class BuildRock(
> "python3-setuptools",
> ]
Diff comments:
> diff --git a/lpbuildd/target/build_rock.py b/lpbuildd/target/build_rock.py
> index 2da488c..6eeb312 100644
> --- a/lpbuildd/target/build_rock.py
> +++ b/lpbuildd/target/build_rock.py
> @@ -76,7 +87,14 @@ class BuildRock(
> "python3-setuptools",
> ]
Diff comments:
> diff --git a/lpbuildd/target/build_rock.py b/lpbuildd/target/build_rock.py
> index 2da488c..6eeb312 100644
> --- a/lpbuildd/target/build_rock.py
> +++ b/lpbuildd/target/build_rock.py
> @@ -76,7 +87,14 @@ class BuildRock(
> "python3-setuptools",
> ]
Simone Pelosi has proposed merging
~pelpsi/launchpad-buildd:fetch-service-apt-initialization into
launchpad-buildd:master.
Commit message:
APT should use the proxy when run
Fetch service env variables should be in place and passed as env when
apt runs. In this way the fetch-service is
Simone Pelosi has proposed merging ~pelpsi/launchpad-buildd:deb822-rm-force-fix
into launchpad-buildd:master.
Commit message:
Use -f when remove files
If the file doesn't not exist the command shouldn't fail.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Diff comments:
> diff --git a/lpbuildd/target/build_snap.py b/lpbuildd/target/build_snap.py
> index cfdf5ad..4e8962f 100644
> --- a/lpbuildd/target/build_snap.py
> +++ b/lpbuildd/target/build_snap.py
> @@ -171,6 +171,7 @@ class BuildSnap(
> self.install_snapd_proxy(proxy_url=self.a
Simone Pelosi has proposed merging
~pelpsi/launchpad-buildd:fix-buildproxy-invocation-for-snaps into
launchpad-buildd:master.
Commit message:
snap: pass use_fetch_service flag to build_proxy_environment
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see
Simone Pelosi has proposed merging
~pelpsi/launchpad:add-support-for-bare-base-for-rock-builds into
launchpad:master.
Commit message:
Rockcraft build supports bare base
When base is set to bare in the rockcraft.yaml configuration file,
the build-base key becomes mandatory, and is evaluated
Simone Pelosi has proposed merging ~pelpsi/launchpad-buildd:changelog-fix into
launchpad-buildd:master.
Commit message:
Fix changelog entries.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-buildd/+git
Simone Pelosi has proposed merging ~pelpsi/launchpad-buildd:release-243 into
launchpad-buildd:master.
Commit message:
Release version 243
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-buildd/+git
The proposal to merge ~pelpsi/launchpad:fix-rock-api-doc into launchpad:master
has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/473362
--
Your team Launchpad code reviewers is requested to review the
Rebased MP:
https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/473627
--
https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/473362
Your team Launchpad code reviewers is requested to review the proposed merge of
~pelpsi/launchpad:fix-rock-api-doc into launchpad:mas
Simone Pelosi has proposed merging
~pelpsi/launchpad:rock-api-doc-fix-entry-points into launchpad:master.
Commit message:
Fix Rock API doc
These changes fix the URL entry point displayed on the generated
documentation.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For
> Looks good! Please document how you created those changes.
Thank you for the review! Should I create a documentation for that in a
separate PR (on github) or should I add comments there ?
--
https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/473362
Your team Launchpad code revi
Diff comments:
> diff --git a/lib/lp/rocks/tests/test_rockrecipebuildbehaviour.py
> b/lib/lp/rocks/tests/test_rockrecipebuildbehaviour.py
> index 88cea3a..3dcd1db 100644
> --- a/lib/lp/rocks/tests/test_rockrecipebuildbehaviour.py
> +++ b/lib/lp/rocks/tests/test_rockrecipebuildbehaviour.py
> @@
Thank you Ines! Done,
https://git.launchpad.net/~launchpad/+git/dbpatches/commit/?id=fd495590ef1c9867bf861b22b18f90ebfed22412
--
https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/473368
Your team Launchpad code reviewers is requested to review the proposed merge of
~pelpsi/launc
Simone Pelosi has proposed merging
~pelpsi/launchpad:fetch-service-configuration-for-rock-builds into
launchpad:master.
Commit message:
Fetch service configuration for Rock builds
Integrate use_fetch_service flag to activate or deactivate fetch service
for a given rock recipe.
Requested
The proposal to merge
~jugmac00/launchpad:fix-missing-rock-build-related-permissions into
launchpad:master has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/473391
--
Your team Launchpad code revie
The proposal to merge
~jugmac00/launchpad:fix-missing-rock-build-related-permissions into
launchpad:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/473391
--
Your team Launchpad code revie
Simone Pelosi has proposed merging
~pelpsi/launchpad:add-fetch-service-column-to-RockRecipe into
launchpad:db-devel.
Commit message:
Add use_fetch_service column to RockRecipe
This variable will be use to activate the fetch-service for this recipe.
Requested reviews:
Launchpad code
Diff comments:
> diff --git a/lpbuildd/target/apt.py b/lpbuildd/target/apt.py
> index 3f9ddca..d99e041 100644
> --- a/lpbuildd/target/apt.py
> +++ b/lpbuildd/target/apt.py
> @@ -13,6 +14,66 @@ from lpbuildd.target.operation import Operation
> logger = logging.getLogger(__name__)
>
>
> +def
Simone Pelosi has proposed merging ~pelpsi/launchpad:fix-rock-api-doc into
launchpad:master with ~jugmac00/launchpad:add-webservice-api-for-rock-changes
as a prerequisite.
Commit message:
Fix Rock API doc
These changes fix the URL entry point displayed on the generated
documentation
Diff comments:
> diff --git a/lpbuildd/target/apt.py b/lpbuildd/target/apt.py
> index 3f9ddca..d99e041 100644
> --- a/lpbuildd/target/apt.py
> +++ b/lpbuildd/target/apt.py
> @@ -28,12 +89,28 @@ class OverrideSourcesList(Operation):
>
> def run(self):
> logger.info("Overriding so
Thank you for your reviews ❤️ I added a parser for the sources and created the
related entry in a deb822 format, I also check if the /etc/apt/sources.list.d
folder exists: if yes I will use the new format
--
https://code.launchpad.net/~pelpsi/launchpad-buildd/+git/launchpad-buildd/+merge/473136
Simone Pelosi has proposed merging ~pelpsi/launchpad-buildd:deb822-support into
launchpad-buildd:master.
Commit message:
deb822 support
Apt supports One-Line-Style format. Create a file buildd.list inside
/etc/apt/sources.list.d/ to follow the new deb822 specifications.
https
Simone Pelosi has proposed merging
~pelpsi/launchpad-buildd:enable-fetch-service-for-rock-builds into
launchpad-buildd:master.
Commit message:
Enable fetch service for rock builds
Install the fetch service proxy on rock builds.
The reason why we need to configure some extra environment
Diff comments:
> diff --git a/lpbuildd/target/build_livefs.py b/lpbuildd/target/build_livefs.py
> index d77e1cf..59e936b 100644
> --- a/lpbuildd/target/build_livefs.py
> +++ b/lpbuildd/target/build_livefs.py
> @@ -177,6 +206,10 @@ class BuildLiveFS(SnapStoreOperationMixin, Operation):
>
Simone Pelosi has proposed merging
~pelpsi/launchpad-buildd:delete-apt-cache-before-craft-tools into
launchpad-buildd:master.
Commit message:
Delete apt cache before the fetch-service set up
The fetch-service needs to be aware of all the contents of the
Ubuntu archives in order to validate
Review: Approve
LGTM!
--
https://code.launchpad.net/~lgp171188/launchpad-mojo-specs/+git/private/+merge/472794
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
___
Mailing list: https:/
Simone Pelosi has proposed merging ~pelpsi/launchpad-buildd:release-242 into
launchpad-buildd:master.
Commit message:
Release version 242
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-buildd/+git
The proposal to merge
~pelpsi/launchpad-mojo-specs/+git/private:aligning-staging-envs-to-production
into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+g
Simone Pelosi has proposed merging
~pelpsi/launchpad-mojo-specs/+git/private:aligning-staging-envs-to-production
into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
Commit message:
Align staging environments to production
Reference:
https://code.launchpad.net/~pelpsi/launchpad-mojo
Simone Pelosi has proposed merging ~pelpsi/turnip:nofile-limit-configuration
into turnip:master.
Commit message:
Add NOFILE configuration for charms that are missing it
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
Review: Approve
LGMT!
--
https://code.launchpad.net/~lgp171188/launchpad-mojo-specs/+git/private/+merge/471842
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
___
Mailing list: https:/
The proposal to merge
~pelpsi/launchpad-mojo-specs/+git/private:remove-g-s-s-and-image-modifier-for-unused-arm64
into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-
Simone Pelosi has proposed merging
~pelpsi/launchpad-mojo-specs/+git/private:remove-g-s-s-and-image-modifier-for-unused-arm64
into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
Commit message:
Remove g-s-s and image-modifier for removed bos01 and bos02 arm64 builders
This is a
Simone Pelosi has proposed merging ~pelpsi/launchpad-buildd:nofile-limit-buildd
into launchpad-buildd:master.
Commit message:
Add LimitNOFILE configuration to launchpad-buildd deamon
This configuration is required since we are hitting the default limit 1024
in most of our builds. There was
The proposal to merge
~pelpsi/launchpad-mojo-specs/+git/private:remove-arm64-builders-bos01-and-bos02
into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/
> Thanks for linking that wiki page!
> All good from my side then, but it seem like removing the g-s-s units is not
> part of that documentation and I believe it should (maybe as a last step?).
> Can you please add it?
Yep sure! Thank you for pointing that out! I will mention that if we remove all
Yep, It should be the third step
https://wiki.canonical.com/Launchpad/PolicyandProcess/RemoveBuilders
I want to remove the g-s-s units as well but I wanted to do in a separate MP,
do you think that makes sense?
--
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/private/+merge/4710
The proposal to merge
~pelpsi/launchpad-mojo-specs/+git/private:lxd-channel-candidate-revert into
~launchpad/launchpad-mojo-specs/+git/private:vbuilder has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/priv
Simone Pelosi has proposed merging
~pelpsi/launchpad-mojo-specs/+git/private:remove-arm64-builders-bos01-and-bos02
into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
Commit message:
vbuilder: remove arm64 builders bos01 and bos02
Requested reviews:
Launchpad code reviewers
Simone Pelosi has proposed merging
~pelpsi/launchpad-mojo-specs/+git/private:lxd-channel-candidate-revert into
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
Commit message:
Revert lxd channel for arm runners
Based on this discussion:
https://code.launchpad.net/~pelpsi/launchpad
Reverted in this MP :
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/private/+merge/470876
--
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/private/+merge/470432
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:v
I see your point, so I will revert this change.
--
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/private/+merge/470432
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
__
The proposal to merge
~pelpsi/launchpad-mojo-specs/+git/private:arm-builders-lxd-channel-candidate
into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+gi
The proposal to merge
~pelpsi/launchpad-mojo-specs/+git/private:arm-builders-lxd-channel-candidate
into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder has been updated.
Commit message changed to:
vbuilder: use latest/candidate channel for lxd on arm runners
Using lxd version from latest
The proposal to merge
~pelpsi/launchpad-mojo-specs/+git/private:arm-builders-lxd-channel-candidate
into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder has been updated.
Commit message changed to:
vbuilder: use latest/candidate channel for lxd on arm runners
Request: https://warthogs.atl
The proposal to merge
~pelpsi/launchpad-mojo-specs/+git/private:arm-builders-lxd-channel-candidate
into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder has been updated.
Commit message changed to:
vbuilder: use latest/candidate channel for lxd on arm runners
Request:
https://warthogs.at
Hey! Sure, we received this request:
https://warthogs.atlassian.net/jira/software/c/projects/LP/boards/1727?label=Support&selectedIssue=LP-1753
--
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/private/+merge/470432
Your team Launchpad code reviewers is requested to review the propo
Review: Approve
LGTM!
--
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/470359
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
___
Mailing list: http
Review: Approve
LGTM!
--
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/470356
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
___
Mailing list: http
The proposal to merge
~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-revision-bump-to-6 into
~launchpad/launchpad-mojo-specs/+git/private:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/pr
Simone Pelosi has proposed merging
~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-revision-bump-to-6 into
~launchpad/launchpad-mojo-specs/+git/private:master.
Commit message:
lp-fetch-service: bump fetch-service revision to 6
Requested reviews:
Canonical Launchpad Engineering
Simone Pelosi has proposed merging
~pelpsi/launchpad-buildd:handle-base64-certificate into launchpad-buildd:master.
Commit message:
Handle Base64 certificate
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad
Simone Pelosi has proposed merging
~pelpsi/launchpad-buildd:fix-cerf-file-permissions into launchpad-buildd:master.
Commit message:
Give to the cert file the right permissions
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
Simone Pelosi has proposed merging
~pelpsi/launchpad:add-fetch-service-certificate-to-secrets into
launchpad:master.
Commit message:
Add fetch_service_mitm_certificate to secrets
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
The proposal to merge
~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charmhub-configuration
into ~launchpad/launchpad-mojo-specs/+git/private:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+gi
The proposal to merge
~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charmhub-configuration
into ~launchpad/launchpad-mojo-specs/+git/private:master has been updated.
Commit message changed to:
lp-fetch-service: Deploy fetch-service charm from Charmhub
For more details, see:
https://c
Simone Pelosi has proposed merging ~pelpsi/launchpad:unembargo-buildinfo-file
into launchpad:master.
Commit message:
Unembargo build info
Added buildinfo to unembargoed files.
LP: #2052796
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #2052796 in
Simone Pelosi has proposed merging
~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charmhub-configuration
into ~launchpad/launchpad-mojo-specs/+git/private:master.
Commit message:
Get fetch-service from Charmhub
Requested reviews:
Canonical Launchpad Engineering (launchpad)
For more
The proposal to merge ~pelpsi/launchpad:unembargo-bug-build-info-missing into
launchpad:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/464705
--
Your team Launchpad code reviewers is
Simone Pelosi has proposed merging
~pelpsi/launchpad:unembargo-bug-build-info-missing into launchpad:master.
Commit message:
Unembargo build info
Added buildinfo to unembargoed files.
Added custom upload files to unembargoed files.
Added a new endpoint buildMetadataFileUrls to retrieve
I just add there what we found during the peer programming session :)
Diff comments:
> diff --git a/lib/lp/snappy/interfaces/snapbuild.py
> b/lib/lp/snappy/interfaces/snapbuild.py
> index 52019bf..46bd205 100644
> --- a/lib/lp/snappy/interfaces/snapbuild.py
> +++ b/lib/lp/snappy/interfaces/snapb
Simone Pelosi has proposed merging
~pelpsi/launchpad:pass-information-via-XML-RPC-API-to-the-builders into
launchpad:master.
Commit message:
Passing certificate to the builders
Builders need certificate to configure correctly env to use
fetch service.
Requested reviews:
Launchpad code
The proposal to merge
~pelpsi/launchpad-buildd:pass-information-via-XML-RPC-API-to-the-builders into
launchpad-buildd:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-buildd/+git/launchpad-buildd/+merge/464
Simone Pelosi has proposed merging
~pelpsi/launchpad-buildd:pass-information-via-XML-RPC-API-to-the-builders into
launchpad-buildd:master with
~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service as a
prerequisite.
Commit message:
Pass information via XML-RPC API to the
1 - 100 of 205 matches
Mail list logo
