Ines Almeida has proposed merging ~ines-almeida/launchpad:update-package-diff-title-property into launchpad:master.
Commit message: Update PackageDiff.title Use archive.reference instead of archive.distribution in the title of a package diff Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #1633983 in Launchpad itself: "PackageDiff.title erroneously implies inter-archive diff's source is the primary archive" https://bugs.launchpad.net/launchpad/+bug/1633983 For more details, see: https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/440530 Note that Archive.reference already takes into account the ArchivePurpose, and will be different depending on it: ``` ArchivePurpose.PRIMARY: "%(distribution)s", ArchivePurpose.PPA: "~%(owner)s/%(distribution)s/%(archive)s", ArchivePurpose.PARTNER: "%(distribution)s/%(archive)s", ArchivePurpose.COPY: "%(distribution)s/%(archive)s", ``` -- Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:update-package-diff-title-property into launchpad:master.
diff --git a/lib/lp/soyuz/model/packagediff.py b/lib/lp/soyuz/model/packagediff.py index 29b909e..a6870d5 100644 --- a/lib/lp/soyuz/model/packagediff.py +++ b/lib/lp/soyuz/model/packagediff.py @@ -176,7 +176,7 @@ class PackageDiff(StormBase): else: ancestry_identifier = "%s (in %s)" % ( self.from_source.version, - ancestry_archive.distribution.name.capitalize(), + ancestry_archive.reference, ) return "diff from %s to %s" % ( ancestry_identifier,
_______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp