The proposal to merge
~ines-almeida/launchpad-mojo-specs/+git/private:lp-fetch-service into
~launchpad/launchpad-mojo-specs/+git/private:master has been updated.
Status: Needs review => Merged
For more details, see:
Review: Approve
--
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/461806
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:master.
___
Mailing list:
Ines Almeida has proposed merging
~ines-almeida/launchpad-mojo-specs/+git/private:lp-fetch-service into
~launchpad/launchpad-mojo-specs/+git/private:master.
Commit message:
lp-fetch-service: add num_units to bundle
Requested reviews:
Canonical Launchpad Engineering (launchpad)
For more
The proposal to merge
~ines-almeida/launchpad-mojo-specs/+git/private:lp-fetch-service into
~launchpad/launchpad-mojo-specs/+git/private:master has been updated.
Status: Needs review => Merged
For more details, see:
I'll go ahead and merge this MP, having in mind that it might still require
some changes to get it to the place we need it to be. Such changes can be
handled in follow-up MPs.
--
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/461232
Your team Launchpad code
Review: Approve
--
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/461232
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:master.
___
Mailing list:
The proposal to merge
~ines-almeida/launchpad-mojo-specs/+git/private:lp-fetch-service into
~launchpad/launchpad-mojo-specs/+git/private:master has been updated.
Commit message changed to:
lp-fetch-service: Add barebones of lp-fetch-service mojo spec
While the charm and snap are not public,
Thank you for the review! Comments were addressed.
I also updated the commit message to mention the service to be consistent with
other commit messages in this repo.
Diff comments:
> diff --git a/lp-fetch-service/README.md b/lp-fetch-service/README.md
> new file mode 100644
> index
Review: Approve
Diff comments:
> diff --git a/lp-fetch-service/README.md b/lp-fetch-service/README.md
> new file mode 100644
> index 000..65e09cb
> --- /dev/null
> +++ b/lp-fetch-service/README.md
> @@ -0,0 +1,21 @@
> +# Launchpad fetch service
> +
> +This spec deploys Launchpad's fetch
Ines Almeida has proposed merging
~ines-almeida/launchpad-mojo-specs/+git/private:lp-fetch-service into
~launchpad/launchpad-mojo-specs/+git/private:master.
Commit message:
Add barebones of lp-fetch-service mojo spec
While the charm and snap are not public, they require manually building,
10 matches
Mail list logo